Commit 844a18ce authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Greg Kroah-Hartman

staging: sbe-2t3e3: remove t3e3_tx_desc_t typedef

Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_tx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs
Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 692d79e1
...@@ -648,12 +648,12 @@ struct t3e3_rx_desc { ...@@ -648,12 +648,12 @@ struct t3e3_rx_desc {
/*********************/ /*********************/
typedef struct { struct t3e3_tx_desc {
u32 tdes0; u32 tdes0;
u32 tdes1; u32 tdes1;
u32 tdes2; u32 tdes2;
u32 tdes3; u32 tdes3;
} t3e3_tx_desc_t; };
#define SBE_2T3E3_TX_DESC_RING_SIZE 256 #define SBE_2T3E3_TX_DESC_RING_SIZE 256
...@@ -728,7 +728,7 @@ struct channel { ...@@ -728,7 +728,7 @@ struct channel {
u32 rx_ring_current_read; u32 rx_ring_current_read;
/* transmit chain/ring */ /* transmit chain/ring */
t3e3_tx_desc_t *tx_ring; struct t3e3_tx_desc *tx_ring;
struct sk_buff *tx_data[SBE_2T3E3_TX_DESC_RING_SIZE]; struct sk_buff *tx_data[SBE_2T3E3_TX_DESC_RING_SIZE];
u32 tx_ring_current_read; u32 tx_ring_current_read;
u32 tx_ring_current_write; u32 tx_ring_current_write;
......
...@@ -322,7 +322,7 @@ static int dc_init_descriptor_list(struct channel *sc) ...@@ -322,7 +322,7 @@ static int dc_init_descriptor_list(struct channel *sc)
if (sc->ether.tx_ring == NULL) if (sc->ether.tx_ring == NULL)
sc->ether.tx_ring = kcalloc(SBE_2T3E3_TX_DESC_RING_SIZE, sc->ether.tx_ring = kcalloc(SBE_2T3E3_TX_DESC_RING_SIZE,
sizeof(t3e3_tx_desc_t), GFP_KERNEL); sizeof(struct t3e3_tx_desc), GFP_KERNEL);
if (sc->ether.tx_ring == NULL) { if (sc->ether.tx_ring == NULL) {
kfree(sc->ether.rx_ring); kfree(sc->ether.rx_ring);
sc->ether.rx_ring = NULL; sc->ether.rx_ring = NULL;
......
...@@ -292,7 +292,7 @@ void dc_intr_tx(struct channel *sc) ...@@ -292,7 +292,7 @@ void dc_intr_tx(struct channel *sc)
{ {
u32 current_read, current_write; u32 current_read, current_write;
u32 last_segment, error; u32 last_segment, error;
t3e3_tx_desc_t *current_desc; struct t3e3_tx_desc *current_desc;
spin_lock(&sc->ether.tx_lock); spin_lock(&sc->ether.tx_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment