Commit 85149766 authored by Brian Masney's avatar Brian Masney Committed by Jonathan Cameron

staging: iio: tsl2x7x: add missing error checks

The functions in_illuminance0_calibrate_store() and
in_illuminance0_lux_table_store() did not have complete error handling
in place. This patch adds the missing error handling.
Signed-off-by: default avatarBrian Masney <masneyb@onstation.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent dbe0f59c
...@@ -940,8 +940,11 @@ static ssize_t in_illuminance0_calibrate_store(struct device *dev, ...@@ -940,8 +940,11 @@ static ssize_t in_illuminance0_calibrate_store(struct device *dev,
if (strtobool(buf, &value)) if (strtobool(buf, &value))
return -EINVAL; return -EINVAL;
if (value) if (value) {
tsl2x7x_als_calibrate(indio_dev); ret = tsl2x7x_als_calibrate(indio_dev);
if (ret < 0)
return ret;
}
ret = tsl2x7x_invoke_change(indio_dev); ret = tsl2x7x_invoke_change(indio_dev);
if (ret < 0) if (ret < 0)
...@@ -1006,8 +1009,11 @@ static ssize_t in_illuminance0_lux_table_store(struct device *dev, ...@@ -1006,8 +1009,11 @@ static ssize_t in_illuminance0_lux_table_store(struct device *dev,
return -EINVAL; return -EINVAL;
} }
if (chip->tsl2x7x_chip_status == TSL2X7X_CHIP_WORKING) if (chip->tsl2x7x_chip_status == TSL2X7X_CHIP_WORKING) {
tsl2x7x_chip_off(indio_dev); ret = tsl2x7x_chip_off(indio_dev);
if (ret < 0)
return ret;
}
/* Zero out the table */ /* Zero out the table */
memset(chip->tsl2x7x_device_lux, 0, sizeof(chip->tsl2x7x_device_lux)); memset(chip->tsl2x7x_device_lux, 0, sizeof(chip->tsl2x7x_device_lux));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment