Commit 8702624b authored by Lee Jones's avatar Lee Jones Committed by Vinod Koul

dmaengine: nbpfaxi: Provide some missing attribute docs and split out slave info

Fixes the following W=1 kernel build warning(s):

 drivers/dma/nbpfaxi.c:157: warning: Function parameter or member 'chan' not described in 'nbpf_desc'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'tasklet' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_addr' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_width' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_burst' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_addr' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_width' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_burst' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'running' not described in 'nbpf_channel'
 drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'paused' not described in 'nbpf_channel'
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Yonghong Song <yhs@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: KP Singh <kpsingh@chromium.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20200714111546.1755231-14-lee.jones@linaro.orgSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1c5933c5
...@@ -144,6 +144,7 @@ struct nbpf_link_desc { ...@@ -144,6 +144,7 @@ struct nbpf_link_desc {
* @async_tx: dmaengine object * @async_tx: dmaengine object
* @user_wait: waiting for a user ack * @user_wait: waiting for a user ack
* @length: total transfer length * @length: total transfer length
* @chan: associated DMAC channel
* @sg: list of hardware descriptors, represented by struct nbpf_link_desc * @sg: list of hardware descriptors, represented by struct nbpf_link_desc
* @node: member in channel descriptor lists * @node: member in channel descriptor lists
*/ */
...@@ -174,13 +175,17 @@ struct nbpf_desc_page { ...@@ -174,13 +175,17 @@ struct nbpf_desc_page {
/** /**
* struct nbpf_channel - one DMAC channel * struct nbpf_channel - one DMAC channel
* @dma_chan: standard dmaengine channel object * @dma_chan: standard dmaengine channel object
* @tasklet: channel specific tasklet used for callbacks
* @base: register address base * @base: register address base
* @nbpf: DMAC * @nbpf: DMAC
* @name: IRQ name * @name: IRQ name
* @irq: IRQ number * @irq: IRQ number
* @slave_addr: address for slave DMA * @slave_src_addr: source address for slave DMA
* @slave_width:slave data size in bytes * @slave_src_width: source slave data size in bytes
* @slave_burst:maximum slave burst size in bytes * @slave_src_burst: maximum source slave burst size in bytes
* @slave_dst_addr: destination address for slave DMA
* @slave_dst_width: destination slave data size in bytes
* @slave_dst_burst: maximum destination slave burst size in bytes
* @terminal: DMA terminal, assigned to this channel * @terminal: DMA terminal, assigned to this channel
* @dmarq_cfg: DMA request line configuration - high / low, edge / level for NBPF_CHAN_CFG * @dmarq_cfg: DMA request line configuration - high / low, edge / level for NBPF_CHAN_CFG
* @flags: configuration flags from DT * @flags: configuration flags from DT
...@@ -191,6 +196,8 @@ struct nbpf_desc_page { ...@@ -191,6 +196,8 @@ struct nbpf_desc_page {
* @active: list of descriptors, scheduled for processing * @active: list of descriptors, scheduled for processing
* @done: list of completed descriptors, waiting post-processing * @done: list of completed descriptors, waiting post-processing
* @desc_page: list of additionally allocated descriptor pages - if any * @desc_page: list of additionally allocated descriptor pages - if any
* @running: linked descriptor of running transaction
* @paused: are translations on this channel paused?
*/ */
struct nbpf_channel { struct nbpf_channel {
struct dma_chan dma_chan; struct dma_chan dma_chan;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment