Commit 8885cb36 authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust

SUNRPC: fix print format for tk_pid in auth_gss support

The tk_pid field is an unsigned short.  The proper print format specifier for
that type is %5u, not %4d.

Also clean up some miscellaneous print formatting nits.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent a3f565b1
...@@ -241,7 +241,7 @@ gss_fill_context(const void *p, const void *end, struct gss_cl_ctx *ctx, struct ...@@ -241,7 +241,7 @@ gss_fill_context(const void *p, const void *end, struct gss_cl_ctx *ctx, struct
} }
return q; return q;
err: err:
dprintk("RPC: gss_fill_context returning %ld\n", -PTR_ERR(p)); dprintk("RPC: gss_fill_context returning %ld\n", -PTR_ERR(p));
return p; return p;
} }
...@@ -276,10 +276,10 @@ __gss_find_upcall(struct gss_auth *gss_auth, uid_t uid) ...@@ -276,10 +276,10 @@ __gss_find_upcall(struct gss_auth *gss_auth, uid_t uid)
if (pos->uid != uid) if (pos->uid != uid)
continue; continue;
atomic_inc(&pos->count); atomic_inc(&pos->count);
dprintk("RPC: gss_find_upcall found msg %p\n", pos); dprintk("RPC: gss_find_upcall found msg %p\n", pos);
return pos; return pos;
} }
dprintk("RPC: gss_find_upcall found nothing\n"); dprintk("RPC: gss_find_upcall found nothing\n");
return NULL; return NULL;
} }
...@@ -393,7 +393,8 @@ gss_refresh_upcall(struct rpc_task *task) ...@@ -393,7 +393,8 @@ gss_refresh_upcall(struct rpc_task *task)
struct gss_upcall_msg *gss_msg; struct gss_upcall_msg *gss_msg;
int err = 0; int err = 0;
dprintk("RPC: %4u gss_refresh_upcall for uid %u\n", task->tk_pid, cred->cr_uid); dprintk("RPC: %5u gss_refresh_upcall for uid %u\n", task->tk_pid,
cred->cr_uid);
gss_msg = gss_setup_upcall(task->tk_client, gss_auth, cred); gss_msg = gss_setup_upcall(task->tk_client, gss_auth, cred);
if (IS_ERR(gss_msg)) { if (IS_ERR(gss_msg)) {
err = PTR_ERR(gss_msg); err = PTR_ERR(gss_msg);
...@@ -413,8 +414,8 @@ gss_refresh_upcall(struct rpc_task *task) ...@@ -413,8 +414,8 @@ gss_refresh_upcall(struct rpc_task *task)
spin_unlock(&gss_auth->lock); spin_unlock(&gss_auth->lock);
gss_release_msg(gss_msg); gss_release_msg(gss_msg);
out: out:
dprintk("RPC: %4u gss_refresh_upcall for uid %u result %d\n", task->tk_pid, dprintk("RPC: %5u gss_refresh_upcall for uid %u result %d\n",
cred->cr_uid, err); task->tk_pid, cred->cr_uid, err);
return err; return err;
} }
...@@ -426,7 +427,7 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred) ...@@ -426,7 +427,7 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred)
DEFINE_WAIT(wait); DEFINE_WAIT(wait);
int err = 0; int err = 0;
dprintk("RPC: gss_upcall for uid %u\n", cred->cr_uid); dprintk("RPC: gss_upcall for uid %u\n", cred->cr_uid);
gss_msg = gss_setup_upcall(gss_auth->client, gss_auth, cred); gss_msg = gss_setup_upcall(gss_auth->client, gss_auth, cred);
if (IS_ERR(gss_msg)) { if (IS_ERR(gss_msg)) {
err = PTR_ERR(gss_msg); err = PTR_ERR(gss_msg);
...@@ -454,7 +455,8 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred) ...@@ -454,7 +455,8 @@ gss_create_upcall(struct gss_auth *gss_auth, struct gss_cred *gss_cred)
finish_wait(&gss_msg->waitqueue, &wait); finish_wait(&gss_msg->waitqueue, &wait);
gss_release_msg(gss_msg); gss_release_msg(gss_msg);
out: out:
dprintk("RPC: gss_create_upcall for uid %u result %d\n", cred->cr_uid, err); dprintk("RPC: gss_create_upcall for uid %u result %d\n",
cred->cr_uid, err);
return err; return err;
} }
...@@ -546,14 +548,14 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) ...@@ -546,14 +548,14 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
} }
gss_put_ctx(ctx); gss_put_ctx(ctx);
kfree(buf); kfree(buf);
dprintk("RPC: gss_pipe_downcall returning length %Zu\n", mlen); dprintk("RPC: gss_pipe_downcall returning length %Zu\n", mlen);
return mlen; return mlen;
err_put_ctx: err_put_ctx:
gss_put_ctx(ctx); gss_put_ctx(ctx);
err: err:
kfree(buf); kfree(buf);
out: out:
dprintk("RPC: gss_pipe_downcall returning %d\n", err); dprintk("RPC: gss_pipe_downcall returning %d\n", err);
return err; return err;
} }
...@@ -591,7 +593,7 @@ gss_pipe_destroy_msg(struct rpc_pipe_msg *msg) ...@@ -591,7 +593,7 @@ gss_pipe_destroy_msg(struct rpc_pipe_msg *msg)
static unsigned long ratelimit; static unsigned long ratelimit;
if (msg->errno < 0) { if (msg->errno < 0) {
dprintk("RPC: gss_pipe_destroy_msg releasing msg %p\n", dprintk("RPC: gss_pipe_destroy_msg releasing msg %p\n",
gss_msg); gss_msg);
atomic_inc(&gss_msg->count); atomic_inc(&gss_msg->count);
gss_unhash_msg(gss_msg); gss_unhash_msg(gss_msg);
...@@ -618,7 +620,7 @@ gss_create(struct rpc_clnt *clnt, rpc_authflavor_t flavor) ...@@ -618,7 +620,7 @@ gss_create(struct rpc_clnt *clnt, rpc_authflavor_t flavor)
struct rpc_auth * auth; struct rpc_auth * auth;
int err = -ENOMEM; /* XXX? */ int err = -ENOMEM; /* XXX? */
dprintk("RPC: creating GSS authenticator for client %p\n",clnt); dprintk("RPC: creating GSS authenticator for client %p\n", clnt);
if (!try_module_get(THIS_MODULE)) if (!try_module_get(THIS_MODULE))
return ERR_PTR(err); return ERR_PTR(err);
...@@ -670,8 +672,8 @@ gss_destroy(struct rpc_auth *auth) ...@@ -670,8 +672,8 @@ gss_destroy(struct rpc_auth *auth)
{ {
struct gss_auth *gss_auth; struct gss_auth *gss_auth;
dprintk("RPC: destroying GSS authenticator %p flavor %d\n", dprintk("RPC: destroying GSS authenticator %p flavor %d\n",
auth, auth->au_flavor); auth, auth->au_flavor);
gss_auth = container_of(auth, struct gss_auth, rpc_auth); gss_auth = container_of(auth, struct gss_auth, rpc_auth);
rpc_unlink(gss_auth->dentry); rpc_unlink(gss_auth->dentry);
...@@ -689,7 +691,7 @@ gss_destroy(struct rpc_auth *auth) ...@@ -689,7 +691,7 @@ gss_destroy(struct rpc_auth *auth)
static void static void
gss_destroy_ctx(struct gss_cl_ctx *ctx) gss_destroy_ctx(struct gss_cl_ctx *ctx)
{ {
dprintk("RPC: gss_destroy_ctx\n"); dprintk("RPC: gss_destroy_ctx\n");
if (ctx->gc_gss_ctx) if (ctx->gc_gss_ctx)
gss_delete_sec_context(&ctx->gc_gss_ctx); gss_delete_sec_context(&ctx->gc_gss_ctx);
...@@ -703,7 +705,7 @@ gss_destroy_cred(struct rpc_cred *rc) ...@@ -703,7 +705,7 @@ gss_destroy_cred(struct rpc_cred *rc)
{ {
struct gss_cred *cred = container_of(rc, struct gss_cred, gc_base); struct gss_cred *cred = container_of(rc, struct gss_cred, gc_base);
dprintk("RPC: gss_destroy_cred \n"); dprintk("RPC: gss_destroy_cred \n");
if (cred->gc_ctx) if (cred->gc_ctx)
gss_put_ctx(cred->gc_ctx); gss_put_ctx(cred->gc_ctx);
...@@ -726,7 +728,7 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags) ...@@ -726,7 +728,7 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)
struct gss_cred *cred = NULL; struct gss_cred *cred = NULL;
int err = -ENOMEM; int err = -ENOMEM;
dprintk("RPC: gss_create_cred for uid %d, flavor %d\n", dprintk("RPC: gss_create_cred for uid %d, flavor %d\n",
acred->uid, auth->au_flavor); acred->uid, auth->au_flavor);
if (!(cred = kzalloc(sizeof(*cred), GFP_KERNEL))) if (!(cred = kzalloc(sizeof(*cred), GFP_KERNEL)))
...@@ -745,7 +747,7 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags) ...@@ -745,7 +747,7 @@ gss_create_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)
return &cred->gc_base; return &cred->gc_base;
out_err: out_err:
dprintk("RPC: gss_create_cred failed with error %d\n", err); dprintk("RPC: gss_create_cred failed with error %d\n", err);
return ERR_PTR(err); return ERR_PTR(err);
} }
...@@ -799,7 +801,7 @@ gss_marshal(struct rpc_task *task, __be32 *p) ...@@ -799,7 +801,7 @@ gss_marshal(struct rpc_task *task, __be32 *p)
struct kvec iov; struct kvec iov;
struct xdr_buf verf_buf; struct xdr_buf verf_buf;
dprintk("RPC: %4u gss_marshal\n", task->tk_pid); dprintk("RPC: %5u gss_marshal\n", task->tk_pid);
*p++ = htonl(RPC_AUTH_GSS); *p++ = htonl(RPC_AUTH_GSS);
cred_len = p++; cred_len = p++;
...@@ -865,7 +867,7 @@ gss_validate(struct rpc_task *task, __be32 *p) ...@@ -865,7 +867,7 @@ gss_validate(struct rpc_task *task, __be32 *p)
u32 flav,len; u32 flav,len;
u32 maj_stat; u32 maj_stat;
dprintk("RPC: %4u gss_validate\n", task->tk_pid); dprintk("RPC: %5u gss_validate\n", task->tk_pid);
flav = ntohl(*p++); flav = ntohl(*p++);
if ((len = ntohl(*p++)) > RPC_MAX_AUTH_SIZE) if ((len = ntohl(*p++)) > RPC_MAX_AUTH_SIZE)
...@@ -888,12 +890,12 @@ gss_validate(struct rpc_task *task, __be32 *p) ...@@ -888,12 +890,12 @@ gss_validate(struct rpc_task *task, __be32 *p)
* calculate the length of the verifier: */ * calculate the length of the verifier: */
task->tk_auth->au_verfsize = XDR_QUADLEN(len) + 2; task->tk_auth->au_verfsize = XDR_QUADLEN(len) + 2;
gss_put_ctx(ctx); gss_put_ctx(ctx);
dprintk("RPC: %4u GSS gss_validate: gss_verify_mic succeeded.\n", dprintk("RPC: %5u gss_validate: gss_verify_mic succeeded.\n",
task->tk_pid); task->tk_pid);
return p + XDR_QUADLEN(len); return p + XDR_QUADLEN(len);
out_bad: out_bad:
gss_put_ctx(ctx); gss_put_ctx(ctx);
dprintk("RPC: %4u gss_validate failed.\n", task->tk_pid); dprintk("RPC: %5u gss_validate failed.\n", task->tk_pid);
return NULL; return NULL;
} }
...@@ -1063,7 +1065,7 @@ gss_wrap_req(struct rpc_task *task, ...@@ -1063,7 +1065,7 @@ gss_wrap_req(struct rpc_task *task,
struct gss_cl_ctx *ctx = gss_cred_get_ctx(cred); struct gss_cl_ctx *ctx = gss_cred_get_ctx(cred);
int status = -EIO; int status = -EIO;
dprintk("RPC: %4u gss_wrap_req\n", task->tk_pid); dprintk("RPC: %5u gss_wrap_req\n", task->tk_pid);
if (ctx->gc_proc != RPC_GSS_PROC_DATA) { if (ctx->gc_proc != RPC_GSS_PROC_DATA) {
/* The spec seems a little ambiguous here, but I think that not /* The spec seems a little ambiguous here, but I think that not
* wrapping context destruction requests makes the most sense. * wrapping context destruction requests makes the most sense.
...@@ -1086,7 +1088,7 @@ gss_wrap_req(struct rpc_task *task, ...@@ -1086,7 +1088,7 @@ gss_wrap_req(struct rpc_task *task,
} }
out: out:
gss_put_ctx(ctx); gss_put_ctx(ctx);
dprintk("RPC: %4u gss_wrap_req returning %d\n", task->tk_pid, status); dprintk("RPC: %5u gss_wrap_req returning %d\n", task->tk_pid, status);
return status; return status;
} }
...@@ -1192,7 +1194,7 @@ gss_unwrap_resp(struct rpc_task *task, ...@@ -1192,7 +1194,7 @@ gss_unwrap_resp(struct rpc_task *task,
status = decode(rqstp, p, obj); status = decode(rqstp, p, obj);
out: out:
gss_put_ctx(ctx); gss_put_ctx(ctx);
dprintk("RPC: %4u gss_unwrap_resp returning %d\n", task->tk_pid, dprintk("RPC: %5u gss_unwrap_resp returning %d\n", task->tk_pid,
status); status);
return status; return status;
} }
......
...@@ -66,7 +66,7 @@ krb5_encrypt( ...@@ -66,7 +66,7 @@ krb5_encrypt(
goto out; goto out;
if (crypto_blkcipher_ivsize(tfm) > 16) { if (crypto_blkcipher_ivsize(tfm) > 16) {
dprintk("RPC: gss_k5encrypt: tfm iv size to large %d\n", dprintk("RPC: gss_k5encrypt: tfm iv size to large %d\n",
crypto_blkcipher_ivsize(tfm)); crypto_blkcipher_ivsize(tfm));
goto out; goto out;
} }
...@@ -79,7 +79,7 @@ krb5_encrypt( ...@@ -79,7 +79,7 @@ krb5_encrypt(
ret = crypto_blkcipher_encrypt_iv(&desc, sg, sg, length); ret = crypto_blkcipher_encrypt_iv(&desc, sg, sg, length);
out: out:
dprintk("RPC: krb5_encrypt returns %d\n",ret); dprintk("RPC: krb5_encrypt returns %d\n", ret);
return ret; return ret;
} }
...@@ -102,7 +102,7 @@ krb5_decrypt( ...@@ -102,7 +102,7 @@ krb5_decrypt(
goto out; goto out;
if (crypto_blkcipher_ivsize(tfm) > 16) { if (crypto_blkcipher_ivsize(tfm) > 16) {
dprintk("RPC: gss_k5decrypt: tfm iv size to large %d\n", dprintk("RPC: gss_k5decrypt: tfm iv size to large %d\n",
crypto_blkcipher_ivsize(tfm)); crypto_blkcipher_ivsize(tfm));
goto out; goto out;
} }
...@@ -114,7 +114,7 @@ krb5_decrypt( ...@@ -114,7 +114,7 @@ krb5_decrypt(
ret = crypto_blkcipher_decrypt_iv(&desc, sg, sg, length); ret = crypto_blkcipher_decrypt_iv(&desc, sg, sg, length);
out: out:
dprintk("RPC: gss_k5decrypt returns %d\n",ret); dprintk("RPC: gss_k5decrypt returns %d\n",ret);
return ret; return ret;
} }
......
...@@ -175,7 +175,8 @@ gss_import_sec_context_kerberos(const void *p, ...@@ -175,7 +175,8 @@ gss_import_sec_context_kerberos(const void *p,
} }
ctx_id->internal_ctx_id = ctx; ctx_id->internal_ctx_id = ctx;
dprintk("RPC: Successfully imported new context.\n");
dprintk("RPC: Successfully imported new context.\n");
return 0; return 0;
out_err_free_key2: out_err_free_key2:
......
...@@ -83,7 +83,7 @@ gss_get_mic_kerberos(struct gss_ctx *gss_ctx, struct xdr_buf *text, ...@@ -83,7 +83,7 @@ gss_get_mic_kerberos(struct gss_ctx *gss_ctx, struct xdr_buf *text,
s32 now; s32 now;
u32 seq_send; u32 seq_send;
dprintk("RPC: gss_krb5_seal\n"); dprintk("RPC: gss_krb5_seal\n");
now = get_seconds(); now = get_seconds();
......
...@@ -70,7 +70,7 @@ krb5_get_seq_num(struct crypto_blkcipher *key, ...@@ -70,7 +70,7 @@ krb5_get_seq_num(struct crypto_blkcipher *key,
s32 code; s32 code;
unsigned char plain[8]; unsigned char plain[8];
dprintk("RPC: krb5_get_seq_num:\n"); dprintk("RPC: krb5_get_seq_num:\n");
if ((code = krb5_decrypt(key, cksum, buf, plain, 8))) if ((code = krb5_decrypt(key, cksum, buf, plain, 8)))
return code; return code;
......
...@@ -86,7 +86,7 @@ gss_verify_mic_kerberos(struct gss_ctx *gss_ctx, ...@@ -86,7 +86,7 @@ gss_verify_mic_kerberos(struct gss_ctx *gss_ctx,
unsigned char *ptr = (unsigned char *)read_token->data; unsigned char *ptr = (unsigned char *)read_token->data;
int bodysize; int bodysize;
dprintk("RPC: krb5_read_token\n"); dprintk("RPC: krb5_read_token\n");
if (g_verify_token_header(&ctx->mech_used, &bodysize, &ptr, if (g_verify_token_header(&ctx->mech_used, &bodysize, &ptr,
read_token->len)) read_token->len))
......
...@@ -129,7 +129,7 @@ gss_wrap_kerberos(struct gss_ctx *ctx, int offset, ...@@ -129,7 +129,7 @@ gss_wrap_kerberos(struct gss_ctx *ctx, int offset,
struct page **tmp_pages; struct page **tmp_pages;
u32 seq_send; u32 seq_send;
dprintk("RPC: gss_wrap_kerberos\n"); dprintk("RPC: gss_wrap_kerberos\n");
now = get_seconds(); now = get_seconds();
...@@ -215,7 +215,7 @@ gss_unwrap_kerberos(struct gss_ctx *ctx, int offset, struct xdr_buf *buf) ...@@ -215,7 +215,7 @@ gss_unwrap_kerberos(struct gss_ctx *ctx, int offset, struct xdr_buf *buf)
int data_len; int data_len;
int blocksize; int blocksize;
dprintk("RPC: gss_unwrap_kerberos\n"); dprintk("RPC: gss_unwrap_kerberos\n");
ptr = (u8 *)buf->head[0].iov_base + offset; ptr = (u8 *)buf->head[0].iov_base + offset;
if (g_verify_token_header(&kctx->mech_used, &bodysize, &ptr, if (g_verify_token_header(&kctx->mech_used, &bodysize, &ptr,
......
...@@ -113,7 +113,7 @@ gss_mech_register(struct gss_api_mech *gm) ...@@ -113,7 +113,7 @@ gss_mech_register(struct gss_api_mech *gm)
spin_lock(&registered_mechs_lock); spin_lock(&registered_mechs_lock);
list_add(&gm->gm_list, &registered_mechs); list_add(&gm->gm_list, &registered_mechs);
spin_unlock(&registered_mechs_lock); spin_unlock(&registered_mechs_lock);
dprintk("RPC: registered gss mechanism %s\n", gm->gm_name); dprintk("RPC: registered gss mechanism %s\n", gm->gm_name);
return 0; return 0;
} }
...@@ -125,7 +125,7 @@ gss_mech_unregister(struct gss_api_mech *gm) ...@@ -125,7 +125,7 @@ gss_mech_unregister(struct gss_api_mech *gm)
spin_lock(&registered_mechs_lock); spin_lock(&registered_mechs_lock);
list_del(&gm->gm_list); list_del(&gm->gm_list);
spin_unlock(&registered_mechs_lock); spin_unlock(&registered_mechs_lock);
dprintk("RPC: unregistered gss mechanism %s\n", gm->gm_name); dprintk("RPC: unregistered gss mechanism %s\n", gm->gm_name);
gss_mech_free(gm); gss_mech_free(gm);
} }
...@@ -298,7 +298,7 @@ gss_unwrap(struct gss_ctx *ctx_id, ...@@ -298,7 +298,7 @@ gss_unwrap(struct gss_ctx *ctx_id,
u32 u32
gss_delete_sec_context(struct gss_ctx **context_handle) gss_delete_sec_context(struct gss_ctx **context_handle)
{ {
dprintk("RPC: gss_delete_sec_context deleting %p\n", dprintk("RPC: gss_delete_sec_context deleting %p\n",
*context_handle); *context_handle);
if (!*context_handle) if (!*context_handle)
......
...@@ -97,7 +97,8 @@ gss_import_sec_context_spkm3(const void *p, size_t len, ...@@ -97,7 +97,8 @@ gss_import_sec_context_spkm3(const void *p, size_t len,
if (IS_ERR(p)) if (IS_ERR(p))
goto out_err_free_ctx; goto out_err_free_ctx;
if (version != 1) { if (version != 1) {
dprintk("RPC: unknown spkm3 token format: obsolete nfs-utils?\n"); dprintk("RPC: unknown spkm3 token format: "
"obsolete nfs-utils?\n");
goto out_err_free_ctx; goto out_err_free_ctx;
} }
...@@ -138,7 +139,7 @@ gss_import_sec_context_spkm3(const void *p, size_t len, ...@@ -138,7 +139,7 @@ gss_import_sec_context_spkm3(const void *p, size_t len,
ctx_id->internal_ctx_id = ctx; ctx_id->internal_ctx_id = ctx;
dprintk("Successfully imported new spkm context.\n"); dprintk("RPC: Successfully imported new spkm context.\n");
return 0; return 0;
out_err_free_intg_key: out_err_free_intg_key:
...@@ -183,7 +184,7 @@ gss_verify_mic_spkm3(struct gss_ctx *ctx, ...@@ -183,7 +184,7 @@ gss_verify_mic_spkm3(struct gss_ctx *ctx,
maj_stat = spkm3_read_token(sctx, checksum, signbuf, SPKM_MIC_TOK); maj_stat = spkm3_read_token(sctx, checksum, signbuf, SPKM_MIC_TOK);
dprintk("RPC: gss_verify_mic_spkm3 returning %d\n", maj_stat); dprintk("RPC: gss_verify_mic_spkm3 returning %d\n", maj_stat);
return maj_stat; return maj_stat;
} }
...@@ -197,7 +198,7 @@ gss_get_mic_spkm3(struct gss_ctx *ctx, ...@@ -197,7 +198,7 @@ gss_get_mic_spkm3(struct gss_ctx *ctx,
err = spkm3_make_token(sctx, message_buffer, err = spkm3_make_token(sctx, message_buffer,
message_token, SPKM_MIC_TOK); message_token, SPKM_MIC_TOK);
dprintk("RPC: gss_get_mic_spkm3 returning %d\n", err); dprintk("RPC: gss_get_mic_spkm3 returning %d\n", err);
return err; return err;
} }
......
...@@ -75,20 +75,21 @@ spkm3_make_token(struct spkm3_ctx *ctx, ...@@ -75,20 +75,21 @@ spkm3_make_token(struct spkm3_ctx *ctx,
now = jiffies; now = jiffies;
if (ctx->ctx_id.len != 16) { if (ctx->ctx_id.len != 16) {
dprintk("RPC: spkm3_make_token BAD ctx_id.len %d\n", dprintk("RPC: spkm3_make_token BAD ctx_id.len %d\n",
ctx->ctx_id.len); ctx->ctx_id.len);
goto out_err; goto out_err;
} }
if (!g_OID_equal(&ctx->intg_alg, &hmac_md5_oid)) { if (!g_OID_equal(&ctx->intg_alg, &hmac_md5_oid)) {
dprintk("RPC: gss_spkm3_seal: unsupported I-ALG algorithm." dprintk("RPC: gss_spkm3_seal: unsupported I-ALG "
"only support hmac-md5 I-ALG.\n"); "algorithm. only support hmac-md5 I-ALG.\n");
goto out_err; goto out_err;
} else } else
checksum_type = CKSUMTYPE_HMAC_MD5; checksum_type = CKSUMTYPE_HMAC_MD5;
if (!g_OID_equal(&ctx->conf_alg, &cast5_cbc_oid)) { if (!g_OID_equal(&ctx->conf_alg, &cast5_cbc_oid)) {
dprintk("RPC: gss_spkm3_seal: unsupported C-ALG algorithm\n"); dprintk("RPC: gss_spkm3_seal: unsupported C-ALG "
"algorithm\n");
goto out_err; goto out_err;
} }
...@@ -113,7 +114,8 @@ spkm3_make_token(struct spkm3_ctx *ctx, ...@@ -113,7 +114,8 @@ spkm3_make_token(struct spkm3_ctx *ctx,
spkm3_make_mic_token(&ptr, tokenlen, &mic_hdr, &md5cksum, md5elen, md5zbit); spkm3_make_mic_token(&ptr, tokenlen, &mic_hdr, &md5cksum, md5elen, md5zbit);
} else if (toktype == SPKM_WRAP_TOK) { /* Not Supported */ } else if (toktype == SPKM_WRAP_TOK) { /* Not Supported */
dprintk("RPC: gss_spkm3_seal: SPKM_WRAP_TOK not supported\n"); dprintk("RPC: gss_spkm3_seal: SPKM_WRAP_TOK "
"not supported\n");
goto out_err; goto out_err;
} }
...@@ -153,7 +155,7 @@ make_spkm3_checksum(s32 cksumtype, struct xdr_netobj *key, char *header, ...@@ -153,7 +155,7 @@ make_spkm3_checksum(s32 cksumtype, struct xdr_netobj *key, char *header,
cksumname = "md5"; cksumname = "md5";
break; break;
default: default:
dprintk("RPC: spkm3_make_checksum:" dprintk("RPC: spkm3_make_checksum:"
" unsupported checksum %d", cksumtype); " unsupported checksum %d", cksumtype);
return GSS_S_FAILURE; return GSS_S_FAILURE;
} }
......
...@@ -209,7 +209,7 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck ...@@ -209,7 +209,7 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck
/* spkm3 innercontext token preamble */ /* spkm3 innercontext token preamble */
if ((ptr[0] != 0xa4) || (ptr[2] != 0x30)) { if ((ptr[0] != 0xa4) || (ptr[2] != 0x30)) {
dprintk("RPC: BAD SPKM ictoken preamble\n"); dprintk("RPC: BAD SPKM ictoken preamble\n");
goto out; goto out;
} }
...@@ -217,25 +217,25 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck ...@@ -217,25 +217,25 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck
/* token type */ /* token type */
if ((ptr[4] != 0x02) || (ptr[5] != 0x02)) { if ((ptr[4] != 0x02) || (ptr[5] != 0x02)) {
dprintk("RPC: BAD asn1 SPKM3 token type\n"); dprintk("RPC: BAD asn1 SPKM3 token type\n");
goto out; goto out;
} }
/* only support SPKM_MIC_TOK */ /* only support SPKM_MIC_TOK */
if((ptr[6] != 0x01) || (ptr[7] != 0x01)) { if((ptr[6] != 0x01) || (ptr[7] != 0x01)) {
dprintk("RPC: ERROR unsupported SPKM3 token \n"); dprintk("RPC: ERROR unsupported SPKM3 token \n");
goto out; goto out;
} }
/* contextid */ /* contextid */
if (ptr[8] != 0x03) { if (ptr[8] != 0x03) {
dprintk("RPC: BAD SPKM3 asn1 context-id type\n"); dprintk("RPC: BAD SPKM3 asn1 context-id type\n");
goto out; goto out;
} }
ctxelen = ptr[9]; ctxelen = ptr[9];
if (ctxelen > 17) { /* length includes asn1 zbit octet */ if (ctxelen > 17) { /* length includes asn1 zbit octet */
dprintk("RPC: BAD SPKM3 contextid len %d\n", ctxelen); dprintk("RPC: BAD SPKM3 contextid len %d\n", ctxelen);
goto out; goto out;
} }
...@@ -251,7 +251,9 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck ...@@ -251,7 +251,9 @@ spkm3_verify_mic_token(unsigned char **tokp, int *mic_hdrlen, unsigned char **ck
*/ */
if (*mic_hdrlen != 6 + ctxelen) { if (*mic_hdrlen != 6 + ctxelen) {
dprintk("RPC: BAD SPKM_ MIC_TOK header len %d: we only support default int-alg (should be absent) and do not support snd-seq\n", *mic_hdrlen); dprintk("RPC: BAD SPKM_ MIC_TOK header len %d: we only "
"support default int-alg (should be absent) "
"and do not support snd-seq\n", *mic_hdrlen);
goto out; goto out;
} }
/* checksum */ /* checksum */
......
...@@ -72,7 +72,7 @@ spkm3_read_token(struct spkm3_ctx *ctx, ...@@ -72,7 +72,7 @@ spkm3_read_token(struct spkm3_ctx *ctx,
/* decode the token */ /* decode the token */
if (toktype != SPKM_MIC_TOK) { if (toktype != SPKM_MIC_TOK) {
dprintk("RPC: BAD SPKM3 token type: %d\n", toktype); dprintk("RPC: BAD SPKM3 token type: %d\n", toktype);
goto out; goto out;
} }
...@@ -80,7 +80,7 @@ spkm3_read_token(struct spkm3_ctx *ctx, ...@@ -80,7 +80,7 @@ spkm3_read_token(struct spkm3_ctx *ctx,
goto out; goto out;
if (*cksum++ != 0x03) { if (*cksum++ != 0x03) {
dprintk("RPC: spkm3_read_token BAD checksum type\n"); dprintk("RPC: spkm3_read_token BAD checksum type\n");
goto out; goto out;
} }
md5elen = *cksum++; md5elen = *cksum++;
...@@ -97,7 +97,8 @@ spkm3_read_token(struct spkm3_ctx *ctx, ...@@ -97,7 +97,8 @@ spkm3_read_token(struct spkm3_ctx *ctx,
*/ */
ret = GSS_S_DEFECTIVE_TOKEN; ret = GSS_S_DEFECTIVE_TOKEN;
if (!g_OID_equal(&ctx->intg_alg, &hmac_md5_oid)) { if (!g_OID_equal(&ctx->intg_alg, &hmac_md5_oid)) {
dprintk("RPC: gss_spkm3_seal: unsupported I-ALG algorithm\n"); dprintk("RPC: gss_spkm3_seal: unsupported I-ALG "
"algorithm\n");
goto out; goto out;
} }
...@@ -113,7 +114,7 @@ spkm3_read_token(struct spkm3_ctx *ctx, ...@@ -113,7 +114,7 @@ spkm3_read_token(struct spkm3_ctx *ctx,
ret = GSS_S_BAD_SIG; ret = GSS_S_BAD_SIG;
code = memcmp(md5cksum.data, wire_cksum.data, wire_cksum.len); code = memcmp(md5cksum.data, wire_cksum.data, wire_cksum.len);
if (code) { if (code) {
dprintk("RPC: bad MIC checksum\n"); dprintk("RPC: bad MIC checksum\n");
goto out; goto out;
} }
......
...@@ -669,14 +669,14 @@ gss_verify_header(struct svc_rqst *rqstp, struct rsc *rsci, ...@@ -669,14 +669,14 @@ gss_verify_header(struct svc_rqst *rqstp, struct rsc *rsci,
} }
if (gc->gc_seq > MAXSEQ) { if (gc->gc_seq > MAXSEQ) {
dprintk("RPC: svcauth_gss: discarding request with large sequence number %d\n", dprintk("RPC: svcauth_gss: discarding request with "
gc->gc_seq); "large sequence number %d\n", gc->gc_seq);
*authp = rpcsec_gsserr_ctxproblem; *authp = rpcsec_gsserr_ctxproblem;
return SVC_DENIED; return SVC_DENIED;
} }
if (!gss_check_seq_num(rsci, gc->gc_seq)) { if (!gss_check_seq_num(rsci, gc->gc_seq)) {
dprintk("RPC: svcauth_gss: discarding request with old sequence number %d\n", dprintk("RPC: svcauth_gss: discarding request with "
gc->gc_seq); "old sequence number %d\n", gc->gc_seq);
return SVC_DROP; return SVC_DROP;
} }
return SVC_OK; return SVC_OK;
...@@ -958,7 +958,8 @@ svcauth_gss_accept(struct svc_rqst *rqstp, __be32 *authp) ...@@ -958,7 +958,8 @@ svcauth_gss_accept(struct svc_rqst *rqstp, __be32 *authp)
__be32 *reject_stat = resv->iov_base + resv->iov_len; __be32 *reject_stat = resv->iov_base + resv->iov_len;
int ret; int ret;
dprintk("RPC: svcauth_gss: argv->iov_len = %zd\n",argv->iov_len); dprintk("RPC: svcauth_gss: argv->iov_len = %zd\n",
argv->iov_len);
*authp = rpc_autherr_badcred; *authp = rpc_autherr_badcred;
if (!svcdata) if (!svcdata)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment