Commit 88a745f5 authored by Jens Axboe's avatar Jens Axboe Committed by Linus Torvalds

[PATCH] request_irq() use GFP_ATOMIC

The might_sleep() thing caught ide, which calls request_irq() with a
lock held. It can be argued that this is a bad thing, however I think it
can also validly be argued that requesting an irq should not be a
blocking operation. This might even remove some driver bugs where usage
count is not incremented during init...

It can also be argued, that the very first irq requests cannot be
blocking for io anyways, for good reason :-)
parent 9170c9ef
......@@ -455,7 +455,7 @@ int request_irq(unsigned int irq,
return -EINVAL;
action = (struct irqaction *)
kmalloc(sizeof(struct irqaction), GFP_KERNEL);
kmalloc(sizeof(struct irqaction), GFP_ATOMIC);
if (!action)
return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment