Commit 89716dc3 authored by Frank Rowand's avatar Frank Rowand Committed by Rob Herring

of: unittest: add caution to function header comment

Name of function attach_node_and_children() is misleading because
if the node already exists in the livetree then only the node's
properties are attached.  This works for the existing test data,
but add comment warning of this misleading name.
Signed-off-by: default avatarFrank Rowand <frank.rowand@sony.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent fd25ffdf
...@@ -1127,7 +1127,11 @@ static void update_node_properties(struct device_node *np, ...@@ -1127,7 +1127,11 @@ static void update_node_properties(struct device_node *np,
/** /**
* attach_node_and_children - attaches nodes * attach_node_and_children - attaches nodes
* and its children to live tree * and its children to live tree.
* CAUTION: misleading function name - if node @np already exists in
* the live tree then children of @np are *not* attached to the live
* tree. This works for the current test devicetree nodes because such
* nodes do not have child nodes.
* *
* @np: Node to attach to live tree * @np: Node to attach to live tree
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment