Commit 89eba7db authored by Mimi Zohar's avatar Mimi Zohar Committed by Shuah Khan

selftests/kexec: cleanup the kexec selftest

Remove the few bashisms and use the complete option name for clarity.
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
Reviewed-by: default avatarPetr Vorel <pvorel@suse.cz>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent c3c0e811
#!/bin/sh #!/bin/sh
# SPDX-License-Identifier: GPL-2.0+ # SPDX-License-Identifier: GPL-2.0
# Loading a kernel image via the kexec_load syscall should fail # Loading a kernel image via the kexec_load syscall should fail
# when the kerne is CONFIG_KEXEC_VERIFY_SIG enabled and the system # when the kernel is CONFIG_KEXEC_VERIFY_SIG enabled and the system
# is booted in secureboot mode. # is booted in secureboot mode.
TEST="$0" TEST="$0"
...@@ -12,8 +12,8 @@ rc=0 ...@@ -12,8 +12,8 @@ rc=0
ksft_skip=4 ksft_skip=4
# kexec requires root privileges # kexec requires root privileges
if [ $UID != 0 ]; then if [ $(id -ru) -ne 0 ]; then
echo "$TEST: must be run as root" >&2 echo "$TEST: requires root privileges" >&2
exit $ksft_skip exit $ksft_skip
fi fi
...@@ -33,17 +33,17 @@ secureboot=`hexdump $file | awk '{print substr($4,length($4),1)}'` ...@@ -33,17 +33,17 @@ secureboot=`hexdump $file | awk '{print substr($4,length($4),1)}'`
# kexec_load should fail in secure boot mode # kexec_load should fail in secure boot mode
KERNEL_IMAGE="/boot/vmlinuz-`uname -r`" KERNEL_IMAGE="/boot/vmlinuz-`uname -r`"
kexec -l $KERNEL_IMAGE &>> /dev/null kexec --load $KERNEL_IMAGE > /dev/null 2>&1
if [ $? == 0 ]; then if [ $? -eq 0 ]; then
kexec -u kexec --unload
if [ "$secureboot" == "1" ]; then if [ $secureboot -eq 1 ]; then
echo "$TEST: kexec_load succeeded [FAIL]" echo "$TEST: kexec_load succeeded [FAIL]"
rc=1 rc=1
else else
echo "$TEST: kexec_load succeeded [PASS]" echo "$TEST: kexec_load succeeded [PASS]"
fi fi
else else
if [ "$secureboot" == "1" ]; then if [ $secureboot -eq 1 ]; then
echo "$TEST: kexec_load failed [PASS]" echo "$TEST: kexec_load failed [PASS]"
else else
echo "$TEST: kexec_load failed [FAIL]" echo "$TEST: kexec_load failed [FAIL]"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment