Commit 8a246ee4 authored by Andrey Borzenkov's avatar Andrey Borzenkov Committed by Linus Torvalds

make /proc/acpi/ac_adapter dependent on ACPI_PROCFS

Do not provide /proc/acpi/ac_adapter if ACPI_PROCFS is not defined.  This
eliminates duplicated power adapters in HAL and makes it consistent with
battery module
Signed-off-by: default avatarAndrey Borzenkov <arvidjaar@mail.ru>
Acked-by: default avatarAlexey Starikovskiy <astarikovskiy@suse.de>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f9615984
...@@ -27,8 +27,10 @@ ...@@ -27,8 +27,10 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/types.h> #include <linux/types.h>
#ifdef CONFIG_ACPI_PROCFS
#include <linux/proc_fs.h> #include <linux/proc_fs.h>
#include <linux/seq_file.h> #include <linux/seq_file.h>
#endif
#include <linux/power_supply.h> #include <linux/power_supply.h>
#include <acpi/acpi_bus.h> #include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h> #include <acpi/acpi_drivers.h>
...@@ -49,12 +51,14 @@ MODULE_AUTHOR("Paul Diefenbaugh"); ...@@ -49,12 +51,14 @@ MODULE_AUTHOR("Paul Diefenbaugh");
MODULE_DESCRIPTION("ACPI AC Adapter Driver"); MODULE_DESCRIPTION("ACPI AC Adapter Driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
#ifdef CONFIG_ACPI_PROCFS
extern struct proc_dir_entry *acpi_lock_ac_dir(void); extern struct proc_dir_entry *acpi_lock_ac_dir(void);
extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir); extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);
#endif
static int acpi_ac_add(struct acpi_device *device); static int acpi_ac_add(struct acpi_device *device);
static int acpi_ac_remove(struct acpi_device *device, int type); static int acpi_ac_remove(struct acpi_device *device, int type);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);
const static struct acpi_device_id ac_device_ids[] = { const static struct acpi_device_id ac_device_ids[] = {
{"ACPI0003", 0}, {"ACPI0003", 0},
...@@ -80,12 +84,15 @@ struct acpi_ac { ...@@ -80,12 +84,15 @@ struct acpi_ac {
#define to_acpi_ac(x) container_of(x, struct acpi_ac, charger); #define to_acpi_ac(x) container_of(x, struct acpi_ac, charger);
#ifdef CONFIG_ACPI_PROCFS
static const struct file_operations acpi_ac_fops = { static const struct file_operations acpi_ac_fops = {
.open = acpi_ac_open_fs, .open = acpi_ac_open_fs,
.read = seq_read, .read = seq_read,
.llseek = seq_lseek, .llseek = seq_lseek,
.release = single_release, .release = single_release,
}; };
#endif
static int get_ac_property(struct power_supply *psy, static int get_ac_property(struct power_supply *psy,
enum power_supply_property psp, enum power_supply_property psp,
union power_supply_propval *val) union power_supply_propval *val)
...@@ -127,6 +134,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac) ...@@ -127,6 +134,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac)
return 0; return 0;
} }
#ifdef CONFIG_ACPI_PROCFS
/* -------------------------------------------------------------------------- /* --------------------------------------------------------------------------
FS Interface (/proc) FS Interface (/proc)
-------------------------------------------------------------------------- */ -------------------------------------------------------------------------- */
...@@ -206,6 +214,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device) ...@@ -206,6 +214,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device)
return 0; return 0;
} }
#endif
/* -------------------------------------------------------------------------- /* --------------------------------------------------------------------------
Driver Model Driver Model
...@@ -264,7 +273,9 @@ static int acpi_ac_add(struct acpi_device *device) ...@@ -264,7 +273,9 @@ static int acpi_ac_add(struct acpi_device *device)
if (result) if (result)
goto end; goto end;
#ifdef CONFIG_ACPI_PROCFS
result = acpi_ac_add_fs(device); result = acpi_ac_add_fs(device);
#endif
if (result) if (result)
goto end; goto end;
ac->charger.name = acpi_device_bid(device); ac->charger.name = acpi_device_bid(device);
...@@ -287,7 +298,9 @@ static int acpi_ac_add(struct acpi_device *device) ...@@ -287,7 +298,9 @@ static int acpi_ac_add(struct acpi_device *device)
end: end:
if (result) { if (result) {
#ifdef CONFIG_ACPI_PROCFS
acpi_ac_remove_fs(device); acpi_ac_remove_fs(device);
#endif
kfree(ac); kfree(ac);
} }
...@@ -309,7 +322,9 @@ static int acpi_ac_remove(struct acpi_device *device, int type) ...@@ -309,7 +322,9 @@ static int acpi_ac_remove(struct acpi_device *device, int type)
ACPI_ALL_NOTIFY, acpi_ac_notify); ACPI_ALL_NOTIFY, acpi_ac_notify);
if (ac->charger.dev) if (ac->charger.dev)
power_supply_unregister(&ac->charger); power_supply_unregister(&ac->charger);
#ifdef CONFIG_ACPI_PROCFS
acpi_ac_remove_fs(device); acpi_ac_remove_fs(device);
#endif
kfree(ac); kfree(ac);
...@@ -323,13 +338,17 @@ static int __init acpi_ac_init(void) ...@@ -323,13 +338,17 @@ static int __init acpi_ac_init(void)
if (acpi_disabled) if (acpi_disabled)
return -ENODEV; return -ENODEV;
#ifdef CONFIG_ACPI_PROCFS
acpi_ac_dir = acpi_lock_ac_dir(); acpi_ac_dir = acpi_lock_ac_dir();
if (!acpi_ac_dir) if (!acpi_ac_dir)
return -ENODEV; return -ENODEV;
#endif
result = acpi_bus_register_driver(&acpi_ac_driver); result = acpi_bus_register_driver(&acpi_ac_driver);
if (result < 0) { if (result < 0) {
#ifdef CONFIG_ACPI_PROCFS
acpi_unlock_ac_dir(acpi_ac_dir); acpi_unlock_ac_dir(acpi_ac_dir);
#endif
return -ENODEV; return -ENODEV;
} }
...@@ -341,7 +360,9 @@ static void __exit acpi_ac_exit(void) ...@@ -341,7 +360,9 @@ static void __exit acpi_ac_exit(void)
acpi_bus_unregister_driver(&acpi_ac_driver); acpi_bus_unregister_driver(&acpi_ac_driver);
#ifdef CONFIG_ACPI_PROCFS
acpi_unlock_ac_dir(acpi_ac_dir); acpi_unlock_ac_dir(acpi_ac_dir);
#endif
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment