Commit 8a29f2b0 authored by Michael Halcrow's avatar Michael Halcrow Committed by Linus Torvalds

eCryptfs: release mutex on hash error path

Release the crypt_stat hash mutex on allocation error. Check for error
conditions when doing crypto hash calls.
Signed-off-by: default avatarMichael Halcrow <mhalcrow@us.ibm.com>
Reported-by: default avatarKazuki Ohta <kazuki.ohta@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 778d1a2b
...@@ -115,11 +115,29 @@ static int ecryptfs_calculate_md5(char *dst, ...@@ -115,11 +115,29 @@ static int ecryptfs_calculate_md5(char *dst,
} }
crypt_stat->hash_tfm = desc.tfm; crypt_stat->hash_tfm = desc.tfm;
} }
crypto_hash_init(&desc); rc = crypto_hash_init(&desc);
crypto_hash_update(&desc, &sg, len); if (rc) {
crypto_hash_final(&desc, dst); printk(KERN_ERR
mutex_unlock(&crypt_stat->cs_hash_tfm_mutex); "%s: Error initializing crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
rc = crypto_hash_update(&desc, &sg, len);
if (rc) {
printk(KERN_ERR
"%s: Error updating crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
rc = crypto_hash_final(&desc, dst);
if (rc) {
printk(KERN_ERR
"%s: Error finalizing crypto hash; rc = [%d]\n",
__FUNCTION__, rc);
goto out;
}
out: out:
mutex_unlock(&crypt_stat->cs_hash_tfm_mutex);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment