Commit 8ac09251 authored by Trond Myklebust's avatar Trond Myklebust

NFSv4.1: Fix a deadlock in layoutget

We cannot call nfs4_handle_exception() without first ensuring that the
slot has been freed. If not, we end up deadlocking with the process
waiting for recovery to complete, and recovery waiting for the slot
table to drain.

Fixes: 2e80dbe7 ("NFSv4.1: Close callback races for OPEN, LAYOUTGET...")
Cc: stable@vger.kernel.org # v4.8+
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 7a308bb3
...@@ -8490,6 +8490,7 @@ nfs4_layoutget_handle_exception(struct rpc_task *task, ...@@ -8490,6 +8490,7 @@ nfs4_layoutget_handle_exception(struct rpc_task *task,
goto out; goto out;
} }
nfs4_sequence_free_slot(&lgp->res.seq_res);
err = nfs4_handle_exception(server, nfs4err, exception); err = nfs4_handle_exception(server, nfs4err, exception);
if (!status) { if (!status) {
if (exception->retry) if (exception->retry)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment