Commit 8d3d7c20 authored by Bjørn Mork's avatar Bjørn Mork Committed by Jakub Kicinski

usbnet: ignore endpoints with invalid wMaxPacketSize

Endpoints with zero wMaxPacketSize are not usable for transferring
data. Ignore such endpoints when looking for valid in, out and
status pipes, to make the drivers more robust against invalid and
meaningless descriptors.

The wMaxPacketSize of these endpoints are used for memory allocations
and as divisors in many usbnet minidrivers. Avoiding zero is therefore
critical.
Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
parent 3fe4b335
...@@ -100,6 +100,11 @@ int usbnet_get_endpoints(struct usbnet *dev, struct usb_interface *intf) ...@@ -100,6 +100,11 @@ int usbnet_get_endpoints(struct usbnet *dev, struct usb_interface *intf)
int intr = 0; int intr = 0;
e = alt->endpoint + ep; e = alt->endpoint + ep;
/* ignore endpoints which cannot transfer data */
if (!usb_endpoint_maxp(&e->desc))
continue;
switch (e->desc.bmAttributes) { switch (e->desc.bmAttributes) {
case USB_ENDPOINT_XFER_INT: case USB_ENDPOINT_XFER_INT:
if (!usb_endpoint_dir_in(&e->desc)) if (!usb_endpoint_dir_in(&e->desc))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment