Commit 8e025ae2 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller

qede: Don't report link change needlessly

There are several corner cases where driver might get a 2nd notification
about the same link change. Don't log any additional changes if the
physical carrier is already reported as it should.
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b1199b10
...@@ -2780,13 +2780,17 @@ static void qede_link_update(void *dev, struct qed_link_output *link) ...@@ -2780,13 +2780,17 @@ static void qede_link_update(void *dev, struct qed_link_output *link)
} }
if (link->link_up) { if (link->link_up) {
DP_NOTICE(edev, "Link is up\n"); if (!netif_carrier_ok(edev->ndev)) {
netif_tx_start_all_queues(edev->ndev); DP_NOTICE(edev, "Link is up\n");
netif_carrier_on(edev->ndev); netif_tx_start_all_queues(edev->ndev);
netif_carrier_on(edev->ndev);
}
} else { } else {
DP_NOTICE(edev, "Link is down\n"); if (netif_carrier_ok(edev->ndev)) {
netif_tx_disable(edev->ndev); DP_NOTICE(edev, "Link is down\n");
netif_carrier_off(edev->ndev); netif_tx_disable(edev->ndev);
netif_carrier_off(edev->ndev);
}
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment