Commit 90cb546c authored by Tao Ma's avatar Tao Ma Committed by Mark Fasheh

ocfs2/xattr: fix credits calculation during index create

When creating a xattr index block, the old calculation forget
to add credits for the meta change of the alloc file. So add
more credits and more comments to explain it.
Signed-off-by: default avatarTao Ma <tao.ma@oracle.com>
Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
parent 4b3f6209
...@@ -2359,13 +2359,21 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, ...@@ -2359,13 +2359,21 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode,
} else } else
xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data; xb = (struct ocfs2_xattr_block *)xbs->xattr_bh->b_data;
/*
* If there is already an xattr tree, good, we can calculate
* like other b-trees. Otherwise we may have the chance of
* create a tree, the credit calculation is borrowed from
* ocfs2_calc_extend_credits with root_el = NULL. And the
* new tree will be cluster based, so no meta is needed.
*/
if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) { if (le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED) {
struct ocfs2_extent_list *el = struct ocfs2_extent_list *el =
&xb->xb_attrs.xb_root.xt_list; &xb->xb_attrs.xb_root.xt_list;
meta_add += ocfs2_extend_meta_needed(el); meta_add += ocfs2_extend_meta_needed(el);
credits += ocfs2_calc_extend_credits(inode->i_sb, credits += ocfs2_calc_extend_credits(inode->i_sb,
el, 1); el, 1);
} } else
credits += OCFS2_SUBALLOC_ALLOC + 1;
/* /*
* This cluster will be used either for new bucket or for * This cluster will be used either for new bucket or for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment