o IPX: fix permission bogosity in create_proc_entry usage

parent 0f9f7b1e
...@@ -315,15 +315,6 @@ static struct file_operations ipx_seq_socket_fops = { ...@@ -315,15 +315,6 @@ static struct file_operations ipx_seq_socket_fops = {
.release = seq_release, .release = seq_release,
}; };
static int ipx_proc_perms(struct inode* inode, int op)
{
return 0;
}
static struct inode_operations ipx_seq_inode = {
.permission = ipx_proc_perms,
};
static struct proc_dir_entry *ipx_proc_dir; static struct proc_dir_entry *ipx_proc_dir;
int __init ipx_proc_init(void) int __init ipx_proc_init(void)
...@@ -335,24 +326,21 @@ int __init ipx_proc_init(void) ...@@ -335,24 +326,21 @@ int __init ipx_proc_init(void)
if (!ipx_proc_dir) if (!ipx_proc_dir)
goto out; goto out;
p = create_proc_entry("interface", 0, ipx_proc_dir); p = create_proc_entry("interface", S_IRUGO, ipx_proc_dir);
if (!p) if (!p)
goto out_interface; goto out_interface;
p->proc_fops = &ipx_seq_interface_fops; p->proc_fops = &ipx_seq_interface_fops;
p->proc_iops = &ipx_seq_inode; p = create_proc_entry("route", S_IRUGO, ipx_proc_dir);
p = create_proc_entry("route", 0, ipx_proc_dir);
if (!p) if (!p)
goto out_route; goto out_route;
p->proc_fops = &ipx_seq_route_fops; p->proc_fops = &ipx_seq_route_fops;
p->proc_iops = &ipx_seq_inode; p = create_proc_entry("socket", S_IRUGO, ipx_proc_dir);
p = create_proc_entry("socket", 0, ipx_proc_dir);
if (!p) if (!p)
goto out_socket; goto out_socket;
p->proc_fops = &ipx_seq_socket_fops; p->proc_fops = &ipx_seq_socket_fops;
p->proc_iops = &ipx_seq_inode;
rc = 0; rc = 0;
out: out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment