Commit 90ffa646 authored by Jens Axboe's avatar Jens Axboe Committed by Linus Torvalds

[PATCH] elevator 'buglet'

Lets just kill this check -- it usually only catches drivers queueing
something in front of a started request on their own (such as shoving a
request sense in front of a failed packet command, for instance). So
it's either working around this detection in some drivers, or killing
it. I vote for the latter, patch attached against 2.5.8-pre1 :-)
parent 4ee299b7
......@@ -230,12 +230,6 @@ void elevator_linus_add_request(request_queue_t *q, struct request *rq,
elevator_t *e = &q->elevator;
int lat = 0, *latency = e->elevator_data;
/*
* it's a bug to let this rq preempt an already started request
*/
if (insert_here->next != &q->queue_head)
BUG_ON(list_entry_rq(insert_here->next)->flags & REQ_STARTED);
if (!(rq->flags & REQ_BARRIER))
lat = latency[rq_data_dir(rq)];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment