Commit 930cfe0f authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller

hinic: Use devm_kasprintf instead of hard coding it

'devm_kasprintf' is less verbose than:
   snprintf(NULL, 0, ...);
   devm_kzalloc(...);
   sprintf
so use it instead.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarZhao Chen <zhaochen6@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 407308f6
...@@ -502,7 +502,7 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq, ...@@ -502,7 +502,7 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq,
struct net_device *netdev) struct net_device *netdev)
{ {
struct hinic_qp *qp = container_of(rq, struct hinic_qp, rq); struct hinic_qp *qp = container_of(rq, struct hinic_qp, rq);
int err, pkts, irqname_len; int err, pkts;
rxq->netdev = netdev; rxq->netdev = netdev;
rxq->rq = rq; rxq->rq = rq;
...@@ -511,13 +511,11 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq, ...@@ -511,13 +511,11 @@ int hinic_init_rxq(struct hinic_rxq *rxq, struct hinic_rq *rq,
rxq_stats_init(rxq); rxq_stats_init(rxq);
irqname_len = snprintf(NULL, 0, "hinic_rxq%d", qp->q_id) + 1; rxq->irq_name = devm_kasprintf(&netdev->dev, GFP_KERNEL,
rxq->irq_name = devm_kzalloc(&netdev->dev, irqname_len, GFP_KERNEL); "hinic_rxq%d", qp->q_id);
if (!rxq->irq_name) if (!rxq->irq_name)
return -ENOMEM; return -ENOMEM;
sprintf(rxq->irq_name, "hinic_rxq%d", qp->q_id);
pkts = rx_alloc_pkts(rxq); pkts = rx_alloc_pkts(rxq);
if (!pkts) { if (!pkts) {
err = -ENOMEM; err = -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment