Commit 93632d1b authored by Rusty Russell's avatar Rusty Russell Committed by Martin Schwidefsky

[S390] cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits.

Impact: cleanup, futureproof

In fact, all cpumask ops will only be valid (in general) for bit
numbers < nr_cpu_ids.  So use that instead of NR_CPUS in various
places (I also updated the immediate sites to use the new cpumask_
operators).

This is always safe: no cpu number can be >= nr_cpu_ids, and
nr_cpu_ids is initialized to NR_CPUS at boot.
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarMike Travis <travis@sgi.com>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 6f7a321d
...@@ -297,8 +297,8 @@ static int smp_rescan_cpus_sigp(cpumask_t avail) ...@@ -297,8 +297,8 @@ static int smp_rescan_cpus_sigp(cpumask_t avail)
{ {
int cpu_id, logical_cpu; int cpu_id, logical_cpu;
logical_cpu = first_cpu(avail); logical_cpu = cpumask_first(&avail);
if (logical_cpu == NR_CPUS) if (logical_cpu >= nr_cpu_ids)
return 0; return 0;
for (cpu_id = 0; cpu_id <= 65535; cpu_id++) { for (cpu_id = 0; cpu_id <= 65535; cpu_id++) {
if (cpu_known(cpu_id)) if (cpu_known(cpu_id))
...@@ -309,8 +309,8 @@ static int smp_rescan_cpus_sigp(cpumask_t avail) ...@@ -309,8 +309,8 @@ static int smp_rescan_cpus_sigp(cpumask_t avail)
continue; continue;
cpu_set(logical_cpu, cpu_present_map); cpu_set(logical_cpu, cpu_present_map);
smp_cpu_state[logical_cpu] = CPU_STATE_CONFIGURED; smp_cpu_state[logical_cpu] = CPU_STATE_CONFIGURED;
logical_cpu = next_cpu(logical_cpu, avail); logical_cpu = cpumask_next(logical_cpu, &avail);
if (logical_cpu == NR_CPUS) if (logical_cpu >= nr_cpu_ids)
break; break;
} }
return 0; return 0;
...@@ -322,8 +322,8 @@ static int smp_rescan_cpus_sclp(cpumask_t avail) ...@@ -322,8 +322,8 @@ static int smp_rescan_cpus_sclp(cpumask_t avail)
int cpu_id, logical_cpu, cpu; int cpu_id, logical_cpu, cpu;
int rc; int rc;
logical_cpu = first_cpu(avail); logical_cpu = cpumask_first(&avail);
if (logical_cpu == NR_CPUS) if (logical_cpu >= nr_cpu_ids)
return 0; return 0;
info = kmalloc(sizeof(*info), GFP_KERNEL); info = kmalloc(sizeof(*info), GFP_KERNEL);
if (!info) if (!info)
...@@ -344,8 +344,8 @@ static int smp_rescan_cpus_sclp(cpumask_t avail) ...@@ -344,8 +344,8 @@ static int smp_rescan_cpus_sclp(cpumask_t avail)
smp_cpu_state[logical_cpu] = CPU_STATE_STANDBY; smp_cpu_state[logical_cpu] = CPU_STATE_STANDBY;
else else
smp_cpu_state[logical_cpu] = CPU_STATE_CONFIGURED; smp_cpu_state[logical_cpu] = CPU_STATE_CONFIGURED;
logical_cpu = next_cpu(logical_cpu, avail); logical_cpu = cpumask_next(logical_cpu, &avail);
if (logical_cpu == NR_CPUS) if (logical_cpu >= nr_cpu_ids)
break; break;
} }
out: out:
...@@ -591,7 +591,7 @@ static int __init setup_possible_cpus(char *s) ...@@ -591,7 +591,7 @@ static int __init setup_possible_cpus(char *s)
pcpus = simple_strtoul(s, NULL, 0); pcpus = simple_strtoul(s, NULL, 0);
cpu_possible_map = cpumask_of_cpu(0); cpu_possible_map = cpumask_of_cpu(0);
for (cpu = 1; cpu < pcpus && cpu < NR_CPUS; cpu++) for (cpu = 1; cpu < pcpus && cpu < nr_cpu_ids; cpu++)
cpu_set(cpu, cpu_possible_map); cpu_set(cpu, cpu_possible_map);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment