Commit 9376cad2 authored by Christophe Jaillet's avatar Christophe Jaillet Committed by Thierry Reding

drm/tegra: dpaux: Fix error handling

The devm_pinctrl_register() function returns an error pointer or a valid
handle. So checking for NULL here is pointless and can never trigger.

Check the returned value with IS_ERR instead and propagate this value as
done in the other functions which call devm_pinctrl_register().

Fixes: 0751bb5c ("drm/tegra: dpaux: Add pinctrl support")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 1001354c
...@@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) ...@@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
dpaux->desc.owner = THIS_MODULE; dpaux->desc.owner = THIS_MODULE;
dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
if (!dpaux->pinctrl) { if (IS_ERR(dpaux->pinctrl)) {
dev_err(&pdev->dev, "failed to register pincontrol\n"); dev_err(&pdev->dev, "failed to register pincontrol\n");
return -ENODEV; return PTR_ERR(dpaux->pinctrl);
} }
#endif #endif
/* enable and clear all interrupts */ /* enable and clear all interrupts */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment