Commit 9380fa60 authored by Mateusz Jurczyk's avatar Mateusz Jurczyk Committed by Linus Torvalds

kernel/sysctl_binary.c: check name array length in deprecated_sysctl_warning()

Prevent use of uninitialized memory (originating from the stack frame of
do_sysctl()) by verifying that the name array is filled with sufficient
input data before comparing its specific entries with integer constants.

Through timing measurement or analyzing the kernel debug logs, a
user-mode program could potentially infer the results of comparisons
against the uninitialized memory, and acquire some (very limited)
information about the state of the kernel stack.  The change also
eliminates possible future warnings by tools such as KMSAN and other
code checkers / instrumentations.

Link: http://lkml.kernel.org/r/20170524122139.21333-1-mjurczyk@google.comSigned-off-by: default avatarMateusz Jurczyk <mjurczyk@google.com>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Matthew Whitehead <tedheadster@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Alexander Potapenko <glider@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7c43a657
...@@ -1346,7 +1346,7 @@ static void deprecated_sysctl_warning(const int *name, int nlen) ...@@ -1346,7 +1346,7 @@ static void deprecated_sysctl_warning(const int *name, int nlen)
* CTL_KERN/KERN_VERSION is used by older glibc and cannot * CTL_KERN/KERN_VERSION is used by older glibc and cannot
* ever go away. * ever go away.
*/ */
if (name[0] == CTL_KERN && name[1] == KERN_VERSION) if (nlen >= 2 && name[0] == CTL_KERN && name[1] == KERN_VERSION)
return; return;
if (printk_ratelimit()) { if (printk_ratelimit()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment