Commit 95067556 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij

gpio: pxa: Fix potential NULL dereference

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7a9a5df0
...@@ -646,6 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev) ...@@ -646,6 +646,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
pchip->irq0 = irq0; pchip->irq0 = irq0;
pchip->irq1 = irq1; pchip->irq1 = irq1;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -EINVAL;
gpio_reg_base = devm_ioremap(&pdev->dev, res->start, gpio_reg_base = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (!gpio_reg_base) if (!gpio_reg_base)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment