Commit 95ad7544 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net/tls: remove redundant second null check on sgout

A duplicated null check on sgout is redundant as it is known to be
already true because of the identical earlier check. Remove it.
Detected by cppcheck:

net/tls/tls_sw.c:696: (warning) Identical inner 'if' condition is always
true.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 080aadda
...@@ -693,8 +693,7 @@ static int decrypt_skb(struct sock *sk, struct sk_buff *skb, ...@@ -693,8 +693,7 @@ static int decrypt_skb(struct sock *sk, struct sk_buff *skb,
if (!sgout) { if (!sgout) {
nsg = skb_cow_data(skb, 0, &unused) + 1; nsg = skb_cow_data(skb, 0, &unused) + 1;
sgin = kmalloc_array(nsg, sizeof(*sgin), sk->sk_allocation); sgin = kmalloc_array(nsg, sizeof(*sgin), sk->sk_allocation);
if (!sgout) sgout = sgin;
sgout = sgin;
} }
sg_init_table(sgin, nsg); sg_init_table(sgin, nsg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment