Commit 9637e516 authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by John W. Linville

ath5k: drop warning on jumbo frames

Jumbo frames are not supported, and if they are seen it is likely
a bogus frame so just silently discard them instead of warning on
them all time. Also, instead of dropping them immediately though
move the check *after* we check for all sort of frame errors. This
should enable us to discard these frames if the hardware picks
other bogus items first. Lets see if we still get those jumbo
counters increasing still with this.

Jumbo frames would happen if we tell hardware we can support
a small 802.11 chunks of DMA'd frame, hardware would split RX'd
frames into parts and we'd have to reconstruct them in software.
This is done with USB due to the bulk size but with ath5k we
already provide a good limit to hardware and this should not be
happening.

This is reported quite often and if it fills the logs then this
needs to be addressed and to avoid spurious reports.

Cc: stable@kernel.org
Signed-off-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent b1b3751c
...@@ -1931,12 +1931,6 @@ ath5k_tasklet_rx(unsigned long data) ...@@ -1931,12 +1931,6 @@ ath5k_tasklet_rx(unsigned long data)
sc->stats.rx_all_count++; sc->stats.rx_all_count++;
if (unlikely(rs.rs_more)) {
ATH5K_WARN(sc, "unsupported jumbo\n");
sc->stats.rxerr_jumbo++;
goto next;
}
if (unlikely(rs.rs_status)) { if (unlikely(rs.rs_status)) {
if (rs.rs_status & AR5K_RXERR_CRC) if (rs.rs_status & AR5K_RXERR_CRC)
sc->stats.rxerr_crc++; sc->stats.rxerr_crc++;
...@@ -1976,6 +1970,12 @@ ath5k_tasklet_rx(unsigned long data) ...@@ -1976,6 +1970,12 @@ ath5k_tasklet_rx(unsigned long data)
sc->opmode != NL80211_IFTYPE_MONITOR) sc->opmode != NL80211_IFTYPE_MONITOR)
goto next; goto next;
} }
if (unlikely(rs.rs_more)) {
sc->stats.rxerr_jumbo++;
goto next;
}
accept: accept:
next_skb = ath5k_rx_skb_alloc(sc, &next_skb_addr); next_skb = ath5k_rx_skb_alloc(sc, &next_skb_addr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment