Commit 971df15b authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Al Viro

sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names

The standard return value for unsupported attribute names is
-EOPNOTSUPP, as opposed to undefined but supported attributes
(-ENODATA).

Also, fail for attribute names like "system.sockprotonameXXX" and
simplify the code a bit.
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent e72a1a8b
...@@ -469,27 +469,15 @@ static struct socket *sockfd_lookup_light(int fd, int *err, int *fput_needed) ...@@ -469,27 +469,15 @@ static struct socket *sockfd_lookup_light(int fd, int *err, int *fput_needed)
static ssize_t sockfs_getxattr(struct dentry *dentry, struct inode *inode, static ssize_t sockfs_getxattr(struct dentry *dentry, struct inode *inode,
const char *name, void *value, size_t size) const char *name, void *value, size_t size)
{ {
const char *proto_name; if (!strcmp(name, XATTR_NAME_SOCKPROTONAME)) {
size_t proto_size;
int error;
error = -ENODATA;
if (!strncmp(name, XATTR_NAME_SOCKPROTONAME, XATTR_NAME_SOCKPROTONAME_LEN)) {
proto_name = dentry->d_name.name;
proto_size = strlen(proto_name);
if (value) { if (value) {
error = -ERANGE; if (dentry->d_name.len + 1 > size)
if (proto_size + 1 > size) return -ERANGE;
goto out; memcpy(value, dentry->d_name.name, dentry->d_name.len + 1);
strncpy(value, proto_name, proto_size + 1);
} }
error = proto_size + 1; return dentry->d_name.len + 1;
} }
return -EOPNOTSUPP;
out:
return error;
} }
static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer, static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment