Commit 986e3f6e authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller

USB NET KL5KUSB101: Fix mem leak in error path of kaweth_download_firmware()

We will leak the storage allocated by request_firmware() if the size of
the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE.
This removes the leak by calling release_firmware() before we return
-ENOSPC.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2321f3b4
...@@ -406,6 +406,7 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth, ...@@ -406,6 +406,7 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) { if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
err("Firmware too big: %zu", fw->size); err("Firmware too big: %zu", fw->size);
release_firmware(fw);
return -ENOSPC; return -ENOSPC;
} }
data_len = fw->size; data_len = fw->size;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment