Commit 997626d8 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Gao Xiang

erofs: remove unused tag argument while finding a workgroup

It is feasible to simplify erofs_find_workgroup() interface by removing
an unused function argument. While formally the argument is used in the
function itself, its assigned value is ignored on the caller side.
Signed-off-by: default avatarVladimir Zapolskiy <vladimir@tuxera.com>
Link: https://lore.kernel.org/r/20200102120118.14979-2-vladimir@tuxera.comReviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarGao Xiang <gaoxiang25@huawei.com>
parent a55861c8
...@@ -401,7 +401,7 @@ static inline void *erofs_get_pcpubuf(unsigned int pagenr) ...@@ -401,7 +401,7 @@ static inline void *erofs_get_pcpubuf(unsigned int pagenr)
#ifdef CONFIG_EROFS_FS_ZIP #ifdef CONFIG_EROFS_FS_ZIP
int erofs_workgroup_put(struct erofs_workgroup *grp); int erofs_workgroup_put(struct erofs_workgroup *grp);
struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb, struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb,
pgoff_t index, bool *tag); pgoff_t index);
int erofs_register_workgroup(struct super_block *sb, int erofs_register_workgroup(struct super_block *sb,
struct erofs_workgroup *grp, bool tag); struct erofs_workgroup *grp, bool tag);
void erofs_workgroup_free_rcu(struct erofs_workgroup *grp); void erofs_workgroup_free_rcu(struct erofs_workgroup *grp);
......
...@@ -59,7 +59,7 @@ static int erofs_workgroup_get(struct erofs_workgroup *grp) ...@@ -59,7 +59,7 @@ static int erofs_workgroup_get(struct erofs_workgroup *grp)
} }
struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb, struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb,
pgoff_t index, bool *tag) pgoff_t index)
{ {
struct erofs_sb_info *sbi = EROFS_SB(sb); struct erofs_sb_info *sbi = EROFS_SB(sb);
struct erofs_workgroup *grp; struct erofs_workgroup *grp;
...@@ -68,7 +68,6 @@ struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb, ...@@ -68,7 +68,6 @@ struct erofs_workgroup *erofs_find_workgroup(struct super_block *sb,
rcu_read_lock(); rcu_read_lock();
grp = radix_tree_lookup(&sbi->workstn_tree, index); grp = radix_tree_lookup(&sbi->workstn_tree, index);
if (grp) { if (grp) {
*tag = xa_pointer_tag(grp);
grp = xa_untag_pointer(grp); grp = xa_untag_pointer(grp);
if (erofs_workgroup_get(grp)) { if (erofs_workgroup_get(grp)) {
......
...@@ -345,9 +345,8 @@ static int z_erofs_lookup_collection(struct z_erofs_collector *clt, ...@@ -345,9 +345,8 @@ static int z_erofs_lookup_collection(struct z_erofs_collector *clt,
struct z_erofs_pcluster *pcl; struct z_erofs_pcluster *pcl;
struct z_erofs_collection *cl; struct z_erofs_collection *cl;
unsigned int length; unsigned int length;
bool tag;
grp = erofs_find_workgroup(inode->i_sb, map->m_pa >> PAGE_SHIFT, &tag); grp = erofs_find_workgroup(inode->i_sb, map->m_pa >> PAGE_SHIFT);
if (!grp) if (!grp)
return -ENOENT; return -ENOENT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment