Commit 99c1790e authored by Michael Ellerman's avatar Michael Ellerman Committed by David S. Miller

net: Remove NO_IRQ from powerpc-only network drivers

We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it
from powerpc-only drivers.
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c20cb811
...@@ -192,7 +192,7 @@ struct fman_mac_params { ...@@ -192,7 +192,7 @@ struct fman_mac_params {
/* A handle to the FM object this port related to */ /* A handle to the FM object this port related to */
void *fm; void *fm;
/* MDIO exceptions interrupt source - not valid for all /* MDIO exceptions interrupt source - not valid for all
* MACs; MUST be set to 'NO_IRQ' for MACs that don't have * MACs; MUST be set to 0 for MACs that don't have
* mdio-irq, or for polling * mdio-irq, or for polling
*/ */
void *dev_id; /* device cookie used by the exception cbs */ void *dev_id; /* device cookie used by the exception cbs */
......
...@@ -90,7 +90,7 @@ static int do_pd_setup(struct fs_enet_private *fep) ...@@ -90,7 +90,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
int ret = -EINVAL; int ret = -EINVAL;
fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0); fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0);
if (fep->interrupt == NO_IRQ) if (!fep->interrupt)
goto out; goto out;
fep->fcc.fccp = of_iomap(ofdev->dev.of_node, 0); fep->fcc.fccp = of_iomap(ofdev->dev.of_node, 0);
......
...@@ -99,7 +99,7 @@ static int do_pd_setup(struct fs_enet_private *fep) ...@@ -99,7 +99,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
struct platform_device *ofdev = to_platform_device(fep->dev); struct platform_device *ofdev = to_platform_device(fep->dev);
fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0); fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0);
if (fep->interrupt == NO_IRQ) if (!fep->interrupt)
return -EINVAL; return -EINVAL;
fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0); fep->fec.fecp = of_iomap(ofdev->dev.of_node, 0);
......
...@@ -99,7 +99,7 @@ static int do_pd_setup(struct fs_enet_private *fep) ...@@ -99,7 +99,7 @@ static int do_pd_setup(struct fs_enet_private *fep)
struct platform_device *ofdev = to_platform_device(fep->dev); struct platform_device *ofdev = to_platform_device(fep->dev);
fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0); fep->interrupt = irq_of_parse_and_map(ofdev->dev.of_node, 0);
if (fep->interrupt == NO_IRQ) if (!fep->interrupt)
return -EINVAL; return -EINVAL;
fep->scc.sccp = of_iomap(ofdev->dev.of_node, 0); fep->scc.sccp = of_iomap(ofdev->dev.of_node, 0);
......
...@@ -2750,7 +2750,7 @@ static int emac_probe(struct platform_device *ofdev) ...@@ -2750,7 +2750,7 @@ static int emac_probe(struct platform_device *ofdev)
/* Get interrupts. EMAC irq is mandatory, WOL irq is optional */ /* Get interrupts. EMAC irq is mandatory, WOL irq is optional */
dev->emac_irq = irq_of_parse_and_map(np, 0); dev->emac_irq = irq_of_parse_and_map(np, 0);
dev->wol_irq = irq_of_parse_and_map(np, 1); dev->wol_irq = irq_of_parse_and_map(np, 1);
if (dev->emac_irq == NO_IRQ) { if (!dev->emac_irq) {
printk(KERN_ERR "%s: Can't map main interrupt\n", np->full_name); printk(KERN_ERR "%s: Can't map main interrupt\n", np->full_name);
goto err_free; goto err_free;
} }
...@@ -2913,9 +2913,9 @@ static int emac_probe(struct platform_device *ofdev) ...@@ -2913,9 +2913,9 @@ static int emac_probe(struct platform_device *ofdev)
err_reg_unmap: err_reg_unmap:
iounmap(dev->emacp); iounmap(dev->emacp);
err_irq_unmap: err_irq_unmap:
if (dev->wol_irq != NO_IRQ) if (dev->wol_irq)
irq_dispose_mapping(dev->wol_irq); irq_dispose_mapping(dev->wol_irq);
if (dev->emac_irq != NO_IRQ) if (dev->emac_irq)
irq_dispose_mapping(dev->emac_irq); irq_dispose_mapping(dev->emac_irq);
err_free: err_free:
free_netdev(ndev); free_netdev(ndev);
...@@ -2957,9 +2957,9 @@ static int emac_remove(struct platform_device *ofdev) ...@@ -2957,9 +2957,9 @@ static int emac_remove(struct platform_device *ofdev)
emac_dbg_unregister(dev); emac_dbg_unregister(dev);
iounmap(dev->emacp); iounmap(dev->emacp);
if (dev->wol_irq != NO_IRQ) if (dev->wol_irq)
irq_dispose_mapping(dev->wol_irq); irq_dispose_mapping(dev->wol_irq);
if (dev->emac_irq != NO_IRQ) if (dev->emac_irq)
irq_dispose_mapping(dev->emac_irq); irq_dispose_mapping(dev->emac_irq);
free_netdev(dev->ndev); free_netdev(dev->ndev);
......
...@@ -597,9 +597,8 @@ static int mal_probe(struct platform_device *ofdev) ...@@ -597,9 +597,8 @@ static int mal_probe(struct platform_device *ofdev)
mal->rxde_irq = irq_of_parse_and_map(ofdev->dev.of_node, 4); mal->rxde_irq = irq_of_parse_and_map(ofdev->dev.of_node, 4);
} }
if (mal->txeob_irq == NO_IRQ || mal->rxeob_irq == NO_IRQ || if (!mal->txeob_irq || !mal->rxeob_irq || !mal->serr_irq ||
mal->serr_irq == NO_IRQ || mal->txde_irq == NO_IRQ || !mal->txde_irq || !mal->rxde_irq) {
mal->rxde_irq == NO_IRQ) {
printk(KERN_ERR printk(KERN_ERR
"mal%d: failed to map interrupts !\n", index); "mal%d: failed to map interrupts !\n", index);
err = -ENODEV; err = -ENODEV;
......
...@@ -1424,7 +1424,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter) ...@@ -1424,7 +1424,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter)
scrq = adapter->tx_scrq[i]; scrq = adapter->tx_scrq[i];
scrq->irq = irq_create_mapping(NULL, scrq->hw_irq); scrq->irq = irq_create_mapping(NULL, scrq->hw_irq);
if (scrq->irq == NO_IRQ) { if (!scrq->irq) {
rc = -EINVAL; rc = -EINVAL;
dev_err(dev, "Error mapping irq\n"); dev_err(dev, "Error mapping irq\n");
goto req_tx_irq_failed; goto req_tx_irq_failed;
...@@ -1444,7 +1444,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter) ...@@ -1444,7 +1444,7 @@ static int init_sub_crq_irqs(struct ibmvnic_adapter *adapter)
for (i = 0; i < adapter->req_rx_queues; i++) { for (i = 0; i < adapter->req_rx_queues; i++) {
scrq = adapter->rx_scrq[i]; scrq = adapter->rx_scrq[i];
scrq->irq = irq_create_mapping(NULL, scrq->hw_irq); scrq->irq = irq_create_mapping(NULL, scrq->hw_irq);
if (scrq->irq == NO_IRQ) { if (!scrq->irq) {
rc = -EINVAL; rc = -EINVAL;
dev_err(dev, "Error mapping irq\n"); dev_err(dev, "Error mapping irq\n");
goto req_rx_irq_failed; goto req_rx_irq_failed;
......
...@@ -1791,7 +1791,7 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) ...@@ -1791,7 +1791,7 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
gelic_card_free_chain(card, card->tx_chain.head); gelic_card_free_chain(card, card->tx_chain.head);
fail_alloc_tx: fail_alloc_tx:
free_irq(card->irq, card); free_irq(card->irq, card);
netdev->irq = NO_IRQ; netdev->irq = 0;
fail_request_irq: fail_request_irq:
ps3_sb_event_receive_port_destroy(dev, card->irq); ps3_sb_event_receive_port_destroy(dev, card->irq);
fail_alloc_irq: fail_alloc_irq:
...@@ -1843,7 +1843,7 @@ static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev) ...@@ -1843,7 +1843,7 @@ static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev)
netdev0 = card->netdev[GELIC_PORT_ETHERNET_0]; netdev0 = card->netdev[GELIC_PORT_ETHERNET_0];
/* disconnect event port */ /* disconnect event port */
free_irq(card->irq, card); free_irq(card->irq, card);
netdev0->irq = NO_IRQ; netdev0->irq = 0;
ps3_sb_event_receive_port_destroy(card->dev, card->irq); ps3_sb_event_receive_port_destroy(card->dev, card->irq);
wait_event(card->waitq, wait_event(card->waitq,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment