Commit 9ac1c320 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Herbert Xu

crypto: ux500 - do not build with -O0

The ARM allmodconfig build currently warngs because of the
ux500 crypto driver not working well with the jump label
implementation that we started using for dynamic debug, which
breaks building with 'gcc -O0':

In file included from /git/arm-soc/include/linux/jump_label.h:105:0,
                 from /git/arm-soc/include/linux/dynamic_debug.h:5,
                 from /git/arm-soc/include/linux/printk.h:289,
                 from /git/arm-soc/include/linux/kernel.h:13,
                 from /git/arm-soc/include/linux/clk.h:16,
                 from /git/arm-soc/drivers/crypto/ux500/hash/hash_core.c:16:
/git/arm-soc/arch/arm/include/asm/jump_label.h: In function 'hash_set_dma_transfer':
/git/arm-soc/arch/arm/include/asm/jump_label.h:13:7: error: asm operand 0 probably doesn't match constraints [-Werror]
  asm_volatile_goto("1:\n\t"

Turning off compiler optimizations has never really been supported
here, and it's only used when debugging the driver. I have not found
a good reason for doing this here, other than a misguided attempt
to produce more readable assembly output. Also, the driver is only
used in obsolete hardware that almost certainly nobody will spend
time debugging any more.

This just removes the -O0 flag from the compiler options.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 61dc0a44
...@@ -4,9 +4,9 @@ ...@@ -4,9 +4,9 @@
# * License terms: GNU General Public License (GPL) version 2 */ # * License terms: GNU General Public License (GPL) version 2 */
ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG
CFLAGS_cryp_core.o := -DDEBUG -O0 CFLAGS_cryp_core.o := -DDEBUG
CFLAGS_cryp.o := -DDEBUG -O0 CFLAGS_cryp.o := -DDEBUG
CFLAGS_cryp_irq.o := -DDEBUG -O0 CFLAGS_cryp_irq.o := -DDEBUG
endif endif
obj-$(CONFIG_CRYPTO_DEV_UX500_CRYP) += ux500_cryp.o obj-$(CONFIG_CRYPTO_DEV_UX500_CRYP) += ux500_cryp.o
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
# License terms: GNU General Public License (GPL) version 2 # License terms: GNU General Public License (GPL) version 2
# #
ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG ifdef CONFIG_CRYPTO_DEV_UX500_DEBUG
CFLAGS_hash_core.o := -DDEBUG -O0 CFLAGS_hash_core.o := -DDEBUG
endif endif
obj-$(CONFIG_CRYPTO_DEV_UX500_HASH) += ux500_hash.o obj-$(CONFIG_CRYPTO_DEV_UX500_HASH) += ux500_hash.o
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment