Commit 9bd0a077 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Linus Torvalds

um: should hold tasklist_lock while traversing processes

Traversing the tasks requires holding tasklist_lock, otherwise it is
unsafe.

p.s.  However, I'm not sure that calling os_kill_ptraced_process() in the
atomic context is correct.  It seem to work, but please take a closer
look.
Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent af1be5a5
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
*/ */
#include "linux/sched.h" #include "linux/sched.h"
#include "linux/spinlock.h"
#include "linux/slab.h" #include "linux/slab.h"
#include "kern_util.h" #include "kern_util.h"
#include "os.h" #include "os.h"
...@@ -22,6 +23,7 @@ static void kill_off_processes(void) ...@@ -22,6 +23,7 @@ static void kill_off_processes(void)
struct task_struct *p; struct task_struct *p;
int pid; int pid;
read_lock(&tasklist_lock);
for_each_process(p) { for_each_process(p) {
if (p->mm == NULL) if (p->mm == NULL)
continue; continue;
...@@ -29,6 +31,7 @@ static void kill_off_processes(void) ...@@ -29,6 +31,7 @@ static void kill_off_processes(void)
pid = p->mm->context.id.u.pid; pid = p->mm->context.id.u.pid;
os_kill_ptraced_process(pid, 1); os_kill_ptraced_process(pid, 1);
} }
read_unlock(&tasklist_lock);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment