Commit 9d52bf0a authored by David S. Miller's avatar David S. Miller

Merge branch 'for-upstream' of...

Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next

Johan Hedberg says:

====================
pull request: bluetooth-next 2015-05-28

Here's a set of patches intended for 4.2. The majority of the changes
are on the 802.15.4 side of things rather than Bluetooth related:

 - All sorts of cleanups & fixes to ieee802154 and related drivers
 - Rework of tx power support in ieee802154 and its drivers
 - Support for setting ieee802154 tx power through nl802154
 - New IDs for the btusb driver
 - Various cleanups & smaller fixes to btusb
 - New btrtl driver for Realtec devices
 - Fix suspend/resume for Realtek devices

Please let me know if there are any issues pulling. Thanks.
====================
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 1dcf3ac4 b5a61c30
...@@ -30,8 +30,8 @@ int sd = socket(PF_IEEE802154, SOCK_DGRAM, 0); ...@@ -30,8 +30,8 @@ int sd = socket(PF_IEEE802154, SOCK_DGRAM, 0);
The address family, socket addresses etc. are defined in the The address family, socket addresses etc. are defined in the
include/net/af_ieee802154.h header or in the special header include/net/af_ieee802154.h header or in the special header
in our userspace package (see either linux-zigbee sourceforge download page in the userspace package (see either http://wpan.cakelab.org/ or the
or git tree at git://linux-zigbee.git.sourceforge.net/gitroot/linux-zigbee). git tree at https://github.com/linux-wpan/wpan-tools).
One can use SOCK_RAW for passing raw data towards device xmit function. YMMV. One can use SOCK_RAW for passing raw data towards device xmit function. YMMV.
...@@ -49,15 +49,6 @@ Like with WiFi, there are several types of devices implementing IEEE 802.15.4. ...@@ -49,15 +49,6 @@ Like with WiFi, there are several types of devices implementing IEEE 802.15.4.
Those types of devices require different approach to be hooked into Linux kernel. Those types of devices require different approach to be hooked into Linux kernel.
MLME - MAC Level Management
============================
Most of IEEE 802.15.4 MLME interfaces are directly mapped on netlink commands.
See the include/net/nl802154.h header. Our userspace tools package
(see above) provides CLI configuration utility for radio interfaces and simple
coordinator for IEEE 802.15.4 networks as an example users of MLME protocol.
HardMAC HardMAC
======= =======
...@@ -75,8 +66,6 @@ net_device with a pointer to struct ieee802154_mlme_ops instance. The fields ...@@ -75,8 +66,6 @@ net_device with a pointer to struct ieee802154_mlme_ops instance. The fields
assoc_req, assoc_resp, disassoc_req, start_req, and scan_req are optional. assoc_req, assoc_resp, disassoc_req, start_req, and scan_req are optional.
All other fields are required. All other fields are required.
We provide an example of simple HardMAC driver at drivers/ieee802154/fakehard.c
SoftMAC SoftMAC
======= =======
...@@ -89,7 +78,8 @@ stack interface for network sniffers (e.g. WireShark). ...@@ -89,7 +78,8 @@ stack interface for network sniffers (e.g. WireShark).
This layer is going to be extended soon. This layer is going to be extended soon.
See header include/net/mac802154.h and several drivers in drivers/ieee802154/. See header include/net/mac802154.h and several drivers in
drivers/net/ieee802154/.
Device drivers API Device drivers API
...@@ -114,18 +104,17 @@ Moreover IEEE 802.15.4 device operations structure should be filled. ...@@ -114,18 +104,17 @@ Moreover IEEE 802.15.4 device operations structure should be filled.
Fake drivers Fake drivers
============ ============
In addition there are two drivers available which simulate real devices with In addition there is a driver available which simulates a real device with
HardMAC (fakehard) and SoftMAC (fakelb - IEEE 802.15.4 loopback driver) SoftMAC (fakelb - IEEE 802.15.4 loopback driver) interface. This option
interfaces. This option provides possibility to test and debug stack without provides possibility to test and debug stack without usage of real hardware.
usage of real hardware.
See sources in drivers/ieee802154 folder for more details. See sources in drivers/net/ieee802154 folder for more details.
6LoWPAN Linux implementation 6LoWPAN Linux implementation
============================ ============================
The IEEE 802.15.4 standard specifies an MTU of 128 bytes, yielding about 80 The IEEE 802.15.4 standard specifies an MTU of 127 bytes, yielding about 80
octets of actual MAC payload once security is turned on, on a wireless link octets of actual MAC payload once security is turned on, on a wireless link
with a link throughput of 250 kbps or less. The 6LoWPAN adaptation format with a link throughput of 250 kbps or less. The 6LoWPAN adaptation format
[RFC4944] was specified to carry IPv6 datagrams over such constrained links, [RFC4944] was specified to carry IPv6 datagrams over such constrained links,
...@@ -140,7 +129,8 @@ In Semptember 2011 the standard update was published - [RFC6282]. ...@@ -140,7 +129,8 @@ In Semptember 2011 the standard update was published - [RFC6282].
It deprecates HC1 and HC2 compression and defines IPHC encoding format which is It deprecates HC1 and HC2 compression and defines IPHC encoding format which is
used in this Linux implementation. used in this Linux implementation.
All the code related to 6lowpan you may find in files: net/ieee802154/6lowpan.* All the code related to 6lowpan you may find in files: net/6lowpan/*
and net/ieee802154/6lowpan/*
To setup 6lowpan interface you need (busybox release > 1.17.0): To setup 6lowpan interface you need (busybox release > 1.17.0):
1. Add IEEE802.15.4 interface and initialize PANid; 1. Add IEEE802.15.4 interface and initialize PANid;
......
...@@ -9,6 +9,10 @@ config BT_BCM ...@@ -9,6 +9,10 @@ config BT_BCM
tristate tristate
select FW_LOADER select FW_LOADER
config BT_RTL
tristate
select FW_LOADER
config BT_HCIBTUSB config BT_HCIBTUSB
tristate "HCI USB driver" tristate "HCI USB driver"
depends on USB depends on USB
...@@ -32,6 +36,17 @@ config BT_HCIBTUSB_BCM ...@@ -32,6 +36,17 @@ config BT_HCIBTUSB_BCM
Say Y here to compile support for Broadcom protocol. Say Y here to compile support for Broadcom protocol.
config BT_HCIBTUSB_RTL
bool "Realtek protocol support"
depends on BT_HCIBTUSB
select BT_RTL
default y
help
The Realtek protocol support enables firmware and configuration
download support for Realtek Bluetooth controllers.
Say Y here to compile support for Realtek protocol.
config BT_HCIBTSDIO config BT_HCIBTSDIO
tristate "HCI SDIO driver" tristate "HCI SDIO driver"
depends on MMC depends on MMC
......
...@@ -21,6 +21,7 @@ obj-$(CONFIG_BT_MRVL) += btmrvl.o ...@@ -21,6 +21,7 @@ obj-$(CONFIG_BT_MRVL) += btmrvl.o
obj-$(CONFIG_BT_MRVL_SDIO) += btmrvl_sdio.o obj-$(CONFIG_BT_MRVL_SDIO) += btmrvl_sdio.o
obj-$(CONFIG_BT_WILINK) += btwilink.o obj-$(CONFIG_BT_WILINK) += btwilink.o
obj-$(CONFIG_BT_BCM) += btbcm.o obj-$(CONFIG_BT_BCM) += btbcm.o
obj-$(CONFIG_BT_RTL) += btrtl.o
btmrvl-y := btmrvl_main.o btmrvl-y := btmrvl_main.o
btmrvl-$(CONFIG_DEBUG_FS) += btmrvl_debugfs.o btmrvl-$(CONFIG_DEBUG_FS) += btmrvl_debugfs.o
......
...@@ -55,12 +55,6 @@ int btbcm_check_bdaddr(struct hci_dev *hdev) ...@@ -55,12 +55,6 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
} }
bda = (struct hci_rp_read_bd_addr *)skb->data; bda = (struct hci_rp_read_bd_addr *)skb->data;
if (bda->status) {
BT_ERR("%s: BCM: Device address result failed (%02x)",
hdev->name, bda->status);
kfree_skb(skb);
return -bt_to_errno(bda->status);
}
/* The address 00:20:70:02:A0:00 indicates a BCM20702A0 controller /* The address 00:20:70:02:A0:00 indicates a BCM20702A0 controller
* with no configured address. * with no configured address.
......
...@@ -53,12 +53,6 @@ int btintel_check_bdaddr(struct hci_dev *hdev) ...@@ -53,12 +53,6 @@ int btintel_check_bdaddr(struct hci_dev *hdev)
} }
bda = (struct hci_rp_read_bd_addr *)skb->data; bda = (struct hci_rp_read_bd_addr *)skb->data;
if (bda->status) {
BT_ERR("%s: Intel device address result failed (%02x)",
hdev->name, bda->status);
kfree_skb(skb);
return -bt_to_errno(bda->status);
}
/* For some Intel based controllers, the default Bluetooth device /* For some Intel based controllers, the default Bluetooth device
* address 00:03:19:9E:8B:00 can be found. These controllers are * address 00:03:19:9E:8B:00 can be found. These controllers are
......
...@@ -1217,7 +1217,7 @@ static void btmrvl_sdio_dump_firmware(struct btmrvl_private *priv) ...@@ -1217,7 +1217,7 @@ static void btmrvl_sdio_dump_firmware(struct btmrvl_private *priv)
unsigned int reg, reg_start, reg_end; unsigned int reg, reg_start, reg_end;
enum rdwr_status stat; enum rdwr_status stat;
u8 *dbg_ptr, *end_ptr, *fw_dump_data, *fw_dump_ptr; u8 *dbg_ptr, *end_ptr, *fw_dump_data, *fw_dump_ptr;
u8 dump_num, idx, i, read_reg, doneflag = 0; u8 dump_num = 0, idx, i, read_reg, doneflag = 0;
u32 memory_size, fw_dump_len = 0; u32 memory_size, fw_dump_len = 0;
/* dump sdio register first */ /* dump sdio register first */
......
This diff is collapsed.
/*
* Bluetooth support for Realtek devices
*
* Copyright (C) 2015 Endless Mobile, Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
*/
#define RTL_FRAG_LEN 252
struct rtl_download_cmd {
__u8 index;
__u8 data[RTL_FRAG_LEN];
} __packed;
struct rtl_download_response {
__u8 status;
__u8 index;
} __packed;
struct rtl_rom_version_evt {
__u8 status;
__u8 version;
} __packed;
struct rtl_epatch_header {
__u8 signature[8];
__le32 fw_version;
__le16 num_patches;
} __packed;
#if IS_ENABLED(CONFIG_BT_RTL)
int btrtl_setup_realtek(struct hci_dev *hdev);
#else
static inline int btrtl_setup_realtek(struct hci_dev *hdev)
{
return -EOPNOTSUPP;
}
#endif
This diff is collapsed.
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
* *
*/ */
#define DEBUG
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <net/bluetooth/bluetooth.h> #include <net/bluetooth/bluetooth.h>
#include <net/bluetooth/hci_core.h> #include <net/bluetooth/hci_core.h>
......
...@@ -47,8 +47,8 @@ ...@@ -47,8 +47,8 @@
#include "hci_uart.h" #include "hci_uart.h"
static bool txcrc = 1; static bool txcrc = true;
static bool hciextn = 1; static bool hciextn = true;
#define BCSP_TXWINSIZE 4 #define BCSP_TXWINSIZE 4
......
...@@ -53,3 +53,13 @@ config IEEE802154_CC2520 ...@@ -53,3 +53,13 @@ config IEEE802154_CC2520
This driver can also be built as a module. To do so, say M here. This driver can also be built as a module. To do so, say M here.
the module will be called 'cc2520'. the module will be called 'cc2520'.
config IEEE802154_ATUSB
tristate "ATUSB transceiver driver"
depends on IEEE802154_DRIVERS && MAC802154 && USB
---help---
Say Y here to enable the ATUSB IEEE 802.15.4 wireless
controller.
This driver can also be built as a module. To do so say M here.
The module will be called 'atusb'.
...@@ -2,3 +2,4 @@ obj-$(CONFIG_IEEE802154_FAKELB) += fakelb.o ...@@ -2,3 +2,4 @@ obj-$(CONFIG_IEEE802154_FAKELB) += fakelb.o
obj-$(CONFIG_IEEE802154_AT86RF230) += at86rf230.o obj-$(CONFIG_IEEE802154_AT86RF230) += at86rf230.o
obj-$(CONFIG_IEEE802154_MRF24J40) += mrf24j40.o obj-$(CONFIG_IEEE802154_MRF24J40) += mrf24j40.o
obj-$(CONFIG_IEEE802154_CC2520) += cc2520.o obj-$(CONFIG_IEEE802154_CC2520) += cc2520.o
obj-$(CONFIG_IEEE802154_ATUSB) += atusb.o
This diff is collapsed.
/*
* AT86RF230/RF231 driver
*
* Copyright (C) 2009-2012 Siemens AG
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* Written by:
* Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
* Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
*/
#ifndef _AT86RF230_H
#define _AT86RF230_H
#define RG_TRX_STATUS (0x01)
#define SR_TRX_STATUS 0x01, 0x1f, 0
#define SR_RESERVED_01_3 0x01, 0x20, 5
#define SR_CCA_STATUS 0x01, 0x40, 6
#define SR_CCA_DONE 0x01, 0x80, 7
#define RG_TRX_STATE (0x02)
#define SR_TRX_CMD 0x02, 0x1f, 0
#define SR_TRAC_STATUS 0x02, 0xe0, 5
#define RG_TRX_CTRL_0 (0x03)
#define SR_CLKM_CTRL 0x03, 0x07, 0
#define SR_CLKM_SHA_SEL 0x03, 0x08, 3
#define SR_PAD_IO_CLKM 0x03, 0x30, 4
#define SR_PAD_IO 0x03, 0xc0, 6
#define RG_TRX_CTRL_1 (0x04)
#define SR_IRQ_POLARITY 0x04, 0x01, 0
#define SR_IRQ_MASK_MODE 0x04, 0x02, 1
#define SR_SPI_CMD_MODE 0x04, 0x0c, 2
#define SR_RX_BL_CTRL 0x04, 0x10, 4
#define SR_TX_AUTO_CRC_ON 0x04, 0x20, 5
#define SR_IRQ_2_EXT_EN 0x04, 0x40, 6
#define SR_PA_EXT_EN 0x04, 0x80, 7
#define RG_PHY_TX_PWR (0x05)
#define SR_TX_PWR_23X 0x05, 0x0f, 0
#define SR_PA_LT_230 0x05, 0x30, 4
#define SR_PA_BUF_LT_230 0x05, 0xc0, 6
#define SR_TX_PWR_212 0x05, 0x1f, 0
#define SR_GC_PA_212 0x05, 0x60, 5
#define SR_PA_BOOST_LT_212 0x05, 0x80, 7
#define RG_PHY_RSSI (0x06)
#define SR_RSSI 0x06, 0x1f, 0
#define SR_RND_VALUE 0x06, 0x60, 5
#define SR_RX_CRC_VALID 0x06, 0x80, 7
#define RG_PHY_ED_LEVEL (0x07)
#define SR_ED_LEVEL 0x07, 0xff, 0
#define RG_PHY_CC_CCA (0x08)
#define SR_CHANNEL 0x08, 0x1f, 0
#define SR_CCA_MODE 0x08, 0x60, 5
#define SR_CCA_REQUEST 0x08, 0x80, 7
#define RG_CCA_THRES (0x09)
#define SR_CCA_ED_THRES 0x09, 0x0f, 0
#define SR_RESERVED_09_1 0x09, 0xf0, 4
#define RG_RX_CTRL (0x0a)
#define SR_PDT_THRES 0x0a, 0x0f, 0
#define SR_RESERVED_0a_1 0x0a, 0xf0, 4
#define RG_SFD_VALUE (0x0b)
#define SR_SFD_VALUE 0x0b, 0xff, 0
#define RG_TRX_CTRL_2 (0x0c)
#define SR_OQPSK_DATA_RATE 0x0c, 0x03, 0
#define SR_SUB_MODE 0x0c, 0x04, 2
#define SR_BPSK_QPSK 0x0c, 0x08, 3
#define SR_OQPSK_SUB1_RC_EN 0x0c, 0x10, 4
#define SR_RESERVED_0c_5 0x0c, 0x60, 5
#define SR_RX_SAFE_MODE 0x0c, 0x80, 7
#define RG_ANT_DIV (0x0d)
#define SR_ANT_CTRL 0x0d, 0x03, 0
#define SR_ANT_EXT_SW_EN 0x0d, 0x04, 2
#define SR_ANT_DIV_EN 0x0d, 0x08, 3
#define SR_RESERVED_0d_2 0x0d, 0x70, 4
#define SR_ANT_SEL 0x0d, 0x80, 7
#define RG_IRQ_MASK (0x0e)
#define SR_IRQ_MASK 0x0e, 0xff, 0
#define RG_IRQ_STATUS (0x0f)
#define SR_IRQ_0_PLL_LOCK 0x0f, 0x01, 0
#define SR_IRQ_1_PLL_UNLOCK 0x0f, 0x02, 1
#define SR_IRQ_2_RX_START 0x0f, 0x04, 2
#define SR_IRQ_3_TRX_END 0x0f, 0x08, 3
#define SR_IRQ_4_CCA_ED_DONE 0x0f, 0x10, 4
#define SR_IRQ_5_AMI 0x0f, 0x20, 5
#define SR_IRQ_6_TRX_UR 0x0f, 0x40, 6
#define SR_IRQ_7_BAT_LOW 0x0f, 0x80, 7
#define RG_VREG_CTRL (0x10)
#define SR_RESERVED_10_6 0x10, 0x03, 0
#define SR_DVDD_OK 0x10, 0x04, 2
#define SR_DVREG_EXT 0x10, 0x08, 3
#define SR_RESERVED_10_3 0x10, 0x30, 4
#define SR_AVDD_OK 0x10, 0x40, 6
#define SR_AVREG_EXT 0x10, 0x80, 7
#define RG_BATMON (0x11)
#define SR_BATMON_VTH 0x11, 0x0f, 0
#define SR_BATMON_HR 0x11, 0x10, 4
#define SR_BATMON_OK 0x11, 0x20, 5
#define SR_RESERVED_11_1 0x11, 0xc0, 6
#define RG_XOSC_CTRL (0x12)
#define SR_XTAL_TRIM 0x12, 0x0f, 0
#define SR_XTAL_MODE 0x12, 0xf0, 4
#define RG_RX_SYN (0x15)
#define SR_RX_PDT_LEVEL 0x15, 0x0f, 0
#define SR_RESERVED_15_2 0x15, 0x70, 4
#define SR_RX_PDT_DIS 0x15, 0x80, 7
#define RG_XAH_CTRL_1 (0x17)
#define SR_RESERVED_17_8 0x17, 0x01, 0
#define SR_AACK_PROM_MODE 0x17, 0x02, 1
#define SR_AACK_ACK_TIME 0x17, 0x04, 2
#define SR_RESERVED_17_5 0x17, 0x08, 3
#define SR_AACK_UPLD_RES_FT 0x17, 0x10, 4
#define SR_AACK_FLTR_RES_FT 0x17, 0x20, 5
#define SR_CSMA_LBT_MODE 0x17, 0x40, 6
#define SR_RESERVED_17_1 0x17, 0x80, 7
#define RG_FTN_CTRL (0x18)
#define SR_RESERVED_18_2 0x18, 0x7f, 0
#define SR_FTN_START 0x18, 0x80, 7
#define RG_PLL_CF (0x1a)
#define SR_RESERVED_1a_2 0x1a, 0x7f, 0
#define SR_PLL_CF_START 0x1a, 0x80, 7
#define RG_PLL_DCU (0x1b)
#define SR_RESERVED_1b_3 0x1b, 0x3f, 0
#define SR_RESERVED_1b_2 0x1b, 0x40, 6
#define SR_PLL_DCU_START 0x1b, 0x80, 7
#define RG_PART_NUM (0x1c)
#define SR_PART_NUM 0x1c, 0xff, 0
#define RG_VERSION_NUM (0x1d)
#define SR_VERSION_NUM 0x1d, 0xff, 0
#define RG_MAN_ID_0 (0x1e)
#define SR_MAN_ID_0 0x1e, 0xff, 0
#define RG_MAN_ID_1 (0x1f)
#define SR_MAN_ID_1 0x1f, 0xff, 0
#define RG_SHORT_ADDR_0 (0x20)
#define SR_SHORT_ADDR_0 0x20, 0xff, 0
#define RG_SHORT_ADDR_1 (0x21)
#define SR_SHORT_ADDR_1 0x21, 0xff, 0
#define RG_PAN_ID_0 (0x22)
#define SR_PAN_ID_0 0x22, 0xff, 0
#define RG_PAN_ID_1 (0x23)
#define SR_PAN_ID_1 0x23, 0xff, 0
#define RG_IEEE_ADDR_0 (0x24)
#define SR_IEEE_ADDR_0 0x24, 0xff, 0
#define RG_IEEE_ADDR_1 (0x25)
#define SR_IEEE_ADDR_1 0x25, 0xff, 0
#define RG_IEEE_ADDR_2 (0x26)
#define SR_IEEE_ADDR_2 0x26, 0xff, 0
#define RG_IEEE_ADDR_3 (0x27)
#define SR_IEEE_ADDR_3 0x27, 0xff, 0
#define RG_IEEE_ADDR_4 (0x28)
#define SR_IEEE_ADDR_4 0x28, 0xff, 0
#define RG_IEEE_ADDR_5 (0x29)
#define SR_IEEE_ADDR_5 0x29, 0xff, 0
#define RG_IEEE_ADDR_6 (0x2a)
#define SR_IEEE_ADDR_6 0x2a, 0xff, 0
#define RG_IEEE_ADDR_7 (0x2b)
#define SR_IEEE_ADDR_7 0x2b, 0xff, 0
#define RG_XAH_CTRL_0 (0x2c)
#define SR_SLOTTED_OPERATION 0x2c, 0x01, 0
#define SR_MAX_CSMA_RETRIES 0x2c, 0x0e, 1
#define SR_MAX_FRAME_RETRIES 0x2c, 0xf0, 4
#define RG_CSMA_SEED_0 (0x2d)
#define SR_CSMA_SEED_0 0x2d, 0xff, 0
#define RG_CSMA_SEED_1 (0x2e)
#define SR_CSMA_SEED_1 0x2e, 0x07, 0
#define SR_AACK_I_AM_COORD 0x2e, 0x08, 3
#define SR_AACK_DIS_ACK 0x2e, 0x10, 4
#define SR_AACK_SET_PD 0x2e, 0x20, 5
#define SR_AACK_FVN_MODE 0x2e, 0xc0, 6
#define RG_CSMA_BE (0x2f)
#define SR_MIN_BE 0x2f, 0x0f, 0
#define SR_MAX_BE 0x2f, 0xf0, 4
#define CMD_REG 0x80
#define CMD_REG_MASK 0x3f
#define CMD_WRITE 0x40
#define CMD_FB 0x20
#define IRQ_BAT_LOW BIT(7)
#define IRQ_TRX_UR BIT(6)
#define IRQ_AMI BIT(5)
#define IRQ_CCA_ED BIT(4)
#define IRQ_TRX_END BIT(3)
#define IRQ_RX_START BIT(2)
#define IRQ_PLL_UNL BIT(1)
#define IRQ_PLL_LOCK BIT(0)
#define IRQ_ACTIVE_HIGH 0
#define IRQ_ACTIVE_LOW 1
#define STATE_P_ON 0x00 /* BUSY */
#define STATE_BUSY_RX 0x01
#define STATE_BUSY_TX 0x02
#define STATE_FORCE_TRX_OFF 0x03
#define STATE_FORCE_TX_ON 0x04 /* IDLE */
/* 0x05 */ /* INVALID_PARAMETER */
#define STATE_RX_ON 0x06
/* 0x07 */ /* SUCCESS */
#define STATE_TRX_OFF 0x08
#define STATE_TX_ON 0x09
/* 0x0a - 0x0e */ /* 0x0a - UNSUPPORTED_ATTRIBUTE */
#define STATE_SLEEP 0x0F
#define STATE_PREP_DEEP_SLEEP 0x10
#define STATE_BUSY_RX_AACK 0x11
#define STATE_BUSY_TX_ARET 0x12
#define STATE_RX_AACK_ON 0x16
#define STATE_TX_ARET_ON 0x19
#define STATE_RX_ON_NOCLK 0x1C
#define STATE_RX_AACK_ON_NOCLK 0x1D
#define STATE_BUSY_RX_AACK_NOCLK 0x1E
#define STATE_TRANSITION_IN_PROGRESS 0x1F
#define TRX_STATE_MASK (0x1F)
#endif /* !_AT86RF230_H */
This diff is collapsed.
/*
* atusb.h - Definitions shared between kernel and ATUSB firmware
*
* Written 2013 by Werner Almesberger <werner@almesberger.net>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation, version 2, or
* (at your option) any later version.
*
* This file should be identical for kernel and firmware.
* Kernel: drivers/net/ieee802154/atusb.h
* Firmware: ben-wpan/atusb/fw/include/atusb/atusb.h
*/
#ifndef _ATUSB_H
#define _ATUSB_H
#define ATUSB_VENDOR_ID 0x20b7 /* Qi Hardware*/
#define ATUSB_PRODUCT_ID 0x1540 /* 802.15.4, device 0 */
/* -- - - */
#define ATUSB_BUILD_SIZE 256 /* maximum build version/date message length */
/* Commands to our device. Make sure this is synced with the firmware */
enum atusb_requests {
ATUSB_ID = 0x00, /* system status/control grp */
ATUSB_BUILD,
ATUSB_RESET,
ATUSB_RF_RESET = 0x10, /* debug/test group */
ATUSB_POLL_INT,
ATUSB_TEST, /* atusb-sil only */
ATUSB_TIMER,
ATUSB_GPIO,
ATUSB_SLP_TR,
ATUSB_GPIO_CLEANUP,
ATUSB_REG_WRITE = 0x20, /* transceiver group */
ATUSB_REG_READ,
ATUSB_BUF_WRITE,
ATUSB_BUF_READ,
ATUSB_SRAM_WRITE,
ATUSB_SRAM_READ,
ATUSB_SPI_WRITE = 0x30, /* SPI group */
ATUSB_SPI_READ1,
ATUSB_SPI_READ2,
ATUSB_SPI_WRITE2_SYNC,
ATUSB_RX_MODE = 0x40, /* HardMAC group */
ATUSB_TX,
};
/* Direction bRequest wValue wIndex wLength
*
* ->host ATUSB_ID - - 3
* ->host ATUSB_BUILD - - #bytes
* host-> ATUSB_RESET - - 0
*
* host-> ATUSB_RF_RESET - - 0
* ->host ATUSB_POLL_INT - - 1
* host-> ATUSB_TEST - - 0
* ->host ATUSB_TIMER - - #bytes (6)
* ->host ATUSB_GPIO dir+data mask+p# 3
* host-> ATUSB_SLP_TR - - 0
* host-> ATUSB_GPIO_CLEANUP - - 0
*
* host-> ATUSB_REG_WRITE value addr 0
* ->host ATUSB_REG_READ - addr 1
* host-> ATUSB_BUF_WRITE - - #bytes
* ->host ATUSB_BUF_READ - - #bytes
* host-> ATUSB_SRAM_WRITE - addr #bytes
* ->host ATUSB_SRAM_READ - addr #bytes
*
* host-> ATUSB_SPI_WRITE byte0 byte1 #bytes
* ->host ATUSB_SPI_READ1 byte0 - #bytes
* ->host ATUSB_SPI_READ2 byte0 byte1 #bytes
* ->host ATUSB_SPI_WRITE2_SYNC byte0 byte1 0/1
*
* host-> ATUSB_RX_MODE on - 0
* host-> ATUSB_TX flags ack_seq #bytes
*/
#define ATUSB_REQ_FROM_DEV (USB_TYPE_VENDOR | USB_DIR_IN)
#define ATUSB_REQ_TO_DEV (USB_TYPE_VENDOR | USB_DIR_OUT)
#endif /* !_ATUSB_H */
...@@ -653,7 +653,7 @@ static int cc2520_register(struct cc2520_private *priv) ...@@ -653,7 +653,7 @@ static int cc2520_register(struct cc2520_private *priv)
ieee802154_random_extended_addr(&priv->hw->phy->perm_extended_addr); ieee802154_random_extended_addr(&priv->hw->phy->perm_extended_addr);
/* We do support only 2.4 Ghz */ /* We do support only 2.4 Ghz */
priv->hw->phy->channels_supported[0] = 0x7FFF800; priv->hw->phy->supported.channels[0] = 0x7FFF800;
priv->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK | priv->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK |
IEEE802154_HW_AFILT; IEEE802154_HW_AFILT;
......
...@@ -27,25 +27,25 @@ ...@@ -27,25 +27,25 @@
#include <net/mac802154.h> #include <net/mac802154.h>
#include <net/cfg802154.h> #include <net/cfg802154.h>
static int numlbs = 1; static int numlbs = 2;
struct fakelb_dev_priv { static LIST_HEAD(fakelb_phys);
struct ieee802154_hw *hw; static DEFINE_SPINLOCK(fakelb_phys_lock);
struct list_head list; static LIST_HEAD(fakelb_ifup_phys);
struct fakelb_priv *fake; static DEFINE_RWLOCK(fakelb_ifup_phys_lock);
spinlock_t lock; struct fakelb_phy {
bool working; struct ieee802154_hw *hw;
};
u8 page;
u8 channel;
struct fakelb_priv {
struct list_head list; struct list_head list;
rwlock_t lock; struct list_head list_ifup;
}; };
static int static int fakelb_hw_ed(struct ieee802154_hw *hw, u8 *level)
fakelb_hw_ed(struct ieee802154_hw *hw, u8 *level)
{ {
BUG_ON(!level); BUG_ON(!level);
*level = 0xbe; *level = 0xbe;
...@@ -53,78 +53,63 @@ fakelb_hw_ed(struct ieee802154_hw *hw, u8 *level) ...@@ -53,78 +53,63 @@ fakelb_hw_ed(struct ieee802154_hw *hw, u8 *level)
return 0; return 0;
} }
static int static int fakelb_hw_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
fakelb_hw_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
{ {
pr_debug("set channel to %d\n", channel); struct fakelb_phy *phy = hw->priv;
write_lock_bh(&fakelb_ifup_phys_lock);
phy->page = page;
phy->channel = channel;
write_unlock_bh(&fakelb_ifup_phys_lock);
return 0; return 0;
} }
static void static int fakelb_hw_xmit(struct ieee802154_hw *hw, struct sk_buff *skb)
fakelb_hw_deliver(struct fakelb_dev_priv *priv, struct sk_buff *skb)
{ {
struct sk_buff *newskb; struct fakelb_phy *current_phy = hw->priv, *phy;
spin_lock(&priv->lock); read_lock_bh(&fakelb_ifup_phys_lock);
if (priv->working) { list_for_each_entry(phy, &fakelb_ifup_phys, list_ifup) {
newskb = pskb_copy(skb, GFP_ATOMIC); if (current_phy == phy)
ieee802154_rx_irqsafe(priv->hw, newskb, 0xcc); continue;
}
spin_unlock(&priv->lock);
}
static int if (current_phy->page == phy->page &&
fakelb_hw_xmit(struct ieee802154_hw *hw, struct sk_buff *skb) current_phy->channel == phy->channel) {
{ struct sk_buff *newskb = pskb_copy(skb, GFP_ATOMIC);
struct fakelb_dev_priv *priv = hw->priv;
struct fakelb_priv *fake = priv->fake; if (newskb)
ieee802154_rx_irqsafe(phy->hw, newskb, 0xcc);
read_lock_bh(&fake->lock);
if (priv->list.next == priv->list.prev) {
/* we are the only one device */
fakelb_hw_deliver(priv, skb);
} else {
struct fakelb_dev_priv *dp;
list_for_each_entry(dp, &priv->fake->list, list) {
if (dp != priv &&
(dp->hw->phy->current_channel ==
priv->hw->phy->current_channel))
fakelb_hw_deliver(dp, skb);
} }
} }
read_unlock_bh(&fake->lock); read_unlock_bh(&fakelb_ifup_phys_lock);
ieee802154_xmit_complete(hw, skb, false);
return 0; return 0;
} }
static int static int fakelb_hw_start(struct ieee802154_hw *hw)
fakelb_hw_start(struct ieee802154_hw *hw) { {
struct fakelb_dev_priv *priv = hw->priv; struct fakelb_phy *phy = hw->priv;
int ret = 0;
spin_lock(&priv->lock); write_lock_bh(&fakelb_ifup_phys_lock);
if (priv->working) list_add(&phy->list_ifup, &fakelb_ifup_phys);
ret = -EBUSY; write_unlock_bh(&fakelb_ifup_phys_lock);
else
priv->working = 1;
spin_unlock(&priv->lock);
return ret; return 0;
} }
static void static void fakelb_hw_stop(struct ieee802154_hw *hw)
fakelb_hw_stop(struct ieee802154_hw *hw) { {
struct fakelb_dev_priv *priv = hw->priv; struct fakelb_phy *phy = hw->priv;
spin_lock(&priv->lock); write_lock_bh(&fakelb_ifup_phys_lock);
priv->working = 0; list_del(&phy->list_ifup);
spin_unlock(&priv->lock); write_unlock_bh(&fakelb_ifup_phys_lock);
} }
static const struct ieee802154_ops fakelb_ops = { static const struct ieee802154_ops fakelb_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.xmit_sync = fakelb_hw_xmit, .xmit_async = fakelb_hw_xmit,
.ed = fakelb_hw_ed, .ed = fakelb_hw_ed,
.set_channel = fakelb_hw_channel, .set_channel = fakelb_hw_channel,
.start = fakelb_hw_start, .start = fakelb_hw_start,
...@@ -135,54 +120,54 @@ static const struct ieee802154_ops fakelb_ops = { ...@@ -135,54 +120,54 @@ static const struct ieee802154_ops fakelb_ops = {
module_param(numlbs, int, 0); module_param(numlbs, int, 0);
MODULE_PARM_DESC(numlbs, " number of pseudo devices"); MODULE_PARM_DESC(numlbs, " number of pseudo devices");
static int fakelb_add_one(struct device *dev, struct fakelb_priv *fake) static int fakelb_add_one(struct device *dev)
{ {
struct fakelb_dev_priv *priv;
int err;
struct ieee802154_hw *hw; struct ieee802154_hw *hw;
struct fakelb_phy *phy;
int err;
hw = ieee802154_alloc_hw(sizeof(*priv), &fakelb_ops); hw = ieee802154_alloc_hw(sizeof(*phy), &fakelb_ops);
if (!hw) if (!hw)
return -ENOMEM; return -ENOMEM;
priv = hw->priv; phy = hw->priv;
priv->hw = hw; phy->hw = hw;
/* 868 MHz BPSK 802.15.4-2003 */ /* 868 MHz BPSK 802.15.4-2003 */
hw->phy->channels_supported[0] |= 1; hw->phy->supported.channels[0] |= 1;
/* 915 MHz BPSK 802.15.4-2003 */ /* 915 MHz BPSK 802.15.4-2003 */
hw->phy->channels_supported[0] |= 0x7fe; hw->phy->supported.channels[0] |= 0x7fe;
/* 2.4 GHz O-QPSK 802.15.4-2003 */ /* 2.4 GHz O-QPSK 802.15.4-2003 */
hw->phy->channels_supported[0] |= 0x7FFF800; hw->phy->supported.channels[0] |= 0x7FFF800;
/* 868 MHz ASK 802.15.4-2006 */ /* 868 MHz ASK 802.15.4-2006 */
hw->phy->channels_supported[1] |= 1; hw->phy->supported.channels[1] |= 1;
/* 915 MHz ASK 802.15.4-2006 */ /* 915 MHz ASK 802.15.4-2006 */
hw->phy->channels_supported[1] |= 0x7fe; hw->phy->supported.channels[1] |= 0x7fe;
/* 868 MHz O-QPSK 802.15.4-2006 */ /* 868 MHz O-QPSK 802.15.4-2006 */
hw->phy->channels_supported[2] |= 1; hw->phy->supported.channels[2] |= 1;
/* 915 MHz O-QPSK 802.15.4-2006 */ /* 915 MHz O-QPSK 802.15.4-2006 */
hw->phy->channels_supported[2] |= 0x7fe; hw->phy->supported.channels[2] |= 0x7fe;
/* 2.4 GHz CSS 802.15.4a-2007 */ /* 2.4 GHz CSS 802.15.4a-2007 */
hw->phy->channels_supported[3] |= 0x3fff; hw->phy->supported.channels[3] |= 0x3fff;
/* UWB Sub-gigahertz 802.15.4a-2007 */ /* UWB Sub-gigahertz 802.15.4a-2007 */
hw->phy->channels_supported[4] |= 1; hw->phy->supported.channels[4] |= 1;
/* UWB Low band 802.15.4a-2007 */ /* UWB Low band 802.15.4a-2007 */
hw->phy->channels_supported[4] |= 0x1e; hw->phy->supported.channels[4] |= 0x1e;
/* UWB High band 802.15.4a-2007 */ /* UWB High band 802.15.4a-2007 */
hw->phy->channels_supported[4] |= 0xffe0; hw->phy->supported.channels[4] |= 0xffe0;
/* 750 MHz O-QPSK 802.15.4c-2009 */ /* 750 MHz O-QPSK 802.15.4c-2009 */
hw->phy->channels_supported[5] |= 0xf; hw->phy->supported.channels[5] |= 0xf;
/* 750 MHz MPSK 802.15.4c-2009 */ /* 750 MHz MPSK 802.15.4c-2009 */
hw->phy->channels_supported[5] |= 0xf0; hw->phy->supported.channels[5] |= 0xf0;
/* 950 MHz BPSK 802.15.4d-2009 */ /* 950 MHz BPSK 802.15.4d-2009 */
hw->phy->channels_supported[6] |= 0x3ff; hw->phy->supported.channels[6] |= 0x3ff;
/* 950 MHz GFSK 802.15.4d-2009 */ /* 950 MHz GFSK 802.15.4d-2009 */
hw->phy->channels_supported[6] |= 0x3ffc00; hw->phy->supported.channels[6] |= 0x3ffc00;
INIT_LIST_HEAD(&priv->list); ieee802154_random_extended_addr(&hw->phy->perm_extended_addr);
priv->fake = fake; /* fake phy channel 13 as default */
hw->phy->current_channel = 13;
spin_lock_init(&priv->lock); phy->channel = hw->phy->current_channel;
hw->parent = dev; hw->parent = dev;
...@@ -190,67 +175,55 @@ static int fakelb_add_one(struct device *dev, struct fakelb_priv *fake) ...@@ -190,67 +175,55 @@ static int fakelb_add_one(struct device *dev, struct fakelb_priv *fake)
if (err) if (err)
goto err_reg; goto err_reg;
write_lock_bh(&fake->lock); spin_lock(&fakelb_phys_lock);
list_add_tail(&priv->list, &fake->list); list_add_tail(&phy->list, &fakelb_phys);
write_unlock_bh(&fake->lock); spin_unlock(&fakelb_phys_lock);
return 0; return 0;
err_reg: err_reg:
ieee802154_free_hw(priv->hw); ieee802154_free_hw(phy->hw);
return err; return err;
} }
static void fakelb_del(struct fakelb_dev_priv *priv) static void fakelb_del(struct fakelb_phy *phy)
{ {
write_lock_bh(&priv->fake->lock); list_del(&phy->list);
list_del(&priv->list);
write_unlock_bh(&priv->fake->lock);
ieee802154_unregister_hw(priv->hw); ieee802154_unregister_hw(phy->hw);
ieee802154_free_hw(priv->hw); ieee802154_free_hw(phy->hw);
} }
static int fakelb_probe(struct platform_device *pdev) static int fakelb_probe(struct platform_device *pdev)
{ {
struct fakelb_priv *priv; struct fakelb_phy *phy, *tmp;
struct fakelb_dev_priv *dp; int err, i;
int err = -ENOMEM;
int i;
priv = devm_kzalloc(&pdev->dev, sizeof(struct fakelb_priv),
GFP_KERNEL);
if (!priv)
goto err_alloc;
INIT_LIST_HEAD(&priv->list);
rwlock_init(&priv->lock);
for (i = 0; i < numlbs; i++) { for (i = 0; i < numlbs; i++) {
err = fakelb_add_one(&pdev->dev, priv); err = fakelb_add_one(&pdev->dev);
if (err < 0) if (err < 0)
goto err_slave; goto err_slave;
} }
platform_set_drvdata(pdev, priv);
dev_info(&pdev->dev, "added ieee802154 hardware\n"); dev_info(&pdev->dev, "added ieee802154 hardware\n");
return 0; return 0;
err_slave: err_slave:
list_for_each_entry(dp, &priv->list, list) spin_lock(&fakelb_phys_lock);
fakelb_del(dp); list_for_each_entry_safe(phy, tmp, &fakelb_phys, list)
err_alloc: fakelb_del(phy);
spin_unlock(&fakelb_phys_lock);
return err; return err;
} }
static int fakelb_remove(struct platform_device *pdev) static int fakelb_remove(struct platform_device *pdev)
{ {
struct fakelb_priv *priv = platform_get_drvdata(pdev); struct fakelb_phy *phy, *tmp;
struct fakelb_dev_priv *dp, *temp;
list_for_each_entry_safe(dp, temp, &priv->list, list)
fakelb_del(dp);
spin_lock(&fakelb_phys_lock);
list_for_each_entry_safe(phy, tmp, &fakelb_phys, list)
fakelb_del(phy);
spin_unlock(&fakelb_phys_lock);
return 0; return 0;
} }
......
...@@ -750,7 +750,7 @@ static int mrf24j40_probe(struct spi_device *spi) ...@@ -750,7 +750,7 @@ static int mrf24j40_probe(struct spi_device *spi)
devrec->hw->priv = devrec; devrec->hw->priv = devrec;
devrec->hw->parent = &devrec->spi->dev; devrec->hw->parent = &devrec->spi->dev;
devrec->hw->phy->channels_supported[0] = CHANNEL_MASK; devrec->hw->phy->supported.channels[0] = CHANNEL_MASK;
devrec->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK | devrec->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK |
IEEE802154_HW_AFILT; IEEE802154_HW_AFILT;
......
...@@ -44,6 +44,8 @@ struct cfg802154_ops { ...@@ -44,6 +44,8 @@ struct cfg802154_ops {
int (*set_channel)(struct wpan_phy *wpan_phy, u8 page, u8 channel); int (*set_channel)(struct wpan_phy *wpan_phy, u8 page, u8 channel);
int (*set_cca_mode)(struct wpan_phy *wpan_phy, int (*set_cca_mode)(struct wpan_phy *wpan_phy,
const struct wpan_phy_cca *cca); const struct wpan_phy_cca *cca);
int (*set_cca_ed_level)(struct wpan_phy *wpan_phy, s32 ed_level);
int (*set_tx_power)(struct wpan_phy *wpan_phy, s32 power);
int (*set_pan_id)(struct wpan_phy *wpan_phy, int (*set_pan_id)(struct wpan_phy *wpan_phy,
struct wpan_dev *wpan_dev, __le16 pan_id); struct wpan_dev *wpan_dev, __le16 pan_id);
int (*set_short_addr)(struct wpan_phy *wpan_phy, int (*set_short_addr)(struct wpan_phy *wpan_phy,
...@@ -61,14 +63,66 @@ struct cfg802154_ops { ...@@ -61,14 +63,66 @@ struct cfg802154_ops {
struct wpan_dev *wpan_dev, bool mode); struct wpan_dev *wpan_dev, bool mode);
}; };
static inline bool
wpan_phy_supported_bool(bool b, enum nl802154_supported_bool_states st)
{
switch (st) {
case NL802154_SUPPORTED_BOOL_TRUE:
return b;
case NL802154_SUPPORTED_BOOL_FALSE:
return !b;
case NL802154_SUPPORTED_BOOL_BOTH:
return true;
default:
WARN_ON(1);
}
return false;
}
struct wpan_phy_supported {
u32 channels[IEEE802154_MAX_PAGE + 1],
cca_modes, cca_opts, iftypes;
enum nl802154_supported_bool_states lbt;
u8 min_minbe, max_minbe, min_maxbe, max_maxbe,
min_csma_backoffs, max_csma_backoffs;
s8 min_frame_retries, max_frame_retries;
size_t tx_powers_size, cca_ed_levels_size;
const s32 *tx_powers, *cca_ed_levels;
};
struct wpan_phy_cca { struct wpan_phy_cca {
enum nl802154_cca_modes mode; enum nl802154_cca_modes mode;
enum nl802154_cca_opts opt; enum nl802154_cca_opts opt;
}; };
struct wpan_phy { static inline bool
struct mutex pib_lock; wpan_phy_cca_cmp(const struct wpan_phy_cca *a, const struct wpan_phy_cca *b)
{
if (a->mode != b->mode)
return false;
if (a->mode == NL802154_CCA_ENERGY_CARRIER)
return a->opt == b->opt;
return true;
}
/**
* @WPAN_PHY_FLAG_TRANSMIT_POWER: Indicates that transceiver will support
* transmit power setting.
* @WPAN_PHY_FLAG_CCA_ED_LEVEL: Indicates that transceiver will support cca ed
* level setting.
* @WPAN_PHY_FLAG_CCA_MODE: Indicates that transceiver will support cca mode
* setting.
*/
enum wpan_phy_flags {
WPAN_PHY_FLAG_TXPOWER = BIT(1),
WPAN_PHY_FLAG_CCA_ED_LEVEL = BIT(2),
WPAN_PHY_FLAG_CCA_MODE = BIT(3),
};
struct wpan_phy {
/* If multiple wpan_phys are registered and you're handed e.g. /* If multiple wpan_phys are registered and you're handed e.g.
* a regular netdev with assigned ieee802154_ptr, you won't * a regular netdev with assigned ieee802154_ptr, you won't
* know whether it points to a wpan_phy your driver has registered * know whether it points to a wpan_phy your driver has registered
...@@ -77,6 +131,8 @@ struct wpan_phy { ...@@ -77,6 +131,8 @@ struct wpan_phy {
*/ */
const void *privid; const void *privid;
u32 flags;
/* /*
* This is a PIB according to 802.15.4-2011. * This is a PIB according to 802.15.4-2011.
* We do not provide timing-related variables, as they * We do not provide timing-related variables, as they
...@@ -84,12 +140,14 @@ struct wpan_phy { ...@@ -84,12 +140,14 @@ struct wpan_phy {
*/ */
u8 current_channel; u8 current_channel;
u8 current_page; u8 current_page;
u32 channels_supported[IEEE802154_MAX_PAGE + 1]; struct wpan_phy_supported supported;
s8 transmit_power; /* current transmit_power in mBm */
s32 transmit_power;
struct wpan_phy_cca cca; struct wpan_phy_cca cca;
__le64 perm_extended_addr; __le64 perm_extended_addr;
/* current cca ed threshold in mBm */
s32 cca_ed_level; s32 cca_ed_level;
/* PHY depended MAC PIB values */ /* PHY depended MAC PIB values */
...@@ -121,9 +179,9 @@ struct wpan_dev { ...@@ -121,9 +179,9 @@ struct wpan_dev {
__le64 extended_addr; __le64 extended_addr;
/* MAC BSN field */ /* MAC BSN field */
u8 bsn; atomic_t bsn;
/* MAC DSN field */ /* MAC DSN field */
u8 dsn; atomic_t dsn;
u8 min_be; u8 min_be;
u8 max_be; u8 max_be;
......
...@@ -422,16 +422,6 @@ struct ieee802154_mlme_ops { ...@@ -422,16 +422,6 @@ struct ieee802154_mlme_ops {
struct ieee802154_mac_params *params); struct ieee802154_mac_params *params);
struct ieee802154_llsec_ops *llsec; struct ieee802154_llsec_ops *llsec;
/* The fields below are required. */
/*
* FIXME: these should become the part of PIB/MIB interface.
* However we still don't have IB interface of any kind
*/
__le16 (*get_pan_id)(const struct net_device *dev);
__le16 (*get_short_addr)(const struct net_device *dev);
u8 (*get_dsn)(const struct net_device *dev);
}; };
static inline struct ieee802154_mlme_ops * static inline struct ieee802154_mlme_ops *
...@@ -440,10 +430,4 @@ ieee802154_mlme_ops(const struct net_device *dev) ...@@ -440,10 +430,4 @@ ieee802154_mlme_ops(const struct net_device *dev)
return dev->ml_priv; return dev->ml_priv;
} }
static inline struct ieee802154_reduced_mlme_ops *
ieee802154_reduced_mlme_ops(const struct net_device *dev)
{
return dev->ml_priv;
}
#endif #endif
...@@ -89,41 +89,26 @@ struct ieee802154_hw { ...@@ -89,41 +89,26 @@ struct ieee802154_hw {
#define IEEE802154_HW_TX_OMIT_CKSUM 0x00000001 #define IEEE802154_HW_TX_OMIT_CKSUM 0x00000001
/* Indicates that receiver will autorespond with ACK frames. */ /* Indicates that receiver will autorespond with ACK frames. */
#define IEEE802154_HW_AACK 0x00000002 #define IEEE802154_HW_AACK 0x00000002
/* Indicates that transceiver will support transmit power setting. */
#define IEEE802154_HW_TXPOWER 0x00000004
/* Indicates that transceiver will support listen before transmit. */ /* Indicates that transceiver will support listen before transmit. */
#define IEEE802154_HW_LBT 0x00000008 #define IEEE802154_HW_LBT 0x00000004
/* Indicates that transceiver will support cca mode setting. */
#define IEEE802154_HW_CCA_MODE 0x00000010
/* Indicates that transceiver will support cca ed level setting. */
#define IEEE802154_HW_CCA_ED_LEVEL 0x00000020
/* Indicates that transceiver will support csma (max_be, min_be, csma retries) /* Indicates that transceiver will support csma (max_be, min_be, csma retries)
* settings. */ * settings. */
#define IEEE802154_HW_CSMA_PARAMS 0x00000040 #define IEEE802154_HW_CSMA_PARAMS 0x00000008
/* Indicates that transceiver will support ARET frame retries setting. */ /* Indicates that transceiver will support ARET frame retries setting. */
#define IEEE802154_HW_FRAME_RETRIES 0x00000080 #define IEEE802154_HW_FRAME_RETRIES 0x00000010
/* Indicates that transceiver will support hardware address filter setting. */ /* Indicates that transceiver will support hardware address filter setting. */
#define IEEE802154_HW_AFILT 0x00000100 #define IEEE802154_HW_AFILT 0x00000020
/* Indicates that transceiver will support promiscuous mode setting. */ /* Indicates that transceiver will support promiscuous mode setting. */
#define IEEE802154_HW_PROMISCUOUS 0x00000200 #define IEEE802154_HW_PROMISCUOUS 0x00000040
/* Indicates that receiver omits FCS. */ /* Indicates that receiver omits FCS. */
#define IEEE802154_HW_RX_OMIT_CKSUM 0x00000400 #define IEEE802154_HW_RX_OMIT_CKSUM 0x00000080
/* Indicates that receiver will not filter frames with bad checksum. */ /* Indicates that receiver will not filter frames with bad checksum. */
#define IEEE802154_HW_RX_DROP_BAD_CKSUM 0x00000800 #define IEEE802154_HW_RX_DROP_BAD_CKSUM 0x00000100
/* Indicates that receiver omits FCS and xmitter will add FCS on it's own. */ /* Indicates that receiver omits FCS and xmitter will add FCS on it's own. */
#define IEEE802154_HW_OMIT_CKSUM (IEEE802154_HW_TX_OMIT_CKSUM | \ #define IEEE802154_HW_OMIT_CKSUM (IEEE802154_HW_TX_OMIT_CKSUM | \
IEEE802154_HW_RX_OMIT_CKSUM) IEEE802154_HW_RX_OMIT_CKSUM)
/* This groups the most common CSMA support fields into one. */
#define IEEE802154_HW_CSMA (IEEE802154_HW_CCA_MODE | \
IEEE802154_HW_CCA_ED_LEVEL | \
IEEE802154_HW_CSMA_PARAMS)
/* This groups the most common ARET support fields into one. */
#define IEEE802154_HW_ARET (IEEE802154_HW_CSMA | \
IEEE802154_HW_FRAME_RETRIES)
/* struct ieee802154_ops - callbacks from mac802154 to the driver /* struct ieee802154_ops - callbacks from mac802154 to the driver
* *
* This structure contains various callbacks that the driver may * This structure contains various callbacks that the driver may
...@@ -171,7 +156,7 @@ struct ieee802154_hw { ...@@ -171,7 +156,7 @@ struct ieee802154_hw {
* Returns either zero, or negative errno. * Returns either zero, or negative errno.
* *
* set_txpower: * set_txpower:
* Set radio transmit power in dB. Called with pib_lock held. * Set radio transmit power in mBm. Called with pib_lock held.
* Returns either zero, or negative errno. * Returns either zero, or negative errno.
* *
* set_lbt * set_lbt
...@@ -184,7 +169,7 @@ struct ieee802154_hw { ...@@ -184,7 +169,7 @@ struct ieee802154_hw {
* Returns either zero, or negative errno. * Returns either zero, or negative errno.
* *
* set_cca_ed_level * set_cca_ed_level
* Sets the CCA energy detection threshold in dBm. Called with pib_lock * Sets the CCA energy detection threshold in mBm. Called with pib_lock
* held. * held.
* Returns either zero, or negative errno. * Returns either zero, or negative errno.
* *
...@@ -213,12 +198,11 @@ struct ieee802154_ops { ...@@ -213,12 +198,11 @@ struct ieee802154_ops {
int (*set_hw_addr_filt)(struct ieee802154_hw *hw, int (*set_hw_addr_filt)(struct ieee802154_hw *hw,
struct ieee802154_hw_addr_filt *filt, struct ieee802154_hw_addr_filt *filt,
unsigned long changed); unsigned long changed);
int (*set_txpower)(struct ieee802154_hw *hw, s8 dbm); int (*set_txpower)(struct ieee802154_hw *hw, s32 mbm);
int (*set_lbt)(struct ieee802154_hw *hw, bool on); int (*set_lbt)(struct ieee802154_hw *hw, bool on);
int (*set_cca_mode)(struct ieee802154_hw *hw, int (*set_cca_mode)(struct ieee802154_hw *hw,
const struct wpan_phy_cca *cca); const struct wpan_phy_cca *cca);
int (*set_cca_ed_level)(struct ieee802154_hw *hw, int (*set_cca_ed_level)(struct ieee802154_hw *hw, s32 mbm);
s32 level);
int (*set_csma_params)(struct ieee802154_hw *hw, int (*set_csma_params)(struct ieee802154_hw *hw,
u8 min_be, u8 max_be, u8 retries); u8 min_be, u8 max_be, u8 retries);
int (*set_frame_retries)(struct ieee802154_hw *hw, int (*set_frame_retries)(struct ieee802154_hw *hw,
......
...@@ -100,6 +100,8 @@ enum nl802154_attrs { ...@@ -100,6 +100,8 @@ enum nl802154_attrs {
NL802154_ATTR_EXTENDED_ADDR, NL802154_ATTR_EXTENDED_ADDR,
NL802154_ATTR_WPAN_PHY_CAPS,
/* add attributes here, update the policy in nl802154.c */ /* add attributes here, update the policy in nl802154.c */
__NL802154_ATTR_AFTER_LAST, __NL802154_ATTR_AFTER_LAST,
...@@ -119,6 +121,61 @@ enum nl802154_iftype { ...@@ -119,6 +121,61 @@ enum nl802154_iftype {
NL802154_IFTYPE_MAX = NUM_NL802154_IFTYPES - 1 NL802154_IFTYPE_MAX = NUM_NL802154_IFTYPES - 1
}; };
/**
* enum nl802154_wpan_phy_capability_attr - wpan phy capability attributes
*
* @__NL802154_CAP_ATTR_INVALID: attribute number 0 is reserved
* @NL802154_CAP_ATTR_CHANNELS: a nested attribute for nl802154_channel_attr
* @NL802154_CAP_ATTR_TX_POWERS: a nested attribute for
* nl802154_wpan_phy_tx_power
* @NL802154_CAP_ATTR_MIN_CCA_ED_LEVEL: minimum value for cca_ed_level
* @NL802154_CAP_ATTR_MAX_CCA_ED_LEVEL: maxmimum value for cca_ed_level
* @NL802154_CAP_ATTR_CCA_MODES: nl802154_cca_modes flags
* @NL802154_CAP_ATTR_CCA_OPTS: nl802154_cca_opts flags
* @NL802154_CAP_ATTR_MIN_MINBE: minimum of minbe value
* @NL802154_CAP_ATTR_MAX_MINBE: maximum of minbe value
* @NL802154_CAP_ATTR_MIN_MAXBE: minimum of maxbe value
* @NL802154_CAP_ATTR_MAX_MINBE: maximum of maxbe value
* @NL802154_CAP_ATTR_MIN_CSMA_BACKOFFS: minimum of csma backoff value
* @NL802154_CAP_ATTR_MAX_CSMA_BACKOFFS: maximum of csma backoffs value
* @NL802154_CAP_ATTR_MIN_FRAME_RETRIES: minimum of frame retries value
* @NL802154_CAP_ATTR_MAX_FRAME_RETRIES: maximum of frame retries value
* @NL802154_CAP_ATTR_IFTYPES: nl802154_iftype flags
* @NL802154_CAP_ATTR_LBT: nl802154_supported_bool_states flags
* @NL802154_CAP_ATTR_MAX: highest cap attribute currently defined
* @__NL802154_CAP_ATTR_AFTER_LAST: internal use
*/
enum nl802154_wpan_phy_capability_attr {
__NL802154_CAP_ATTR_INVALID,
NL802154_CAP_ATTR_IFTYPES,
NL802154_CAP_ATTR_CHANNELS,
NL802154_CAP_ATTR_TX_POWERS,
NL802154_CAP_ATTR_CCA_ED_LEVELS,
NL802154_CAP_ATTR_CCA_MODES,
NL802154_CAP_ATTR_CCA_OPTS,
NL802154_CAP_ATTR_MIN_MINBE,
NL802154_CAP_ATTR_MAX_MINBE,
NL802154_CAP_ATTR_MIN_MAXBE,
NL802154_CAP_ATTR_MAX_MAXBE,
NL802154_CAP_ATTR_MIN_CSMA_BACKOFFS,
NL802154_CAP_ATTR_MAX_CSMA_BACKOFFS,
NL802154_CAP_ATTR_MIN_FRAME_RETRIES,
NL802154_CAP_ATTR_MAX_FRAME_RETRIES,
NL802154_CAP_ATTR_LBT,
/* keep last */
__NL802154_CAP_ATTR_AFTER_LAST,
NL802154_CAP_ATTR_MAX = __NL802154_CAP_ATTR_AFTER_LAST - 1
};
/** /**
* enum nl802154_cca_modes - cca modes * enum nl802154_cca_modes - cca modes
* *
...@@ -162,4 +219,26 @@ enum nl802154_cca_opts { ...@@ -162,4 +219,26 @@ enum nl802154_cca_opts {
NL802154_CCA_OPT_ATTR_MAX = __NL802154_CCA_OPT_ATTR_AFTER_LAST - 1 NL802154_CCA_OPT_ATTR_MAX = __NL802154_CCA_OPT_ATTR_AFTER_LAST - 1
}; };
/**
* enum nl802154_supported_bool_states - bool states for bool capability entry
*
* @NL802154_SUPPORTED_BOOL_FALSE: indicates to set false
* @NL802154_SUPPORTED_BOOL_TRUE: indicates to set true
* @__NL802154_SUPPORTED_BOOL_INVALD: reserved
* @NL802154_SUPPORTED_BOOL_BOTH: indicates to set true and false
* @__NL802154_SUPPORTED_BOOL_AFTER_LAST: Internal
* @NL802154_SUPPORTED_BOOL_MAX: highest value for bool states
*/
enum nl802154_supported_bool_states {
NL802154_SUPPORTED_BOOL_FALSE,
NL802154_SUPPORTED_BOOL_TRUE,
/* to handle them in a mask */
__NL802154_SUPPORTED_BOOL_INVALD,
NL802154_SUPPORTED_BOOL_BOTH,
/* keep last */
__NL802154_SUPPORTED_BOOL_AFTER_LAST,
NL802154_SUPPORTED_BOOL_MAX = __NL802154_SUPPORTED_BOOL_AFTER_LAST - 1
};
#endif /* __NL802154_H */ #endif /* __NL802154_H */
...@@ -94,7 +94,6 @@ static ssize_t dut_mode_write(struct file *file, const char __user *user_buf, ...@@ -94,7 +94,6 @@ static ssize_t dut_mode_write(struct file *file, const char __user *user_buf,
char buf[32]; char buf[32];
size_t buf_size = min(count, (sizeof(buf)-1)); size_t buf_size = min(count, (sizeof(buf)-1));
bool enable; bool enable;
int err;
if (!test_bit(HCI_UP, &hdev->flags)) if (!test_bit(HCI_UP, &hdev->flags))
return -ENETDOWN; return -ENETDOWN;
...@@ -121,12 +120,8 @@ static ssize_t dut_mode_write(struct file *file, const char __user *user_buf, ...@@ -121,12 +120,8 @@ static ssize_t dut_mode_write(struct file *file, const char __user *user_buf,
if (IS_ERR(skb)) if (IS_ERR(skb))
return PTR_ERR(skb); return PTR_ERR(skb);
err = -bt_to_errno(skb->data[0]);
kfree_skb(skb); kfree_skb(skb);
if (err < 0)
return err;
hci_dev_change_flag(hdev, HCI_DUT_MODE); hci_dev_change_flag(hdev, HCI_DUT_MODE);
return count; return count;
......
...@@ -7577,7 +7577,7 @@ void mgmt_new_ltk(struct hci_dev *hdev, struct smp_ltk *key, bool persistent) ...@@ -7577,7 +7577,7 @@ void mgmt_new_ltk(struct hci_dev *hdev, struct smp_ltk *key, bool persistent)
memset(&ev, 0, sizeof(ev)); memset(&ev, 0, sizeof(ev));
/* Devices using resolvable or non-resolvable random addresses /* Devices using resolvable or non-resolvable random addresses
* without providing an indentity resolving key don't require * without providing an identity resolving key don't require
* to store long term keys. Their addresses will change the * to store long term keys. Their addresses will change the
* next time around. * next time around.
* *
...@@ -7617,7 +7617,7 @@ void mgmt_new_irk(struct hci_dev *hdev, struct smp_irk *irk) ...@@ -7617,7 +7617,7 @@ void mgmt_new_irk(struct hci_dev *hdev, struct smp_irk *irk)
/* For identity resolving keys from devices that are already /* For identity resolving keys from devices that are already
* using a public address or static random address, do not * using a public address or static random address, do not
* ask for storing this key. The identity resolving key really * ask for storing this key. The identity resolving key really
* is only mandatory for devices using resovlable random * is only mandatory for devices using resolvable random
* addresses. * addresses.
* *
* Storing all identity resolving keys has the downside that * Storing all identity resolving keys has the downside that
...@@ -7646,7 +7646,7 @@ void mgmt_new_csrk(struct hci_dev *hdev, struct smp_csrk *csrk, ...@@ -7646,7 +7646,7 @@ void mgmt_new_csrk(struct hci_dev *hdev, struct smp_csrk *csrk,
memset(&ev, 0, sizeof(ev)); memset(&ev, 0, sizeof(ev));
/* Devices using resolvable or non-resolvable random addresses /* Devices using resolvable or non-resolvable random addresses
* without providing an indentity resolving key don't require * without providing an identity resolving key don't require
* to store signature resolving keys. Their addresses will change * to store signature resolving keys. Their addresses will change
* the next time around. * the next time around.
* *
......
...@@ -371,6 +371,8 @@ static int smp_e(struct crypto_blkcipher *tfm, const u8 *k, u8 *r) ...@@ -371,6 +371,8 @@ static int smp_e(struct crypto_blkcipher *tfm, const u8 *k, u8 *r)
uint8_t tmp[16], data[16]; uint8_t tmp[16], data[16];
int err; int err;
SMP_DBG("k %16phN r %16phN", k, r);
if (!tfm) { if (!tfm) {
BT_ERR("tfm %p", tfm); BT_ERR("tfm %p", tfm);
return -EINVAL; return -EINVAL;
...@@ -400,6 +402,8 @@ static int smp_e(struct crypto_blkcipher *tfm, const u8 *k, u8 *r) ...@@ -400,6 +402,8 @@ static int smp_e(struct crypto_blkcipher *tfm, const u8 *k, u8 *r)
/* Most significant octet of encryptedData corresponds to data[0] */ /* Most significant octet of encryptedData corresponds to data[0] */
swap_buf(data, r, 16); swap_buf(data, r, 16);
SMP_DBG("r %16phN", r);
return err; return err;
} }
...@@ -410,6 +414,10 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16], ...@@ -410,6 +414,10 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16],
u8 p1[16], p2[16]; u8 p1[16], p2[16];
int err; int err;
SMP_DBG("k %16phN r %16phN", k, r);
SMP_DBG("iat %u ia %6phN rat %u ra %6phN", _iat, ia, _rat, ra);
SMP_DBG("preq %7phN pres %7phN", preq, pres);
memset(p1, 0, 16); memset(p1, 0, 16);
/* p1 = pres || preq || _rat || _iat */ /* p1 = pres || preq || _rat || _iat */
...@@ -418,10 +426,7 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16], ...@@ -418,10 +426,7 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16],
memcpy(p1 + 2, preq, 7); memcpy(p1 + 2, preq, 7);
memcpy(p1 + 9, pres, 7); memcpy(p1 + 9, pres, 7);
/* p2 = padding || ia || ra */ SMP_DBG("p1 %16phN", p1);
memcpy(p2, ra, 6);
memcpy(p2 + 6, ia, 6);
memset(p2 + 12, 0, 4);
/* res = r XOR p1 */ /* res = r XOR p1 */
u128_xor((u128 *) res, (u128 *) r, (u128 *) p1); u128_xor((u128 *) res, (u128 *) r, (u128 *) p1);
...@@ -433,6 +438,13 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16], ...@@ -433,6 +438,13 @@ static int smp_c1(struct crypto_blkcipher *tfm_aes, const u8 k[16],
return err; return err;
} }
/* p2 = padding || ia || ra */
memcpy(p2, ra, 6);
memcpy(p2 + 6, ia, 6);
memset(p2 + 12, 0, 4);
SMP_DBG("p2 %16phN", p2);
/* res = res XOR p2 */ /* res = res XOR p2 */
u128_xor((u128 *) res, (u128 *) res, (u128 *) p2); u128_xor((u128 *) res, (u128 *) res, (u128 *) p2);
......
...@@ -55,27 +55,6 @@ ...@@ -55,27 +55,6 @@
LIST_HEAD(lowpan_devices); LIST_HEAD(lowpan_devices);
static int lowpan_open_count; static int lowpan_open_count;
static __le16 lowpan_get_pan_id(const struct net_device *dev)
{
struct net_device *real_dev = lowpan_dev_info(dev)->real_dev;
return ieee802154_mlme_ops(real_dev)->get_pan_id(real_dev);
}
static __le16 lowpan_get_short_addr(const struct net_device *dev)
{
struct net_device *real_dev = lowpan_dev_info(dev)->real_dev;
return ieee802154_mlme_ops(real_dev)->get_short_addr(real_dev);
}
static u8 lowpan_get_dsn(const struct net_device *dev)
{
struct net_device *real_dev = lowpan_dev_info(dev)->real_dev;
return ieee802154_mlme_ops(real_dev)->get_dsn(real_dev);
}
static struct header_ops lowpan_header_ops = { static struct header_ops lowpan_header_ops = {
.create = lowpan_header_create, .create = lowpan_header_create,
}; };
...@@ -103,12 +82,6 @@ static const struct net_device_ops lowpan_netdev_ops = { ...@@ -103,12 +82,6 @@ static const struct net_device_ops lowpan_netdev_ops = {
.ndo_start_xmit = lowpan_xmit, .ndo_start_xmit = lowpan_xmit,
}; };
static struct ieee802154_mlme_ops lowpan_mlme = {
.get_pan_id = lowpan_get_pan_id,
.get_short_addr = lowpan_get_short_addr,
.get_dsn = lowpan_get_dsn,
};
static void lowpan_setup(struct net_device *dev) static void lowpan_setup(struct net_device *dev)
{ {
dev->addr_len = IEEE802154_ADDR_LEN; dev->addr_len = IEEE802154_ADDR_LEN;
...@@ -124,7 +97,6 @@ static void lowpan_setup(struct net_device *dev) ...@@ -124,7 +97,6 @@ static void lowpan_setup(struct net_device *dev)
dev->netdev_ops = &lowpan_netdev_ops; dev->netdev_ops = &lowpan_netdev_ops;
dev->header_ops = &lowpan_header_ops; dev->header_ops = &lowpan_header_ops;
dev->ml_priv = &lowpan_mlme;
dev->destructor = free_netdev; dev->destructor = free_netdev;
dev->features |= NETIF_F_NETNS_LOCAL; dev->features |= NETIF_F_NETNS_LOCAL;
} }
......
...@@ -207,7 +207,7 @@ static int lowpan_header(struct sk_buff *skb, struct net_device *dev) ...@@ -207,7 +207,7 @@ static int lowpan_header(struct sk_buff *skb, struct net_device *dev)
/* prepare wpan address data */ /* prepare wpan address data */
sa.mode = IEEE802154_ADDR_LONG; sa.mode = IEEE802154_ADDR_LONG;
sa.pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev); sa.pan_id = lowpan_dev_info(dev)->real_dev->ieee802154_ptr->pan_id;
sa.extended_addr = ieee802154_devaddr_from_raw(saddr); sa.extended_addr = ieee802154_devaddr_from_raw(saddr);
/* intra-PAN communications */ /* intra-PAN communications */
......
...@@ -121,8 +121,6 @@ wpan_phy_new(const struct cfg802154_ops *ops, size_t priv_size) ...@@ -121,8 +121,6 @@ wpan_phy_new(const struct cfg802154_ops *ops, size_t priv_size)
/* atomic_inc_return makes it start at 1, make it start at 0 */ /* atomic_inc_return makes it start at 1, make it start at 0 */
rdev->wpan_phy_idx--; rdev->wpan_phy_idx--;
mutex_init(&rdev->wpan_phy.pib_lock);
INIT_LIST_HEAD(&rdev->wpan_dev_list); INIT_LIST_HEAD(&rdev->wpan_dev_list);
device_initialize(&rdev->wpan_phy.dev); device_initialize(&rdev->wpan_phy.dev);
dev_set_name(&rdev->wpan_phy.dev, PHY_NAME "%d", rdev->wpan_phy_idx); dev_set_name(&rdev->wpan_phy.dev, PHY_NAME "%d", rdev->wpan_phy_idx);
......
...@@ -97,8 +97,10 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid, ...@@ -97,8 +97,10 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
BUG_ON(!phy); BUG_ON(!phy);
get_device(&phy->dev); get_device(&phy->dev);
short_addr = ops->get_short_addr(dev); rtnl_lock();
pan_id = ops->get_pan_id(dev); short_addr = dev->ieee802154_ptr->short_addr;
pan_id = dev->ieee802154_ptr->pan_id;
rtnl_unlock();
if (nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name) || if (nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name) ||
nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) || nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) ||
...@@ -117,12 +119,12 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid, ...@@ -117,12 +119,12 @@ static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
rtnl_unlock(); rtnl_unlock();
if (nla_put_s8(msg, IEEE802154_ATTR_TXPOWER, if (nla_put_s8(msg, IEEE802154_ATTR_TXPOWER,
params.transmit_power) || params.transmit_power / 100) ||
nla_put_u8(msg, IEEE802154_ATTR_LBT_ENABLED, params.lbt) || nla_put_u8(msg, IEEE802154_ATTR_LBT_ENABLED, params.lbt) ||
nla_put_u8(msg, IEEE802154_ATTR_CCA_MODE, nla_put_u8(msg, IEEE802154_ATTR_CCA_MODE,
params.cca.mode) || params.cca.mode) ||
nla_put_s32(msg, IEEE802154_ATTR_CCA_ED_LEVEL, nla_put_s32(msg, IEEE802154_ATTR_CCA_ED_LEVEL,
params.cca_ed_level) || params.cca_ed_level / 100) ||
nla_put_u8(msg, IEEE802154_ATTR_CSMA_RETRIES, nla_put_u8(msg, IEEE802154_ATTR_CSMA_RETRIES,
params.csma_retries) || params.csma_retries) ||
nla_put_u8(msg, IEEE802154_ATTR_CSMA_MIN_BE, nla_put_u8(msg, IEEE802154_ATTR_CSMA_MIN_BE,
...@@ -166,10 +168,7 @@ static struct net_device *ieee802154_nl_get_dev(struct genl_info *info) ...@@ -166,10 +168,7 @@ static struct net_device *ieee802154_nl_get_dev(struct genl_info *info)
if (!dev) if (!dev)
return NULL; return NULL;
/* Check on mtu is currently a hacked solution because lowpan if (dev->type != ARPHRD_IEEE802154) {
* and wpan have the same ARPHRD type.
*/
if (dev->type != ARPHRD_IEEE802154 || dev->mtu != IEEE802154_MTU) {
dev_put(dev); dev_put(dev);
return NULL; return NULL;
} }
...@@ -244,7 +243,9 @@ int ieee802154_associate_resp(struct sk_buff *skb, struct genl_info *info) ...@@ -244,7 +243,9 @@ int ieee802154_associate_resp(struct sk_buff *skb, struct genl_info *info)
addr.mode = IEEE802154_ADDR_LONG; addr.mode = IEEE802154_ADDR_LONG;
addr.extended_addr = nla_get_hwaddr( addr.extended_addr = nla_get_hwaddr(
info->attrs[IEEE802154_ATTR_DEST_HW_ADDR]); info->attrs[IEEE802154_ATTR_DEST_HW_ADDR]);
addr.pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev); rtnl_lock();
addr.pan_id = dev->ieee802154_ptr->pan_id;
rtnl_unlock();
ret = ieee802154_mlme_ops(dev)->assoc_resp(dev, &addr, ret = ieee802154_mlme_ops(dev)->assoc_resp(dev, &addr,
nla_get_shortaddr(info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]), nla_get_shortaddr(info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]),
...@@ -281,7 +282,9 @@ int ieee802154_disassociate_req(struct sk_buff *skb, struct genl_info *info) ...@@ -281,7 +282,9 @@ int ieee802154_disassociate_req(struct sk_buff *skb, struct genl_info *info)
addr.short_addr = nla_get_shortaddr( addr.short_addr = nla_get_shortaddr(
info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]); info->attrs[IEEE802154_ATTR_DEST_SHORT_ADDR]);
} }
addr.pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev); rtnl_lock();
addr.pan_id = dev->ieee802154_ptr->pan_id;
rtnl_unlock();
ret = ieee802154_mlme_ops(dev)->disassoc_req(dev, &addr, ret = ieee802154_mlme_ops(dev)->disassoc_req(dev, &addr,
nla_get_u8(info->attrs[IEEE802154_ATTR_REASON])); nla_get_u8(info->attrs[IEEE802154_ATTR_REASON]));
...@@ -449,11 +452,7 @@ int ieee802154_dump_iface(struct sk_buff *skb, struct netlink_callback *cb) ...@@ -449,11 +452,7 @@ int ieee802154_dump_iface(struct sk_buff *skb, struct netlink_callback *cb)
idx = 0; idx = 0;
for_each_netdev(net, dev) { for_each_netdev(net, dev) {
/* Check on mtu is currently a hacked solution because lowpan if (idx < s_idx || dev->type != ARPHRD_IEEE802154)
* and wpan have the same ARPHRD type.
*/
if (idx < s_idx || dev->type != ARPHRD_IEEE802154 ||
dev->mtu != IEEE802154_MTU)
goto cont; goto cont;
if (ieee802154_nl_fill_iface(skb, NETLINK_CB(cb->skb).portid, if (ieee802154_nl_fill_iface(skb, NETLINK_CB(cb->skb).portid,
...@@ -510,7 +509,7 @@ int ieee802154_set_macparams(struct sk_buff *skb, struct genl_info *info) ...@@ -510,7 +509,7 @@ int ieee802154_set_macparams(struct sk_buff *skb, struct genl_info *info)
ops->get_mac_params(dev, &params); ops->get_mac_params(dev, &params);
if (info->attrs[IEEE802154_ATTR_TXPOWER]) if (info->attrs[IEEE802154_ATTR_TXPOWER])
params.transmit_power = nla_get_s8(info->attrs[IEEE802154_ATTR_TXPOWER]); params.transmit_power = nla_get_s8(info->attrs[IEEE802154_ATTR_TXPOWER]) * 100;
if (info->attrs[IEEE802154_ATTR_LBT_ENABLED]) if (info->attrs[IEEE802154_ATTR_LBT_ENABLED])
params.lbt = nla_get_u8(info->attrs[IEEE802154_ATTR_LBT_ENABLED]); params.lbt = nla_get_u8(info->attrs[IEEE802154_ATTR_LBT_ENABLED]);
...@@ -519,7 +518,7 @@ int ieee802154_set_macparams(struct sk_buff *skb, struct genl_info *info) ...@@ -519,7 +518,7 @@ int ieee802154_set_macparams(struct sk_buff *skb, struct genl_info *info)
params.cca.mode = nla_get_u8(info->attrs[IEEE802154_ATTR_CCA_MODE]); params.cca.mode = nla_get_u8(info->attrs[IEEE802154_ATTR_CCA_MODE]);
if (info->attrs[IEEE802154_ATTR_CCA_ED_LEVEL]) if (info->attrs[IEEE802154_ATTR_CCA_ED_LEVEL])
params.cca_ed_level = nla_get_s32(info->attrs[IEEE802154_ATTR_CCA_ED_LEVEL]); params.cca_ed_level = nla_get_s32(info->attrs[IEEE802154_ATTR_CCA_ED_LEVEL]) * 100;
if (info->attrs[IEEE802154_ATTR_CSMA_RETRIES]) if (info->attrs[IEEE802154_ATTR_CSMA_RETRIES])
params.csma_retries = nla_get_u8(info->attrs[IEEE802154_ATTR_CSMA_RETRIES]); params.csma_retries = nla_get_u8(info->attrs[IEEE802154_ATTR_CSMA_RETRIES]);
...@@ -783,11 +782,7 @@ ieee802154_llsec_dump_table(struct sk_buff *skb, struct netlink_callback *cb, ...@@ -783,11 +782,7 @@ ieee802154_llsec_dump_table(struct sk_buff *skb, struct netlink_callback *cb,
int rc; int rc;
for_each_netdev(net, dev) { for_each_netdev(net, dev) {
/* Check on mtu is currently a hacked solution because lowpan if (idx < first_dev || dev->type != ARPHRD_IEEE802154)
* and wpan have the same ARPHRD type.
*/
if (idx < first_dev || dev->type != ARPHRD_IEEE802154 ||
dev->mtu != IEEE802154_MTU)
goto skip; goto skip;
data.ops = ieee802154_mlme_ops(dev); data.ops = ieee802154_mlme_ops(dev);
......
...@@ -50,26 +50,26 @@ static int ieee802154_nl_fill_phy(struct sk_buff *msg, u32 portid, ...@@ -50,26 +50,26 @@ static int ieee802154_nl_fill_phy(struct sk_buff *msg, u32 portid,
if (!hdr) if (!hdr)
goto out; goto out;
mutex_lock(&phy->pib_lock); rtnl_lock();
if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) || if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) ||
nla_put_u8(msg, IEEE802154_ATTR_PAGE, phy->current_page) || nla_put_u8(msg, IEEE802154_ATTR_PAGE, phy->current_page) ||
nla_put_u8(msg, IEEE802154_ATTR_CHANNEL, phy->current_channel)) nla_put_u8(msg, IEEE802154_ATTR_CHANNEL, phy->current_channel))
goto nla_put_failure; goto nla_put_failure;
for (i = 0; i < 32; i++) { for (i = 0; i < 32; i++) {
if (phy->channels_supported[i]) if (phy->supported.channels[i])
buf[pages++] = phy->channels_supported[i] | (i << 27); buf[pages++] = phy->supported.channels[i] | (i << 27);
} }
if (pages && if (pages &&
nla_put(msg, IEEE802154_ATTR_CHANNEL_PAGE_LIST, nla_put(msg, IEEE802154_ATTR_CHANNEL_PAGE_LIST,
pages * sizeof(uint32_t), buf)) pages * sizeof(uint32_t), buf))
goto nla_put_failure; goto nla_put_failure;
mutex_unlock(&phy->pib_lock); rtnl_unlock();
kfree(buf); kfree(buf);
genlmsg_end(msg, hdr); genlmsg_end(msg, hdr);
return 0; return 0;
nla_put_failure: nla_put_failure:
mutex_unlock(&phy->pib_lock); rtnl_unlock();
genlmsg_cancel(msg, hdr); genlmsg_cancel(msg, hdr);
out: out:
kfree(buf); kfree(buf);
......
This diff is collapsed.
...@@ -74,6 +74,29 @@ rdev_set_cca_mode(struct cfg802154_registered_device *rdev, ...@@ -74,6 +74,29 @@ rdev_set_cca_mode(struct cfg802154_registered_device *rdev,
return ret; return ret;
} }
static inline int
rdev_set_cca_ed_level(struct cfg802154_registered_device *rdev, s32 ed_level)
{
int ret;
trace_802154_rdev_set_cca_ed_level(&rdev->wpan_phy, ed_level);
ret = rdev->ops->set_cca_ed_level(&rdev->wpan_phy, ed_level);
trace_802154_rdev_return_int(&rdev->wpan_phy, ret);
return ret;
}
static inline int
rdev_set_tx_power(struct cfg802154_registered_device *rdev,
s32 power)
{
int ret;
trace_802154_rdev_set_tx_power(&rdev->wpan_phy, power);
ret = rdev->ops->set_tx_power(&rdev->wpan_phy, power);
trace_802154_rdev_return_int(&rdev->wpan_phy, ret);
return ret;
}
static inline int static inline int
rdev_set_pan_id(struct cfg802154_registered_device *rdev, rdev_set_pan_id(struct cfg802154_registered_device *rdev,
struct wpan_dev *wpan_dev, __le16 pan_id) struct wpan_dev *wpan_dev, __le16 pan_id)
......
...@@ -64,10 +64,8 @@ ieee802154_get_dev(struct net *net, const struct ieee802154_addr *addr) ...@@ -64,10 +64,8 @@ ieee802154_get_dev(struct net *net, const struct ieee802154_addr *addr)
if (tmp->type != ARPHRD_IEEE802154) if (tmp->type != ARPHRD_IEEE802154)
continue; continue;
pan_id = ieee802154_mlme_ops(tmp)->get_pan_id(tmp); pan_id = tmp->ieee802154_ptr->pan_id;
short_addr = short_addr = tmp->ieee802154_ptr->short_addr;
ieee802154_mlme_ops(tmp)->get_short_addr(tmp);
if (pan_id == addr->pan_id && if (pan_id == addr->pan_id &&
short_addr == addr->short_addr) { short_addr == addr->short_addr) {
dev = tmp; dev = tmp;
...@@ -228,15 +226,9 @@ static int raw_bind(struct sock *sk, struct sockaddr *_uaddr, int len) ...@@ -228,15 +226,9 @@ static int raw_bind(struct sock *sk, struct sockaddr *_uaddr, int len)
goto out; goto out;
} }
if (dev->type != ARPHRD_IEEE802154) {
err = -ENODEV;
goto out_put;
}
sk->sk_bound_dev_if = dev->ifindex; sk->sk_bound_dev_if = dev->ifindex;
sk_dst_reset(sk); sk_dst_reset(sk);
out_put:
dev_put(dev); dev_put(dev);
out: out:
release_sock(sk); release_sock(sk);
...@@ -286,7 +278,7 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) ...@@ -286,7 +278,7 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
if (size > mtu) { if (size > mtu) {
pr_debug("size = %Zu, mtu = %u\n", size, mtu); pr_debug("size = %Zu, mtu = %u\n", size, mtu);
err = -EINVAL; err = -EMSGSIZE;
goto out_dev; goto out_dev;
} }
...@@ -797,9 +789,9 @@ static int ieee802154_dgram_deliver(struct net_device *dev, struct sk_buff *skb) ...@@ -797,9 +789,9 @@ static int ieee802154_dgram_deliver(struct net_device *dev, struct sk_buff *skb)
/* Data frame processing */ /* Data frame processing */
BUG_ON(dev->type != ARPHRD_IEEE802154); BUG_ON(dev->type != ARPHRD_IEEE802154);
pan_id = ieee802154_mlme_ops(dev)->get_pan_id(dev); pan_id = dev->ieee802154_ptr->pan_id;
short_addr = ieee802154_mlme_ops(dev)->get_short_addr(dev); short_addr = dev->ieee802154_ptr->short_addr;
hw_addr = ieee802154_devaddr_from_raw(dev->dev_addr); hw_addr = dev->ieee802154_ptr->extended_addr;
read_lock(&dgram_lock); read_lock(&dgram_lock);
sk_for_each(sk, &dgram_head) { sk_for_each(sk, &dgram_head) {
......
/* Based on net/wireless/tracing.h */ /* Based on net/wireless/trace.h */
#undef TRACE_SYSTEM #undef TRACE_SYSTEM
#define TRACE_SYSTEM cfg802154 #define TRACE_SYSTEM cfg802154
...@@ -93,6 +93,21 @@ TRACE_EVENT(802154_rdev_set_channel, ...@@ -93,6 +93,21 @@ TRACE_EVENT(802154_rdev_set_channel,
__entry->page, __entry->channel) __entry->page, __entry->channel)
); );
TRACE_EVENT(802154_rdev_set_tx_power,
TP_PROTO(struct wpan_phy *wpan_phy, s32 power),
TP_ARGS(wpan_phy, power),
TP_STRUCT__entry(
WPAN_PHY_ENTRY
__field(s32, power)
),
TP_fast_assign(
WPAN_PHY_ASSIGN;
__entry->power = power;
),
TP_printk(WPAN_PHY_PR_FMT ", power: %d", WPAN_PHY_PR_ARG,
__entry->power)
);
TRACE_EVENT(802154_rdev_set_cca_mode, TRACE_EVENT(802154_rdev_set_cca_mode,
TP_PROTO(struct wpan_phy *wpan_phy, const struct wpan_phy_cca *cca), TP_PROTO(struct wpan_phy *wpan_phy, const struct wpan_phy_cca *cca),
TP_ARGS(wpan_phy, cca), TP_ARGS(wpan_phy, cca),
...@@ -108,6 +123,21 @@ TRACE_EVENT(802154_rdev_set_cca_mode, ...@@ -108,6 +123,21 @@ TRACE_EVENT(802154_rdev_set_cca_mode,
WPAN_CCA_PR_ARG) WPAN_CCA_PR_ARG)
); );
TRACE_EVENT(802154_rdev_set_cca_ed_level,
TP_PROTO(struct wpan_phy *wpan_phy, s32 ed_level),
TP_ARGS(wpan_phy, ed_level),
TP_STRUCT__entry(
WPAN_PHY_ENTRY
__field(s32, ed_level)
),
TP_fast_assign(
WPAN_PHY_ASSIGN;
__entry->ed_level = ed_level;
),
TP_printk(WPAN_PHY_PR_FMT ", ed_level: %d", WPAN_PHY_PR_ARG,
__entry->ed_level)
);
DECLARE_EVENT_CLASS(802154_le16_template, DECLARE_EVENT_CLASS(802154_le16_template,
TP_PROTO(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev, TP_PROTO(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
__le16 le16arg), __le16 le16arg),
......
...@@ -2,6 +2,7 @@ config MAC802154 ...@@ -2,6 +2,7 @@ config MAC802154
tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)" tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)"
depends on IEEE802154 depends on IEEE802154
select CRC_CCITT select CRC_CCITT
select CRYPTO
select CRYPTO_AUTHENC select CRYPTO_AUTHENC
select CRYPTO_CCM select CRYPTO_CCM
select CRYPTO_CTR select CRYPTO_CTR
......
...@@ -73,9 +73,9 @@ ieee802154_set_channel(struct wpan_phy *wpan_phy, u8 page, u8 channel) ...@@ -73,9 +73,9 @@ ieee802154_set_channel(struct wpan_phy *wpan_phy, u8 page, u8 channel)
ASSERT_RTNL(); ASSERT_RTNL();
/* check if phy support this setting */ if (wpan_phy->current_page == page &&
if (!(wpan_phy->channels_supported[page] & BIT(channel))) wpan_phy->current_channel == channel)
return -EINVAL; return 0;
ret = drv_set_channel(local, page, channel); ret = drv_set_channel(local, page, channel);
if (!ret) { if (!ret) {
...@@ -95,9 +95,8 @@ ieee802154_set_cca_mode(struct wpan_phy *wpan_phy, ...@@ -95,9 +95,8 @@ ieee802154_set_cca_mode(struct wpan_phy *wpan_phy,
ASSERT_RTNL(); ASSERT_RTNL();
/* check if phy support this setting */ if (wpan_phy_cca_cmp(&wpan_phy->cca, cca))
if (!(local->hw.flags & IEEE802154_HW_CCA_MODE)) return 0;
return -EOPNOTSUPP;
ret = drv_set_cca_mode(local, cca); ret = drv_set_cca_mode(local, cca);
if (!ret) if (!ret)
...@@ -106,21 +105,50 @@ ieee802154_set_cca_mode(struct wpan_phy *wpan_phy, ...@@ -106,21 +105,50 @@ ieee802154_set_cca_mode(struct wpan_phy *wpan_phy,
return ret; return ret;
} }
static int
ieee802154_set_cca_ed_level(struct wpan_phy *wpan_phy, s32 ed_level)
{
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
int ret;
ASSERT_RTNL();
if (wpan_phy->cca_ed_level == ed_level)
return 0;
ret = drv_set_cca_ed_level(local, ed_level);
if (!ret)
wpan_phy->cca_ed_level = ed_level;
return ret;
}
static int
ieee802154_set_tx_power(struct wpan_phy *wpan_phy, s32 power)
{
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
int ret;
ASSERT_RTNL();
if (wpan_phy->transmit_power == power)
return 0;
ret = drv_set_tx_power(local, power);
if (!ret)
wpan_phy->transmit_power = power;
return ret;
}
static int static int
ieee802154_set_pan_id(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev, ieee802154_set_pan_id(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
__le16 pan_id) __le16 pan_id)
{ {
ASSERT_RTNL(); ASSERT_RTNL();
/* TODO if (wpan_dev->pan_id == pan_id)
* I am not sure about to check here on broadcast pan_id. return 0;
* Broadcast is a valid setting, comment from 802.15.4:
* If this value is 0xffff, the device is not associated.
*
* This could useful to simple deassociate an device.
*/
if (pan_id == cpu_to_le16(IEEE802154_PAN_ID_BROADCAST))
return -EINVAL;
wpan_dev->pan_id = pan_id; wpan_dev->pan_id = pan_id;
return 0; return 0;
...@@ -131,12 +159,11 @@ ieee802154_set_backoff_exponent(struct wpan_phy *wpan_phy, ...@@ -131,12 +159,11 @@ ieee802154_set_backoff_exponent(struct wpan_phy *wpan_phy,
struct wpan_dev *wpan_dev, struct wpan_dev *wpan_dev,
u8 min_be, u8 max_be) u8 min_be, u8 max_be)
{ {
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
ASSERT_RTNL(); ASSERT_RTNL();
if (!(local->hw.flags & IEEE802154_HW_CSMA_PARAMS)) if (wpan_dev->min_be == min_be &&
return -EOPNOTSUPP; wpan_dev->max_be == max_be)
return 0;
wpan_dev->min_be = min_be; wpan_dev->min_be = min_be;
wpan_dev->max_be = max_be; wpan_dev->max_be = max_be;
...@@ -149,20 +176,8 @@ ieee802154_set_short_addr(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev, ...@@ -149,20 +176,8 @@ ieee802154_set_short_addr(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
{ {
ASSERT_RTNL(); ASSERT_RTNL();
/* TODO if (wpan_dev->short_addr == short_addr)
* I am not sure about to check here on broadcast short_addr. return 0;
* Broadcast is a valid setting, comment from 802.15.4:
* A value of 0xfffe indicates that the device has
* associated but has not been allocated an address. A
* value of 0xffff indicates that the device does not
* have a short address.
*
* I think we should allow to set these settings but
* don't allow to allow socket communication with it.
*/
if (short_addr == cpu_to_le16(IEEE802154_ADDR_SHORT_UNSPEC) ||
short_addr == cpu_to_le16(IEEE802154_ADDR_SHORT_BROADCAST))
return -EINVAL;
wpan_dev->short_addr = short_addr; wpan_dev->short_addr = short_addr;
return 0; return 0;
...@@ -173,12 +188,10 @@ ieee802154_set_max_csma_backoffs(struct wpan_phy *wpan_phy, ...@@ -173,12 +188,10 @@ ieee802154_set_max_csma_backoffs(struct wpan_phy *wpan_phy,
struct wpan_dev *wpan_dev, struct wpan_dev *wpan_dev,
u8 max_csma_backoffs) u8 max_csma_backoffs)
{ {
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
ASSERT_RTNL(); ASSERT_RTNL();
if (!(local->hw.flags & IEEE802154_HW_CSMA_PARAMS)) if (wpan_dev->csma_retries == max_csma_backoffs)
return -EOPNOTSUPP; return 0;
wpan_dev->csma_retries = max_csma_backoffs; wpan_dev->csma_retries = max_csma_backoffs;
return 0; return 0;
...@@ -189,12 +202,10 @@ ieee802154_set_max_frame_retries(struct wpan_phy *wpan_phy, ...@@ -189,12 +202,10 @@ ieee802154_set_max_frame_retries(struct wpan_phy *wpan_phy,
struct wpan_dev *wpan_dev, struct wpan_dev *wpan_dev,
s8 max_frame_retries) s8 max_frame_retries)
{ {
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
ASSERT_RTNL(); ASSERT_RTNL();
if (!(local->hw.flags & IEEE802154_HW_FRAME_RETRIES)) if (wpan_dev->frame_retries == max_frame_retries)
return -EOPNOTSUPP; return 0;
wpan_dev->frame_retries = max_frame_retries; wpan_dev->frame_retries = max_frame_retries;
return 0; return 0;
...@@ -204,12 +215,10 @@ static int ...@@ -204,12 +215,10 @@ static int
ieee802154_set_lbt_mode(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev, ieee802154_set_lbt_mode(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
bool mode) bool mode)
{ {
struct ieee802154_local *local = wpan_phy_priv(wpan_phy);
ASSERT_RTNL(); ASSERT_RTNL();
if (!(local->hw.flags & IEEE802154_HW_LBT)) if (wpan_dev->lbt == mode)
return -EOPNOTSUPP; return 0;
wpan_dev->lbt = mode; wpan_dev->lbt = mode;
return 0; return 0;
...@@ -222,6 +231,8 @@ const struct cfg802154_ops mac802154_config_ops = { ...@@ -222,6 +231,8 @@ const struct cfg802154_ops mac802154_config_ops = {
.del_virtual_intf = ieee802154_del_iface, .del_virtual_intf = ieee802154_del_iface,
.set_channel = ieee802154_set_channel, .set_channel = ieee802154_set_channel,
.set_cca_mode = ieee802154_set_cca_mode, .set_cca_mode = ieee802154_set_cca_mode,
.set_cca_ed_level = ieee802154_set_cca_ed_level,
.set_tx_power = ieee802154_set_tx_power,
.set_pan_id = ieee802154_set_pan_id, .set_pan_id = ieee802154_set_pan_id,
.set_short_addr = ieee802154_set_short_addr, .set_short_addr = ieee802154_set_short_addr,
.set_backoff_exponent = ieee802154_set_backoff_exponent, .set_backoff_exponent = ieee802154_set_backoff_exponent,
......
...@@ -58,7 +58,7 @@ drv_set_channel(struct ieee802154_local *local, u8 page, u8 channel) ...@@ -58,7 +58,7 @@ drv_set_channel(struct ieee802154_local *local, u8 page, u8 channel)
return local->ops->set_channel(&local->hw, page, channel); return local->ops->set_channel(&local->hw, page, channel);
} }
static inline int drv_set_tx_power(struct ieee802154_local *local, s8 dbm) static inline int drv_set_tx_power(struct ieee802154_local *local, s32 mbm)
{ {
might_sleep(); might_sleep();
...@@ -67,7 +67,7 @@ static inline int drv_set_tx_power(struct ieee802154_local *local, s8 dbm) ...@@ -67,7 +67,7 @@ static inline int drv_set_tx_power(struct ieee802154_local *local, s8 dbm)
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
return local->ops->set_txpower(&local->hw, dbm); return local->ops->set_txpower(&local->hw, mbm);
} }
static inline int drv_set_cca_mode(struct ieee802154_local *local, static inline int drv_set_cca_mode(struct ieee802154_local *local,
...@@ -96,7 +96,7 @@ static inline int drv_set_lbt_mode(struct ieee802154_local *local, bool mode) ...@@ -96,7 +96,7 @@ static inline int drv_set_lbt_mode(struct ieee802154_local *local, bool mode)
} }
static inline int static inline int
drv_set_cca_ed_level(struct ieee802154_local *local, s32 ed_level) drv_set_cca_ed_level(struct ieee802154_local *local, s32 mbm)
{ {
might_sleep(); might_sleep();
...@@ -105,7 +105,7 @@ drv_set_cca_ed_level(struct ieee802154_local *local, s32 ed_level) ...@@ -105,7 +105,7 @@ drv_set_cca_ed_level(struct ieee802154_local *local, s32 ed_level)
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
return local->ops->set_cca_ed_level(&local->hw, ed_level); return local->ops->set_cca_ed_level(&local->hw, mbm);
} }
static inline int drv_set_pan_id(struct ieee802154_local *local, __le16 pan_id) static inline int drv_set_pan_id(struct ieee802154_local *local, __le16 pan_id)
......
...@@ -86,8 +86,6 @@ struct ieee802154_sub_if_data { ...@@ -86,8 +86,6 @@ struct ieee802154_sub_if_data {
unsigned long state; unsigned long state;
char name[IFNAMSIZ]; char name[IFNAMSIZ];
spinlock_t mib_lock;
/* protects sec from concurrent access by netlink. access by /* protects sec from concurrent access by netlink. access by
* encrypt/decrypt/header_create safe without additional protection. * encrypt/decrypt/header_create safe without additional protection.
*/ */
...@@ -136,12 +134,7 @@ ieee802154_subif_start_xmit(struct sk_buff *skb, struct net_device *dev); ...@@ -136,12 +134,7 @@ ieee802154_subif_start_xmit(struct sk_buff *skb, struct net_device *dev);
enum hrtimer_restart ieee802154_xmit_ifs_timer(struct hrtimer *timer); enum hrtimer_restart ieee802154_xmit_ifs_timer(struct hrtimer *timer);
/* MIB callbacks */ /* MIB callbacks */
void mac802154_dev_set_short_addr(struct net_device *dev, __le16 val);
__le16 mac802154_dev_get_short_addr(const struct net_device *dev);
__le16 mac802154_dev_get_pan_id(const struct net_device *dev);
void mac802154_dev_set_pan_id(struct net_device *dev, __le16 val);
void mac802154_dev_set_page_channel(struct net_device *dev, u8 page, u8 chan); void mac802154_dev_set_page_channel(struct net_device *dev, u8 page, u8 chan);
u8 mac802154_dev_get_dsn(const struct net_device *dev);
int mac802154_get_params(struct net_device *dev, int mac802154_get_params(struct net_device *dev,
struct ieee802154_llsec_params *params); struct ieee802154_llsec_params *params);
......
...@@ -62,9 +62,10 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ...@@ -62,9 +62,10 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
(struct sockaddr_ieee802154 *)&ifr->ifr_addr; (struct sockaddr_ieee802154 *)&ifr->ifr_addr;
int err = -ENOIOCTLCMD; int err = -ENOIOCTLCMD;
ASSERT_RTNL(); if (cmd != SIOCGIFADDR && cmd != SIOCSIFADDR)
return err;
spin_lock_bh(&sdata->mib_lock); rtnl_lock();
switch (cmd) { switch (cmd) {
case SIOCGIFADDR: case SIOCGIFADDR:
...@@ -89,7 +90,7 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ...@@ -89,7 +90,7 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
} }
case SIOCSIFADDR: case SIOCSIFADDR:
if (netif_running(dev)) { if (netif_running(dev)) {
spin_unlock_bh(&sdata->mib_lock); rtnl_unlock();
return -EBUSY; return -EBUSY;
} }
...@@ -111,7 +112,7 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ...@@ -111,7 +112,7 @@ mac802154_wpan_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
break; break;
} }
spin_unlock_bh(&sdata->mib_lock); rtnl_unlock();
return err; return err;
} }
...@@ -241,7 +242,6 @@ static int mac802154_wpan_open(struct net_device *dev) ...@@ -241,7 +242,6 @@ static int mac802154_wpan_open(struct net_device *dev)
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev); struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
struct ieee802154_local *local = sdata->local; struct ieee802154_local *local = sdata->local;
struct wpan_dev *wpan_dev = &sdata->wpan_dev; struct wpan_dev *wpan_dev = &sdata->wpan_dev;
struct wpan_phy *phy = sdata->local->phy;
rc = ieee802154_check_concurrent_iface(sdata, sdata->vif.type); rc = ieee802154_check_concurrent_iface(sdata, sdata->vif.type);
if (rc < 0) if (rc < 0)
...@@ -251,8 +251,6 @@ static int mac802154_wpan_open(struct net_device *dev) ...@@ -251,8 +251,6 @@ static int mac802154_wpan_open(struct net_device *dev)
if (rc < 0) if (rc < 0)
return rc; return rc;
mutex_lock(&phy->pib_lock);
if (local->hw.flags & IEEE802154_HW_PROMISCUOUS) { if (local->hw.flags & IEEE802154_HW_PROMISCUOUS) {
rc = drv_set_promiscuous_mode(local, rc = drv_set_promiscuous_mode(local,
wpan_dev->promiscuous_mode); wpan_dev->promiscuous_mode);
...@@ -294,11 +292,7 @@ static int mac802154_wpan_open(struct net_device *dev) ...@@ -294,11 +292,7 @@ static int mac802154_wpan_open(struct net_device *dev)
goto out; goto out;
} }
mutex_unlock(&phy->pib_lock);
return 0;
out: out:
mutex_unlock(&phy->pib_lock);
return rc; return rc;
} }
...@@ -374,14 +368,12 @@ static int mac802154_header_create(struct sk_buff *skb, ...@@ -374,14 +368,12 @@ static int mac802154_header_create(struct sk_buff *skb,
hdr.fc.type = cb->type; hdr.fc.type = cb->type;
hdr.fc.security_enabled = cb->secen; hdr.fc.security_enabled = cb->secen;
hdr.fc.ack_request = cb->ackreq; hdr.fc.ack_request = cb->ackreq;
hdr.seq = ieee802154_mlme_ops(dev)->get_dsn(dev); hdr.seq = atomic_inc_return(&dev->ieee802154_ptr->dsn) & 0xFF;
if (mac802154_set_header_security(sdata, &hdr, cb) < 0) if (mac802154_set_header_security(sdata, &hdr, cb) < 0)
return -EINVAL; return -EINVAL;
if (!saddr) { if (!saddr) {
spin_lock_bh(&sdata->mib_lock);
if (wpan_dev->short_addr == cpu_to_le16(IEEE802154_ADDR_BROADCAST) || if (wpan_dev->short_addr == cpu_to_le16(IEEE802154_ADDR_BROADCAST) ||
wpan_dev->short_addr == cpu_to_le16(IEEE802154_ADDR_UNDEF) || wpan_dev->short_addr == cpu_to_le16(IEEE802154_ADDR_UNDEF) ||
wpan_dev->pan_id == cpu_to_le16(IEEE802154_PANID_BROADCAST)) { wpan_dev->pan_id == cpu_to_le16(IEEE802154_PANID_BROADCAST)) {
...@@ -393,8 +385,6 @@ static int mac802154_header_create(struct sk_buff *skb, ...@@ -393,8 +385,6 @@ static int mac802154_header_create(struct sk_buff *skb,
} }
hdr.source.pan_id = wpan_dev->pan_id; hdr.source.pan_id = wpan_dev->pan_id;
spin_unlock_bh(&sdata->mib_lock);
} else { } else {
hdr.source = *(const struct ieee802154_addr *)saddr; hdr.source = *(const struct ieee802154_addr *)saddr;
} }
...@@ -474,13 +464,16 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata, ...@@ -474,13 +464,16 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata,
enum nl802154_iftype type) enum nl802154_iftype type)
{ {
struct wpan_dev *wpan_dev = &sdata->wpan_dev; struct wpan_dev *wpan_dev = &sdata->wpan_dev;
u8 tmp;
/* set some type-dependent values */ /* set some type-dependent values */
sdata->vif.type = type; sdata->vif.type = type;
sdata->wpan_dev.iftype = type; sdata->wpan_dev.iftype = type;
get_random_bytes(&wpan_dev->bsn, 1); get_random_bytes(&tmp, sizeof(tmp));
get_random_bytes(&wpan_dev->dsn, 1); atomic_set(&wpan_dev->bsn, tmp);
get_random_bytes(&tmp, sizeof(tmp));
atomic_set(&wpan_dev->dsn, tmp);
/* defaults per 802.15.4-2011 */ /* defaults per 802.15.4-2011 */
wpan_dev->min_be = 3; wpan_dev->min_be = 3;
...@@ -503,7 +496,6 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata, ...@@ -503,7 +496,6 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata,
sdata->dev->ml_priv = &mac802154_mlme_wpan; sdata->dev->ml_priv = &mac802154_mlme_wpan;
wpan_dev->promiscuous_mode = false; wpan_dev->promiscuous_mode = false;
spin_lock_init(&sdata->mib_lock);
mutex_init(&sdata->sec_mtx); mutex_init(&sdata->sec_mtx);
mac802154_llsec_init(&sdata->sec); mac802154_llsec_init(&sdata->sec);
......
...@@ -36,37 +36,30 @@ static int mac802154_mlme_start_req(struct net_device *dev, ...@@ -36,37 +36,30 @@ static int mac802154_mlme_start_req(struct net_device *dev,
u8 pan_coord, u8 blx, u8 pan_coord, u8 blx,
u8 coord_realign) u8 coord_realign)
{ {
struct ieee802154_mlme_ops *ops = ieee802154_mlme_ops(dev); struct ieee802154_llsec_params params;
int rc = 0; int changed = 0;
ASSERT_RTNL(); ASSERT_RTNL();
BUG_ON(addr->mode != IEEE802154_ADDR_SHORT); BUG_ON(addr->mode != IEEE802154_ADDR_SHORT);
mac802154_dev_set_pan_id(dev, addr->pan_id); dev->ieee802154_ptr->pan_id = addr->pan_id;
mac802154_dev_set_short_addr(dev, addr->short_addr); dev->ieee802154_ptr->short_addr = addr->short_addr;
mac802154_dev_set_page_channel(dev, page, channel); mac802154_dev_set_page_channel(dev, page, channel);
if (ops->llsec) { params.pan_id = addr->pan_id;
struct ieee802154_llsec_params params; changed |= IEEE802154_LLSEC_PARAM_PAN_ID;
int changed = 0;
params.coord_shortaddr = addr->short_addr; params.hwaddr = ieee802154_devaddr_from_raw(dev->dev_addr);
changed |= IEEE802154_LLSEC_PARAM_COORD_SHORTADDR; changed |= IEEE802154_LLSEC_PARAM_HWADDR;
params.pan_id = addr->pan_id; params.coord_hwaddr = params.hwaddr;
changed |= IEEE802154_LLSEC_PARAM_PAN_ID; changed |= IEEE802154_LLSEC_PARAM_COORD_HWADDR;
params.hwaddr = ieee802154_devaddr_from_raw(dev->dev_addr); params.coord_shortaddr = addr->short_addr;
changed |= IEEE802154_LLSEC_PARAM_HWADDR; changed |= IEEE802154_LLSEC_PARAM_COORD_SHORTADDR;
params.coord_hwaddr = params.hwaddr; return mac802154_set_params(dev, &params, changed);
changed |= IEEE802154_LLSEC_PARAM_COORD_HWADDR;
rc = ops->llsec->set_params(dev, &params, changed);
}
return rc;
} }
static int mac802154_set_mac_params(struct net_device *dev, static int mac802154_set_mac_params(struct net_device *dev,
...@@ -91,19 +84,19 @@ static int mac802154_set_mac_params(struct net_device *dev, ...@@ -91,19 +84,19 @@ static int mac802154_set_mac_params(struct net_device *dev,
wpan_dev->frame_retries = params->frame_retries; wpan_dev->frame_retries = params->frame_retries;
wpan_dev->lbt = params->lbt; wpan_dev->lbt = params->lbt;
if (local->hw.flags & IEEE802154_HW_TXPOWER) { if (local->hw.phy->flags & WPAN_PHY_FLAG_TXPOWER) {
ret = drv_set_tx_power(local, params->transmit_power); ret = drv_set_tx_power(local, params->transmit_power);
if (ret < 0) if (ret < 0)
return ret; return ret;
} }
if (local->hw.flags & IEEE802154_HW_CCA_MODE) { if (local->hw.phy->flags & WPAN_PHY_FLAG_CCA_MODE) {
ret = drv_set_cca_mode(local, &params->cca); ret = drv_set_cca_mode(local, &params->cca);
if (ret < 0) if (ret < 0)
return ret; return ret;
} }
if (local->hw.flags & IEEE802154_HW_CCA_ED_LEVEL) { if (local->hw.phy->flags & WPAN_PHY_FLAG_CCA_ED_LEVEL) {
ret = drv_set_cca_ed_level(local, params->cca_ed_level); ret = drv_set_cca_ed_level(local, params->cca_ed_level);
if (ret < 0) if (ret < 0)
return ret; return ret;
...@@ -151,9 +144,6 @@ static struct ieee802154_llsec_ops mac802154_llsec_ops = { ...@@ -151,9 +144,6 @@ static struct ieee802154_llsec_ops mac802154_llsec_ops = {
struct ieee802154_mlme_ops mac802154_mlme_wpan = { struct ieee802154_mlme_ops mac802154_mlme_wpan = {
.start_req = mac802154_mlme_start_req, .start_req = mac802154_mlme_start_req,
.get_pan_id = mac802154_dev_get_pan_id,
.get_short_addr = mac802154_dev_get_short_addr,
.get_dsn = mac802154_dev_get_dsn,
.llsec = &mac802154_llsec_ops, .llsec = &mac802154_llsec_ops,
......
...@@ -107,6 +107,18 @@ ieee802154_alloc_hw(size_t priv_data_len, const struct ieee802154_ops *ops) ...@@ -107,6 +107,18 @@ ieee802154_alloc_hw(size_t priv_data_len, const struct ieee802154_ops *ops)
skb_queue_head_init(&local->skb_queue); skb_queue_head_init(&local->skb_queue);
/* init supported flags with 802.15.4 default ranges */
phy->supported.max_minbe = 8;
phy->supported.min_maxbe = 3;
phy->supported.max_maxbe = 8;
phy->supported.min_frame_retries = -1;
phy->supported.max_frame_retries = 7;
phy->supported.max_csma_backoffs = 5;
phy->supported.lbt = NL802154_SUPPORTED_BOOL_FALSE;
/* always supported */
phy->supported.iftypes = BIT(NL802154_IFTYPE_NODE);
return &local->hw; return &local->hw;
} }
EXPORT_SYMBOL(ieee802154_alloc_hw); EXPORT_SYMBOL(ieee802154_alloc_hw);
...@@ -155,6 +167,26 @@ int ieee802154_register_hw(struct ieee802154_hw *hw) ...@@ -155,6 +167,26 @@ int ieee802154_register_hw(struct ieee802154_hw *hw)
ieee802154_setup_wpan_phy_pib(local->phy); ieee802154_setup_wpan_phy_pib(local->phy);
if (!(hw->flags & IEEE802154_HW_CSMA_PARAMS)) {
local->phy->supported.min_csma_backoffs = 4;
local->phy->supported.max_csma_backoffs = 4;
local->phy->supported.min_maxbe = 5;
local->phy->supported.max_maxbe = 5;
local->phy->supported.min_minbe = 3;
local->phy->supported.max_minbe = 3;
}
if (!(hw->flags & IEEE802154_HW_FRAME_RETRIES)) {
/* TODO should be 3, but our default value is -1 which means
* no ARET handling.
*/
local->phy->supported.min_frame_retries = -1;
local->phy->supported.max_frame_retries = -1;
}
if (hw->flags & IEEE802154_HW_PROMISCUOUS)
local->phy->supported.iftypes |= BIT(NL802154_IFTYPE_MONITOR);
rc = wpan_phy_register(local->phy); rc = wpan_phy_register(local->phy);
if (rc < 0) if (rc < 0)
goto out_wq; goto out_wq;
......
...@@ -26,81 +26,22 @@ ...@@ -26,81 +26,22 @@
#include "ieee802154_i.h" #include "ieee802154_i.h"
#include "driver-ops.h" #include "driver-ops.h"
void mac802154_dev_set_short_addr(struct net_device *dev, __le16 val)
{
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
BUG_ON(dev->type != ARPHRD_IEEE802154);
spin_lock_bh(&sdata->mib_lock);
sdata->wpan_dev.short_addr = val;
spin_unlock_bh(&sdata->mib_lock);
}
__le16 mac802154_dev_get_short_addr(const struct net_device *dev)
{
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
__le16 ret;
BUG_ON(dev->type != ARPHRD_IEEE802154);
spin_lock_bh(&sdata->mib_lock);
ret = sdata->wpan_dev.short_addr;
spin_unlock_bh(&sdata->mib_lock);
return ret;
}
__le16 mac802154_dev_get_pan_id(const struct net_device *dev)
{
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
__le16 ret;
BUG_ON(dev->type != ARPHRD_IEEE802154);
spin_lock_bh(&sdata->mib_lock);
ret = sdata->wpan_dev.pan_id;
spin_unlock_bh(&sdata->mib_lock);
return ret;
}
void mac802154_dev_set_pan_id(struct net_device *dev, __le16 val)
{
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
BUG_ON(dev->type != ARPHRD_IEEE802154);
spin_lock_bh(&sdata->mib_lock);
sdata->wpan_dev.pan_id = val;
spin_unlock_bh(&sdata->mib_lock);
}
u8 mac802154_dev_get_dsn(const struct net_device *dev)
{
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
BUG_ON(dev->type != ARPHRD_IEEE802154);
return sdata->wpan_dev.dsn++;
}
void mac802154_dev_set_page_channel(struct net_device *dev, u8 page, u8 chan) void mac802154_dev_set_page_channel(struct net_device *dev, u8 page, u8 chan)
{ {
struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev); struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
struct ieee802154_local *local = sdata->local; struct ieee802154_local *local = sdata->local;
int res; int res;
ASSERT_RTNL();
BUG_ON(dev->type != ARPHRD_IEEE802154); BUG_ON(dev->type != ARPHRD_IEEE802154);
res = drv_set_channel(local, page, chan); res = drv_set_channel(local, page, chan);
if (res) { if (res) {
pr_debug("set_channel failed\n"); pr_debug("set_channel failed\n");
} else { } else {
mutex_lock(&local->phy->pib_lock);
local->phy->current_channel = chan; local->phy->current_channel = chan;
local->phy->current_page = page; local->phy->current_page = page;
mutex_unlock(&local->phy->pib_lock);
} }
} }
......
...@@ -47,8 +47,6 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata, ...@@ -47,8 +47,6 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata,
pr_debug("getting packet via slave interface %s\n", sdata->dev->name); pr_debug("getting packet via slave interface %s\n", sdata->dev->name);
spin_lock_bh(&sdata->mib_lock);
span = wpan_dev->pan_id; span = wpan_dev->pan_id;
sshort = wpan_dev->short_addr; sshort = wpan_dev->short_addr;
...@@ -83,13 +81,10 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata, ...@@ -83,13 +81,10 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data *sdata,
skb->pkt_type = PACKET_OTHERHOST; skb->pkt_type = PACKET_OTHERHOST;
break; break;
default: default:
spin_unlock_bh(&sdata->mib_lock);
pr_debug("invalid dest mode\n"); pr_debug("invalid dest mode\n");
goto fail; goto fail;
} }
spin_unlock_bh(&sdata->mib_lock);
skb->dev = sdata->dev; skb->dev = sdata->dev;
rc = mac802154_llsec_decrypt(&sdata->sec, skb); rc = mac802154_llsec_decrypt(&sdata->sec, skb);
......
...@@ -85,11 +85,10 @@ void ieee802154_xmit_complete(struct ieee802154_hw *hw, struct sk_buff *skb, ...@@ -85,11 +85,10 @@ void ieee802154_xmit_complete(struct ieee802154_hw *hw, struct sk_buff *skb,
hrtimer_start(&local->ifs_timer, hrtimer_start(&local->ifs_timer,
ktime_set(0, hw->phy->sifs_period * NSEC_PER_USEC), ktime_set(0, hw->phy->sifs_period * NSEC_PER_USEC),
HRTIMER_MODE_REL); HRTIMER_MODE_REL);
consume_skb(skb);
} else { } else {
ieee802154_wake_queue(hw); ieee802154_wake_queue(hw);
consume_skb(skb);
} }
dev_consume_skb_any(skb);
} }
EXPORT_SYMBOL(ieee802154_xmit_complete); EXPORT_SYMBOL(ieee802154_xmit_complete);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment