Commit 9d99c41a authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij

gpio: lp873x: Use devm_gpiochip_add_data() for gpio registration

Use devm_gpiochip_add_data() for GPIO registration and remove the need
of driver callback .remove.
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2e680239
...@@ -154,7 +154,7 @@ static int lp873x_gpio_probe(struct platform_device *pdev) ...@@ -154,7 +154,7 @@ static int lp873x_gpio_probe(struct platform_device *pdev)
gpio->chip = template_chip; gpio->chip = template_chip;
gpio->chip.parent = gpio->lp873->dev; gpio->chip.parent = gpio->lp873->dev;
ret = gpiochip_add_data(&gpio->chip, gpio); ret = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret); dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
return ret; return ret;
...@@ -163,15 +163,6 @@ static int lp873x_gpio_probe(struct platform_device *pdev) ...@@ -163,15 +163,6 @@ static int lp873x_gpio_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int lp873x_gpio_remove(struct platform_device *pdev)
{
struct lp873x_gpio *gpio = platform_get_drvdata(pdev);
gpiochip_remove(&gpio->chip);
return 0;
}
static const struct platform_device_id lp873x_gpio_id_table[] = { static const struct platform_device_id lp873x_gpio_id_table[] = {
{ "lp873x-gpio", }, { "lp873x-gpio", },
{ /* sentinel */ } { /* sentinel */ }
...@@ -183,7 +174,6 @@ static struct platform_driver lp873x_gpio_driver = { ...@@ -183,7 +174,6 @@ static struct platform_driver lp873x_gpio_driver = {
.name = "lp873x-gpio", .name = "lp873x-gpio",
}, },
.probe = lp873x_gpio_probe, .probe = lp873x_gpio_probe,
.remove = lp873x_gpio_remove,
.id_table = lp873x_gpio_id_table, .id_table = lp873x_gpio_id_table,
}; };
module_platform_driver(lp873x_gpio_driver); module_platform_driver(lp873x_gpio_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment