Commit 9e089246 authored by Olliver Schinagl's avatar Olliver Schinagl Committed by Linus Walleij

gpio: use sizeof() instead of hardcoded values

gpiolib uses a fixed string for the suffixes and defines it at 32 bytes.
Later in the code snprintf is used with this fixed value of 32. Using
sizeof() is safer in case the size for the suffixes is ever changed.
Signed-off-by: default avatarOlliver Schinagl <oliver@schinagl.nl>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 161af6cd
......@@ -1665,9 +1665,11 @@ static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
for (i = 0; i < ARRAY_SIZE(suffixes); i++) {
if (con_id)
snprintf(prop_name, 32, "%s-%s", con_id, suffixes[i]);
snprintf(prop_name, sizeof(prop_name), "%s-%s", con_id,
suffixes[i]);
else
snprintf(prop_name, 32, "%s", suffixes[i]);
snprintf(prop_name, sizeof(prop_name), "%s",
suffixes[i]);
desc = of_get_named_gpiod_flags(dev->of_node, prop_name, idx,
&of_flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment