Commit 9e2effba authored by Andy Grover's avatar Andy Grover

RDS: Fix BUG_ONs to not fire when in a tasklet

in_interrupt() is true in softirqs. The BUG_ONs are supposed
to check for if irqs are disabled, so we should use
BUG_ON(irqs_disabled()) instead, duh.
Signed-off-by: default avatarAndy Grover <andy.grover@oracle.com>
parent db40980f
...@@ -441,7 +441,7 @@ static void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr) ...@@ -441,7 +441,7 @@ static void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr)
/* FIXME we need a way to tell a r/w MR /* FIXME we need a way to tell a r/w MR
* from a r/o MR */ * from a r/o MR */
BUG_ON(in_interrupt()); BUG_ON(irqs_disabled());
set_page_dirty(page); set_page_dirty(page);
put_page(page); put_page(page);
} }
......
...@@ -440,7 +440,7 @@ void rds_rdma_free_op(struct rds_rdma_op *ro) ...@@ -440,7 +440,7 @@ void rds_rdma_free_op(struct rds_rdma_op *ro)
* is the case for a RDMA_READ which copies from remote * is the case for a RDMA_READ which copies from remote
* to local memory */ * to local memory */
if (!ro->r_write) { if (!ro->r_write) {
BUG_ON(in_interrupt()); BUG_ON(irqs_disabled());
set_page_dirty(page); set_page_dirty(page);
} }
put_page(page); put_page(page);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment