Commit 9e2fd463 authored by Wambui Karuga's avatar Wambui Karuga Committed by Daniel Vetter

drm/msm: remove checks for return value of drm_debugfs_create_files()

Since commit 987d65d0 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files never
fails and only returns 0. Therefore, the unnecessary checks for its
return value and error handling in various debugfs_init() functions in
drm/msm and have the functions return 0 directly.

v2: have debug functions return 0 instead of void to avoid build
breakage and ensure standalone compilation.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.htmlSigned-off-by: default avatarWambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-9-wambui.karugax@gmail.com
parent 14b46195
...@@ -151,21 +151,15 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n"); ...@@ -151,21 +151,15 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n");
int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor) int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
{ {
struct drm_device *dev; struct drm_device *dev;
int ret;
if (!minor) if (!minor)
return 0; return 0;
dev = minor->dev; dev = minor->dev;
ret = drm_debugfs_create_files(a5xx_debugfs_list, drm_debugfs_create_files(a5xx_debugfs_list,
ARRAY_SIZE(a5xx_debugfs_list), ARRAY_SIZE(a5xx_debugfs_list),
minor->debugfs_root, minor); minor->debugfs_root, minor);
if (ret) {
DRM_DEV_ERROR(dev->dev, "could not install a5xx_debugfs_list\n");
return ret;
}
debugfs_create_file("reset", S_IWUGO, minor->debugfs_root, dev, debugfs_create_file("reset", S_IWUGO, minor->debugfs_root, dev,
&reset_fops); &reset_fops);
......
...@@ -259,17 +259,9 @@ static struct drm_info_list mdp5_debugfs_list[] = { ...@@ -259,17 +259,9 @@ static struct drm_info_list mdp5_debugfs_list[] = {
static int mdp5_kms_debugfs_init(struct msm_kms *kms, struct drm_minor *minor) static int mdp5_kms_debugfs_init(struct msm_kms *kms, struct drm_minor *minor)
{ {
struct drm_device *dev = minor->dev; drm_debugfs_create_files(mdp5_debugfs_list,
int ret; ARRAY_SIZE(mdp5_debugfs_list),
minor->debugfs_root, minor);
ret = drm_debugfs_create_files(mdp5_debugfs_list,
ARRAY_SIZE(mdp5_debugfs_list),
minor->debugfs_root, minor);
if (ret) {
DRM_DEV_ERROR(dev->dev, "could not install mdp5_debugfs_list\n");
return ret;
}
return 0; return 0;
} }
......
...@@ -220,14 +220,9 @@ int msm_debugfs_init(struct drm_minor *minor) ...@@ -220,14 +220,9 @@ int msm_debugfs_init(struct drm_minor *minor)
struct msm_drm_private *priv = dev->dev_private; struct msm_drm_private *priv = dev->dev_private;
int ret; int ret;
ret = drm_debugfs_create_files(msm_debugfs_list, drm_debugfs_create_files(msm_debugfs_list,
ARRAY_SIZE(msm_debugfs_list), ARRAY_SIZE(msm_debugfs_list),
minor->debugfs_root, minor); minor->debugfs_root, minor);
if (ret) {
DRM_DEV_ERROR(dev->dev, "could not install msm_debugfs_list\n");
return ret;
}
debugfs_create_file("gpu", S_IRUSR, minor->debugfs_root, debugfs_create_file("gpu", S_IRUSR, minor->debugfs_root,
dev, &msm_gpu_fops); dev, &msm_gpu_fops);
...@@ -238,7 +233,7 @@ int msm_debugfs_init(struct drm_minor *minor) ...@@ -238,7 +233,7 @@ int msm_debugfs_init(struct drm_minor *minor)
return ret; return ret;
} }
return ret; return 0;
} }
#endif #endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment