Commit 9eb0c421 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

regulator: Convert tps65xxx regulator drivers to use devm_kzalloc

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent d914d81b
...@@ -429,7 +429,7 @@ static __devinit int tps6507x_pmic_probe(struct platform_device *pdev) ...@@ -429,7 +429,7 @@ static __devinit int tps6507x_pmic_probe(struct platform_device *pdev)
if (!init_data) if (!init_data)
return -EINVAL; return -EINVAL;
tps = kzalloc(sizeof(*tps), GFP_KERNEL); tps = devm_kzalloc(&pdev->dev, sizeof(*tps), GFP_KERNEL);
if (!tps) if (!tps)
return -ENOMEM; return -ENOMEM;
...@@ -479,8 +479,6 @@ static __devinit int tps6507x_pmic_probe(struct platform_device *pdev) ...@@ -479,8 +479,6 @@ static __devinit int tps6507x_pmic_probe(struct platform_device *pdev)
fail: fail:
while (--i >= 0) while (--i >= 0)
regulator_unregister(tps->rdev[i]); regulator_unregister(tps->rdev[i]);
kfree(tps);
return error; return error;
} }
...@@ -492,9 +490,6 @@ static int __devexit tps6507x_pmic_remove(struct platform_device *pdev) ...@@ -492,9 +490,6 @@ static int __devexit tps6507x_pmic_remove(struct platform_device *pdev)
for (i = 0; i < TPS6507X_NUM_REGULATOR; i++) for (i = 0; i < TPS6507X_NUM_REGULATOR; i++)
regulator_unregister(tps->rdev[i]); regulator_unregister(tps->rdev[i]);
kfree(tps);
return 0; return 0;
} }
......
...@@ -595,7 +595,6 @@ static int pmic_remove(struct spi_device *spi) ...@@ -595,7 +595,6 @@ static int pmic_remove(struct spi_device *spi)
hw->rdev[i] = NULL; hw->rdev[i] = NULL;
} }
spi_set_drvdata(spi, NULL); spi_set_drvdata(spi, NULL);
kfree(hw);
return 0; return 0;
} }
...@@ -614,7 +613,7 @@ static int __devinit pmic_probe(struct spi_device *spi) ...@@ -614,7 +613,7 @@ static int __devinit pmic_probe(struct spi_device *spi)
return -EINVAL; return -EINVAL;
} }
hw = kzalloc(sizeof(struct tps6524x), GFP_KERNEL); hw = devm_kzalloc(&spi->dev, sizeof(struct tps6524x), GFP_KERNEL);
if (!hw) { if (!hw) {
dev_err(dev, "cannot allocate regulator private data\n"); dev_err(dev, "cannot allocate regulator private data\n");
return -ENOMEM; return -ENOMEM;
......
...@@ -1109,7 +1109,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev) ...@@ -1109,7 +1109,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
if (!pmic_plat_data) if (!pmic_plat_data)
return -EINVAL; return -EINVAL;
pmic = kzalloc(sizeof(*pmic), GFP_KERNEL); pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
if (!pmic) if (!pmic)
return -ENOMEM; return -ENOMEM;
...@@ -1136,7 +1136,6 @@ static __devinit int tps65910_probe(struct platform_device *pdev) ...@@ -1136,7 +1136,6 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
break; break;
default: default:
pr_err("Invalid tps chip version\n"); pr_err("Invalid tps chip version\n");
kfree(pmic);
return -ENODEV; return -ENODEV;
} }
...@@ -1144,7 +1143,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev) ...@@ -1144,7 +1143,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
sizeof(struct regulator_desc), GFP_KERNEL); sizeof(struct regulator_desc), GFP_KERNEL);
if (!pmic->desc) { if (!pmic->desc) {
err = -ENOMEM; err = -ENOMEM;
goto err_free_pmic; goto err_out;
} }
pmic->info = kcalloc(pmic->num_regulators, pmic->info = kcalloc(pmic->num_regulators,
...@@ -1233,8 +1232,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev) ...@@ -1233,8 +1232,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
kfree(pmic->info); kfree(pmic->info);
err_free_desc: err_free_desc:
kfree(pmic->desc); kfree(pmic->desc);
err_free_pmic: err_out:
kfree(pmic);
return err; return err;
} }
...@@ -1249,7 +1247,6 @@ static int __devexit tps65910_remove(struct platform_device *pdev) ...@@ -1249,7 +1247,6 @@ static int __devexit tps65910_remove(struct platform_device *pdev)
kfree(pmic->rdev); kfree(pmic->rdev);
kfree(pmic->info); kfree(pmic->info);
kfree(pmic->desc); kfree(pmic->desc);
kfree(pmic);
return 0; return 0;
} }
......
...@@ -477,7 +477,7 @@ static __devinit int tps65912_probe(struct platform_device *pdev) ...@@ -477,7 +477,7 @@ static __devinit int tps65912_probe(struct platform_device *pdev)
reg_data = pmic_plat_data->tps65912_pmic_init_data; reg_data = pmic_plat_data->tps65912_pmic_init_data;
pmic = kzalloc(sizeof(*pmic), GFP_KERNEL); pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
if (!pmic) if (!pmic)
return -ENOMEM; return -ENOMEM;
...@@ -523,8 +523,6 @@ static __devinit int tps65912_probe(struct platform_device *pdev) ...@@ -523,8 +523,6 @@ static __devinit int tps65912_probe(struct platform_device *pdev)
err: err:
while (--i >= 0) while (--i >= 0)
regulator_unregister(pmic->rdev[i]); regulator_unregister(pmic->rdev[i]);
kfree(pmic);
return err; return err;
} }
...@@ -535,8 +533,6 @@ static int __devexit tps65912_remove(struct platform_device *pdev) ...@@ -535,8 +533,6 @@ static int __devexit tps65912_remove(struct platform_device *pdev)
for (i = 0; i < TPS65912_NUM_REGULATOR; i++) for (i = 0; i < TPS65912_NUM_REGULATOR; i++)
regulator_unregister(tps65912_reg->rdev[i]); regulator_unregister(tps65912_reg->rdev[i]);
kfree(tps65912_reg);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment