Commit 9ec84ace authored by Ben Hutchings's avatar Ben Hutchings Committed by Ingo Molnar

lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

We do want to allow lock debugging for GPL-compatible modules
that are not (yet) built in-tree.  This was disabled as a
side-effect of commit 2449b8ba
('module,bug: Add TAINT_OOT_MODULE flag for modules not built
in-tree').  Lock debug warnings now include taint flags, so
kernel developers should still be able to deflect warnings
caused by out-of-tree modules.

The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules
will still disable lock debugging.
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Cc: Nick Bowler <nbowler@elliptictech.com>
Cc: Greg KH <greg@kroah.com>
Cc: Dave Jones <davej@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Debian kernel maintainers <debian-kernel@lists.debian.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/1323268258.18450.11.camel@deadeyeSigned-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 81140acc
...@@ -237,11 +237,12 @@ void add_taint(unsigned flag) ...@@ -237,11 +237,12 @@ void add_taint(unsigned flag)
* Can't trust the integrity of the kernel anymore. * Can't trust the integrity of the kernel anymore.
* We don't call directly debug_locks_off() because the issue * We don't call directly debug_locks_off() because the issue
* is not necessarily serious enough to set oops_in_progress to 1 * is not necessarily serious enough to set oops_in_progress to 1
* Also we want to keep up lockdep for staging development and * Also we want to keep up lockdep for staging/out-of-tree
* post-warning case. * development and post-warning case.
*/ */
switch (flag) { switch (flag) {
case TAINT_CRAP: case TAINT_CRAP:
case TAINT_OOT_MODULE:
case TAINT_WARN: case TAINT_WARN:
case TAINT_FIRMWARE_WORKAROUND: case TAINT_FIRMWARE_WORKAROUND:
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment