Commit a133d930 authored by Geliang Tang's avatar Geliang Tang Committed by Steffen Klassert

xfrm: use memdup_user

Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent a95cfad9
...@@ -2023,13 +2023,9 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen ...@@ -2023,13 +2023,9 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen
if (optlen <= 0 || optlen > PAGE_SIZE) if (optlen <= 0 || optlen > PAGE_SIZE)
return -EMSGSIZE; return -EMSGSIZE;
data = kmalloc(optlen, GFP_KERNEL); data = memdup_user(optval, optlen);
if (!data) if (IS_ERR(data))
return -ENOMEM; return PTR_ERR(data);
err = -EFAULT;
if (copy_from_user(data, optval, optlen))
goto out;
err = -EINVAL; err = -EINVAL;
rcu_read_lock(); rcu_read_lock();
...@@ -2047,7 +2043,6 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen ...@@ -2047,7 +2043,6 @@ int xfrm_user_policy(struct sock *sk, int optname, u8 __user *optval, int optlen
err = 0; err = 0;
} }
out:
kfree(data); kfree(data);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment