Commit a324cbf1 authored by Amir Goldstein's avatar Amir Goldstein Committed by Darrick J. Wong

xfs: sanity check inode di_mode

Check for invalid file type in xfs_dinode_verify()
and fail to load the inode structure from disk.
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent fab8eef8
...@@ -29,6 +29,7 @@ ...@@ -29,6 +29,7 @@
#include "xfs_icache.h" #include "xfs_icache.h"
#include "xfs_trans.h" #include "xfs_trans.h"
#include "xfs_ialloc.h" #include "xfs_ialloc.h"
#include "xfs_dir2.h"
/* /*
* Check that none of the inode's in the buffer have a next * Check that none of the inode's in the buffer have a next
...@@ -398,6 +399,8 @@ xfs_dinode_verify( ...@@ -398,6 +399,8 @@ xfs_dinode_verify(
return false; return false;
mode = be16_to_cpu(dip->di_mode); mode = be16_to_cpu(dip->di_mode);
if (mode && xfs_mode_to_ftype(mode) == XFS_DIR3_FT_UNKNOWN)
return false;
/* No zero-length symlinks/dirs. */ /* No zero-length symlinks/dirs. */
if ((S_ISLNK(mode) || S_ISDIR(mode)) && dip->di_size == 0) if ((S_ISLNK(mode) || S_ISDIR(mode)) && dip->di_size == 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment