Commit a41458d7 authored by Jani Nikula's avatar Jani Nikula Committed by Bartlomiej Zolnierkiewicz

video/fbdev: refactor video= cmdline parsing

Make the video_setup() function slightly easier to read by removing the
repeated checks for !global. Remove the misleading return value comment
while at it.

I'm slightly hesitant to change any of this, but here goes anyway, with
hopes that the next person to have to look at this has it a wee bit
easier.
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent 72aed9e3
......@@ -75,36 +75,33 @@ EXPORT_SYMBOL(fb_get_options);
* NOTE: This function is a __setup and __init function.
* It only stores the options. Drivers have to call
* fb_get_options() as necessary.
*
* Returns zero.
*
*/
static int __init video_setup(char *options)
{
int i, global = 0;
if (!options || !*options)
global = 1;
goto out;
if (!global && !strncmp(options, "ofonly", 6)) {
if (!strncmp(options, "ofonly", 6)) {
ofonly = 1;
global = 1;
goto out;
}
if (!global && !strchr(options, ':')) {
fb_mode_option = options;
global = 1;
}
if (strchr(options, ':')) {
/* named */
int i;
if (!global) {
for (i = 0; i < FB_MAX; i++) {
if (video_options[i] == NULL) {
video_options[i] = options;
break;
}
}
} else {
/* global */
fb_mode_option = options;
}
out:
return 1;
}
__setup("video=", video_setup);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment