Commit a59b2c7c authored by Ikjoon Jang's avatar Ikjoon Jang Committed by Mark Brown

spi: spi-mtk-nor: support standard spi properties

Use default supports_op() to support spi-[rt]x-bus-width properties.
And check dummy op's byte length instead of its bus width for output.
Signed-off-by: default avatarIkjoon Jang <ikjn@chromium.org>
Link: https://lore.kernel.org/r/20200826091852.519138-1-ikjn@chromium.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7708aff1
...@@ -211,25 +211,28 @@ static bool mtk_nor_supports_op(struct spi_mem *mem, ...@@ -211,25 +211,28 @@ static bool mtk_nor_supports_op(struct spi_mem *mem,
if (op->cmd.buswidth != 1) if (op->cmd.buswidth != 1)
return false; return false;
/* DTR ops not supported. */
if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr)
return false;
if (op->cmd.nbytes != 1)
return false;
if ((op->addr.nbytes == 3) || (op->addr.nbytes == 4)) { if ((op->addr.nbytes == 3) || (op->addr.nbytes == 4)) {
if ((op->data.dir == SPI_MEM_DATA_IN) && mtk_nor_match_read(op)) switch(op->data.dir) {
return true; case SPI_MEM_DATA_IN:
else if (op->data.dir == SPI_MEM_DATA_OUT) if (!mtk_nor_match_read(op))
return (op->addr.buswidth == 1) && return false;
(op->dummy.buswidth == 0) && break;
(op->data.buswidth == 1); case SPI_MEM_DATA_OUT:
if ((op->addr.buswidth != 1) ||
(op->dummy.nbytes != 0) ||
(op->data.buswidth != 1))
return false;
break;
default:
break;
}
} }
len = op->cmd.nbytes + op->addr.nbytes + op->dummy.nbytes; len = op->cmd.nbytes + op->addr.nbytes + op->dummy.nbytes;
if ((len > MTK_NOR_PRG_MAX_SIZE) || if ((len > MTK_NOR_PRG_MAX_SIZE) ||
((op->data.nbytes) && (len == MTK_NOR_PRG_MAX_SIZE))) ((op->data.nbytes) && (len == MTK_NOR_PRG_MAX_SIZE)))
return false; return false;
return true;
return spi_mem_default_supports_op(mem, op);
} }
static void mtk_nor_setup_bus(struct mtk_nor *sp, const struct spi_mem_op *op) static void mtk_nor_setup_bus(struct mtk_nor *sp, const struct spi_mem_op *op)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment