Commit a5b2e028 authored by Eli Billauer's avatar Eli Billauer Committed by Greg Kroah-Hartman

staging: xillybus: Remove mmiowb() before wait_event_*() calls

According to Documentation/memory-barriers.txt, a memory barrier is put
in place by wait_event_*()
Signed-off-by: default avatarEli Billauer <eli.billauer@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4102f90
...@@ -640,7 +640,6 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint) ...@@ -640,7 +640,6 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
iowrite32(1 | iowrite32(1 |
(3 << 24), /* Opcode 3 for channel 0 = Send IDT */ (3 << 24), /* Opcode 3 for channel 0 = Send IDT */
endpoint->registers + fpga_buf_ctrl_reg); endpoint->registers + fpga_buf_ctrl_reg);
mmiowb(); /* Just to appear safe */
wait_event_interruptible_timeout(channel->wr_wait, wait_event_interruptible_timeout(channel->wr_wait,
(!channel->wr_sleepy), (!channel->wr_sleepy),
...@@ -1986,7 +1985,6 @@ static int xilly_quiesce(struct xilly_endpoint *endpoint) ...@@ -1986,7 +1985,6 @@ static int xilly_quiesce(struct xilly_endpoint *endpoint)
wmb(); /* Make sure idtlen is set before sending command */ wmb(); /* Make sure idtlen is set before sending command */
iowrite32((u32) (endpoint->dma_using_dac & 0x0001), iowrite32((u32) (endpoint->dma_using_dac & 0x0001),
endpoint->registers + fpga_dma_control_reg); endpoint->registers + fpga_dma_control_reg);
mmiowb();
wait_event_interruptible_timeout(endpoint->ep_wait, wait_event_interruptible_timeout(endpoint->ep_wait,
(endpoint->idtlen >= 0), (endpoint->idtlen >= 0),
...@@ -2055,7 +2053,6 @@ int xillybus_endpoint_discovery(struct xilly_endpoint *endpoint) ...@@ -2055,7 +2053,6 @@ int xillybus_endpoint_discovery(struct xilly_endpoint *endpoint)
*/ */
iowrite32((u32) (endpoint->dma_using_dac & 0x0001), iowrite32((u32) (endpoint->dma_using_dac & 0x0001),
endpoint->registers + fpga_dma_control_reg); endpoint->registers + fpga_dma_control_reg);
mmiowb();
wait_event_interruptible_timeout(endpoint->ep_wait, wait_event_interruptible_timeout(endpoint->ep_wait,
(endpoint->idtlen >= 0), (endpoint->idtlen >= 0),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment