Commit a5ef6567 authored by Joe Moriarty's avatar Joe Moriarty Committed by Daniel Vetter

drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

The Parfait (version 2.1.0) static code analysis tool found the
following NULL pointer derefernce problem.

- drivers/gpu/drm/drm_edid.c
The call to drm_cvt_mode() in function drm_mode_std() for the
HDTV hack resulted in the possibility of accessing a NULL pointer
if drm_mode_std() returned NULL.  A check for this added right after
the call to drm_cvt_mode() in this particular area of code.
Signed-off-by: default avatarJoe Moriarty <joe.moriarty@oracle.com>
Reviewed-by: default avatarSteven Sistare <steven.sistare@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180212195144.98323-4-joe.moriarty@oracle.com
parent 22a07038
...@@ -2083,6 +2083,8 @@ drm_mode_std(struct drm_connector *connector, struct edid *edid, ...@@ -2083,6 +2083,8 @@ drm_mode_std(struct drm_connector *connector, struct edid *edid,
if (hsize == 1366 && vsize == 768 && vrefresh_rate == 60) { if (hsize == 1366 && vsize == 768 && vrefresh_rate == 60) {
mode = drm_cvt_mode(dev, 1366, 768, vrefresh_rate, 0, 0, mode = drm_cvt_mode(dev, 1366, 768, vrefresh_rate, 0, 0,
false); false);
if (!mode)
return NULL;
mode->hdisplay = 1366; mode->hdisplay = 1366;
mode->hsync_start = mode->hsync_start - 1; mode->hsync_start = mode->hsync_start - 1;
mode->hsync_end = mode->hsync_end - 1; mode->hsync_end = mode->hsync_end - 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment