Commit a7bbabd9 authored by Thomas Zimmermann's avatar Thomas Zimmermann

drm/udl: Don't set struct drm_crtc_state.no_vblank explicitly

As udl does not initialize vblanking, atomic helpers initialize the
value of struct drm_crtc_state.no_vblank to be true. No need to set
it from within the driver.
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200129120531.6891-13-tzimmermann@suse.de
parent 3bace4f9
...@@ -375,8 +375,6 @@ udl_simple_display_pipe_enable(struct drm_simple_display_pipe *pipe, ...@@ -375,8 +375,6 @@ udl_simple_display_pipe_enable(struct drm_simple_display_pipe *pipe,
char *wrptr; char *wrptr;
int color_depth = UDL_COLOR_DEPTH_16BPP; int color_depth = UDL_COLOR_DEPTH_16BPP;
crtc_state->no_vblank = true;
buf = (char *)udl->mode_buf; buf = (char *)udl->mode_buf;
/* This first section has to do with setting the base address on the /* This first section has to do with setting the base address on the
...@@ -428,14 +426,6 @@ udl_simple_display_pipe_disable(struct drm_simple_display_pipe *pipe) ...@@ -428,14 +426,6 @@ udl_simple_display_pipe_disable(struct drm_simple_display_pipe *pipe)
udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer); udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer);
} }
static int
udl_simple_display_pipe_check(struct drm_simple_display_pipe *pipe,
struct drm_plane_state *plane_state,
struct drm_crtc_state *crtc_state)
{
return 0;
}
static void static void
udl_simple_display_pipe_update(struct drm_simple_display_pipe *pipe, udl_simple_display_pipe_update(struct drm_simple_display_pipe *pipe,
struct drm_plane_state *old_plane_state) struct drm_plane_state *old_plane_state)
...@@ -457,7 +447,6 @@ struct drm_simple_display_pipe_funcs udl_simple_display_pipe_funcs = { ...@@ -457,7 +447,6 @@ struct drm_simple_display_pipe_funcs udl_simple_display_pipe_funcs = {
.mode_valid = udl_simple_display_pipe_mode_valid, .mode_valid = udl_simple_display_pipe_mode_valid,
.enable = udl_simple_display_pipe_enable, .enable = udl_simple_display_pipe_enable,
.disable = udl_simple_display_pipe_disable, .disable = udl_simple_display_pipe_disable,
.check = udl_simple_display_pipe_check,
.update = udl_simple_display_pipe_update, .update = udl_simple_display_pipe_update,
.prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment