Commit a82a45f6 authored by Oliver Neukum's avatar Oliver Neukum Committed by Mauro Carvalho Chehab

[media] uvcvideo: Fix race of open and suspend in error case

Ming Lei reported:
IMO, there is a minor fault in the error handling path of
uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should
have been decreased before usb_autopm_put_interface(). In theory, a [URB
resubmission] warning can be triggered when the device is opened just
between usb_autopm_put_interface() and atomic_dec(&stream->dev->users).
The fix is trivial.
Reported-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8c0d44e2
...@@ -501,8 +501,8 @@ static int uvc_v4l2_open(struct file *file) ...@@ -501,8 +501,8 @@ static int uvc_v4l2_open(struct file *file)
if (atomic_inc_return(&stream->dev->users) == 1) { if (atomic_inc_return(&stream->dev->users) == 1) {
ret = uvc_status_start(stream->dev); ret = uvc_status_start(stream->dev);
if (ret < 0) { if (ret < 0) {
usb_autopm_put_interface(stream->dev->intf);
atomic_dec(&stream->dev->users); atomic_dec(&stream->dev->users);
usb_autopm_put_interface(stream->dev->intf);
kfree(handle); kfree(handle);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment