Commit a8fc91af authored by Mathias Krause's avatar Mathias Krause Committed by Tomi Valkeinen

atyfb: mark DMI system id table as __initconst

We can mark the DMI system id table as __initconst by using a helper
variable that'll tell us if we need to unregister the reboot notifier in
atyfb_exit() instead of matching the DMI system id again.

This frees up ~680 bytes of runtime memory, the DMI table occupies.
Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent eaa27f34
...@@ -3948,7 +3948,7 @@ static struct notifier_block atyfb_reboot_notifier = { ...@@ -3948,7 +3948,7 @@ static struct notifier_block atyfb_reboot_notifier = {
.notifier_call = atyfb_reboot_notify, .notifier_call = atyfb_reboot_notify,
}; };
static const struct dmi_system_id atyfb_reboot_ids[] = { static const struct dmi_system_id atyfb_reboot_ids[] __initconst = {
{ {
.ident = "HP OmniBook 500", .ident = "HP OmniBook 500",
.matches = { .matches = {
...@@ -3960,6 +3960,7 @@ static const struct dmi_system_id atyfb_reboot_ids[] = { ...@@ -3960,6 +3960,7 @@ static const struct dmi_system_id atyfb_reboot_ids[] = {
{ } { }
}; };
static bool registered_notifier = false;
static int __init atyfb_init(void) static int __init atyfb_init(void)
{ {
...@@ -3982,15 +3983,17 @@ static int __init atyfb_init(void) ...@@ -3982,15 +3983,17 @@ static int __init atyfb_init(void)
if (err1 && err2) if (err1 && err2)
return -ENODEV; return -ENODEV;
if (dmi_check_system(atyfb_reboot_ids)) if (dmi_check_system(atyfb_reboot_ids)) {
register_reboot_notifier(&atyfb_reboot_notifier); register_reboot_notifier(&atyfb_reboot_notifier);
registered_notifier = true;
}
return 0; return 0;
} }
static void __exit atyfb_exit(void) static void __exit atyfb_exit(void)
{ {
if (dmi_check_system(atyfb_reboot_ids)) if (registered_notifier)
unregister_reboot_notifier(&atyfb_reboot_notifier); unregister_reboot_notifier(&atyfb_reboot_notifier);
#ifdef CONFIG_PCI #ifdef CONFIG_PCI
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment