Commit aa1f2f0a authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville

brcm80211: smac: precendence bug in wlc_phy_attach()

Negate has higher precendence than compare and since neither zero nor
one are equal to four or eight the original condition is always false.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 29942bc1
...@@ -482,8 +482,8 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core, ...@@ -482,8 +482,8 @@ wlc_phy_attach(struct shared_phy *sh, struct bcma_device *d11core,
pi->pubpi.phy_corenum = PHY_CORE_NUM_2; pi->pubpi.phy_corenum = PHY_CORE_NUM_2;
pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT; pi->pubpi.ana_rev = (phyversion & PV_AV_MASK) >> PV_AV_SHIFT;
if (!pi->pubpi.phy_type == PHY_TYPE_N && if (pi->pubpi.phy_type != PHY_TYPE_N &&
!pi->pubpi.phy_type == PHY_TYPE_LCN) pi->pubpi.phy_type != PHY_TYPE_LCN)
goto err; goto err;
if (bandtype == BRCM_BAND_5G) { if (bandtype == BRCM_BAND_5G) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment