Commit aa731872 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by David S. Miller

drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister before mdiobus_free

Based on commit b27393ae

Calling mdiobus_free without calling mdiobus_unregister causes
BUG_ON(). This patch fixes the issue.

The semantic patch that found this issue(http://coccinelle.lip6.fr/):
// <smpl>
@@
expression E;
@@
  ... when != mdiobus_unregister(E);

+ mdiobus_unregister(E);
  mdiobus_free(E);
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57c10b61
...@@ -234,6 +234,7 @@ void free_mdio_bitbang(struct mii_bus *bus) ...@@ -234,6 +234,7 @@ void free_mdio_bitbang(struct mii_bus *bus)
struct mdiobb_ctrl *ctrl = bus->priv; struct mdiobb_ctrl *ctrl = bus->priv;
module_put(ctrl->ops->owner); module_put(ctrl->ops->owner);
mdiobus_unregister(bus);
mdiobus_free(bus); mdiobus_free(bus);
} }
EXPORT_SYMBOL(free_mdio_bitbang); EXPORT_SYMBOL(free_mdio_bitbang);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment