Commit aaf2c2fb authored by Tyler Baicar's avatar Tyler Baicar Committed by Rafael J. Wysocki

ACPI / APEI: clear error status before acknowledging the error

Currently we acknowledge errors before clearing the error status.
This could cause a new error to be populated by firmware in-between
the error acknowledgment and the error status clearing which would
cause the second error's status to be cleared without being handled.
So, clear the error status before acknowledging the errors.

Also, make sure to acknowledge the error if the error status read
fails.
Signed-off-by: default avatarTyler Baicar <tbaicar@codeaurora.org>
Reviewed-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent e931d0da
...@@ -743,17 +743,19 @@ static int ghes_proc(struct ghes *ghes) ...@@ -743,17 +743,19 @@ static int ghes_proc(struct ghes *ghes)
} }
ghes_do_proc(ghes, ghes->estatus); ghes_do_proc(ghes, ghes->estatus);
out:
ghes_clear_estatus(ghes);
if (rc == -ENOENT)
return rc;
/* /*
* GHESv2 type HEST entries introduce support for error acknowledgment, * GHESv2 type HEST entries introduce support for error acknowledgment,
* so only acknowledge the error if this support is present. * so only acknowledge the error if this support is present.
*/ */
if (is_hest_type_generic_v2(ghes)) { if (is_hest_type_generic_v2(ghes))
rc = ghes_ack_error(ghes->generic_v2); return ghes_ack_error(ghes->generic_v2);
if (rc)
return rc;
}
out:
ghes_clear_estatus(ghes);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment