Commit ab130961 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Dave Airlie

drm/sysfs: Remove stale comments about calling drm_sysfs_connector_add() multiple times

drm_connector_sysfs_add() explicitly checks if connector->kdev
is already populated and returns success. So it clearly now allows
being called multiple times. Remove some stale comments to the contrary.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 721529b5
...@@ -366,11 +366,6 @@ static struct bin_attribute edid_attr = { ...@@ -366,11 +366,6 @@ static struct bin_attribute edid_attr = {
* properties (so far, connection status, dpms, mode list & edid) and * properties (so far, connection status, dpms, mode list & edid) and
* generate a hotplug event so userspace knows there's a new connector * generate a hotplug event so userspace knows there's a new connector
* available. * available.
*
* Note:
* This routine should only be called *once* for each registered connector.
* A second call for an already registered connector will trigger the BUG_ON
* below.
*/ */
int drm_sysfs_connector_add(struct drm_connector *connector) int drm_sysfs_connector_add(struct drm_connector *connector)
{ {
...@@ -383,7 +378,6 @@ int drm_sysfs_connector_add(struct drm_connector *connector) ...@@ -383,7 +378,6 @@ int drm_sysfs_connector_add(struct drm_connector *connector)
if (connector->kdev) if (connector->kdev)
return 0; return 0;
/* We shouldn't get called more than once for the same connector */
connector->kdev = device_create(drm_class, dev->primary->kdev, connector->kdev = device_create(drm_class, dev->primary->kdev,
0, connector, "card%d-%s", 0, connector, "card%d-%s",
dev->primary->index, drm_get_connector_name(connector)); dev->primary->index, drm_get_connector_name(connector));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment