Commit ad37c85c authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: adv_pci1710: store the pci_dev in the comedi_device

Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f5d1b9a
...@@ -248,7 +248,6 @@ static const struct boardtype boardtypes[] = { ...@@ -248,7 +248,6 @@ static const struct boardtype boardtypes[] = {
}; };
struct pci1710_private { struct pci1710_private {
struct pci_dev *pcidev; /* ptr to PCI device */
char valid; /* card is usable */ char valid; /* card is usable */
char neverending_ai; /* we do unlimited AI */ char neverending_ai; /* we do unlimited AI */
unsigned int CntrlReg; /* Control register */ unsigned int CntrlReg; /* Control register */
...@@ -1378,6 +1377,7 @@ static struct pci_dev *pci1710_find_pci_dev(struct comedi_device *dev, ...@@ -1378,6 +1377,7 @@ static struct pci_dev *pci1710_find_pci_dev(struct comedi_device *dev,
static int pci1710_attach(struct comedi_device *dev, static int pci1710_attach(struct comedi_device *dev,
struct comedi_devconfig *it) struct comedi_devconfig *it)
{ {
struct pci_dev *pcidev;
struct comedi_subdevice *s; struct comedi_subdevice *s;
int ret, subdev, n_subdevices; int ret, subdev, n_subdevices;
unsigned int irq; unsigned int irq;
...@@ -1388,16 +1388,17 @@ static int pci1710_attach(struct comedi_device *dev, ...@@ -1388,16 +1388,17 @@ static int pci1710_attach(struct comedi_device *dev,
if (ret < 0) if (ret < 0)
return -ENOMEM; return -ENOMEM;
devpriv->pcidev = pci1710_find_pci_dev(dev, it); pcidev = pci1710_find_pci_dev(dev, it);
if (!devpriv->pcidev) if (!pcidev)
return -EIO; return -EIO;
comedi_set_hw_dev(dev, &pcidev->dev);
ret = comedi_pci_enable(devpriv->pcidev, DRV_NAME); ret = comedi_pci_enable(pcidev, DRV_NAME);
if (ret) if (ret)
return ret; return ret;
dev->iobase = pci_resource_start(devpriv->pcidev, 2); dev->iobase = pci_resource_start(pcidev, 2);
irq = devpriv->pcidev->irq; irq = pcidev->irq;
dev->board_name = this_board->name; dev->board_name = this_board->name;
...@@ -1532,16 +1533,18 @@ static int pci1710_attach(struct comedi_device *dev, ...@@ -1532,16 +1533,18 @@ static int pci1710_attach(struct comedi_device *dev,
static void pci1710_detach(struct comedi_device *dev) static void pci1710_detach(struct comedi_device *dev)
{ {
struct pci_dev *pcidev = comedi_to_pci_dev(dev);
if (dev->private) { if (dev->private) {
if (devpriv->valid) if (devpriv->valid)
pci1710_reset(dev); pci1710_reset(dev);
if (dev->irq) if (dev->irq)
free_irq(dev->irq, dev); free_irq(dev->irq, dev);
if (devpriv->pcidev) { }
if (dev->iobase) if (pcidev) {
comedi_pci_disable(devpriv->pcidev); if (dev->iobase)
pci_dev_put(devpriv->pcidev); comedi_pci_disable(pcidev);
} pci_dev_put(pcidev);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment