Commit ad95028a authored by Petros Koutoupis's avatar Petros Koutoupis Committed by Martin K. Petersen

scsi: scsi_error: DID_SOFT_ERROR comment clean up

Updated comment. We are keeping track of maximum number of retries per
command via retries/allowed in struct scsi_cmnd. Corrected comment
positioning.

[mkp: applied by hand]
Signed-off-by: default avatarPetros Koutoupis <petros@petroskoutoupis.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e33d7c56
......@@ -1753,16 +1753,12 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
* that it indicates SUCCESS.
*/
return SUCCESS;
case DID_SOFT_ERROR:
/*
* when the low level driver returns did_soft_error,
* it is responsible for keeping an internal retry counter
* in order to avoid endless loops (db)
*
* actually this is a bug in this function here. we should
* be mindful of the maximum number of retries specified
* and not get stuck in a loop.
*/
case DID_SOFT_ERROR:
goto maybe_retry;
case DID_IMM_RETRY:
return NEEDS_RETRY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment